binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-3101] fix: quick links error in home (#6371)

Browse source
This commit is contained in:
Sangeetha 2025-01-10 13:02:14 +05:30 • committed by GitHub
parent 8a6a5a8ca7
commit 06ecbe884c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 27 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

31
apiserver/plane/app/views/workspace/quick_link.py
View file

@ -8,6 +8,7 @@ from plane.app.serializers import WorkspaceUserLinkSerializer
from ..base import BaseViewSet from ..base import BaseViewSet
from plane.app.permissions import allow_permission, ROLE from plane.app.permissions import allow_permission, ROLE
class QuickLinkViewSet(BaseViewSet): class QuickLinkViewSet(BaseViewSet):
model = WorkspaceUserLink model = WorkspaceUserLink
@ -16,7 +17,7 @@ class QuickLinkViewSet(BaseViewSet):
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE") @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def create(self, request, slug): def create(self, request, slug):
workspace = Workspace.objects.get(slug=slug, owner=request.user) workspace = Workspace.objects.get(slug=slug)
serializer = WorkspaceUserLinkSerializer(data=request.data) serializer = WorkspaceUserLinkSerializer(data=request.data)
if serializer.is_valid(): if serializer.is_valid():
@ -24,44 +25,50 @@ class QuickLinkViewSet(BaseViewSet):
return Response(serializer.data, status=status.HTTP_201_CREATED) return Response(serializer.data, status=status.HTTP_201_CREATED)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE") @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def partial_update(self, request, slug, pk): def partial_update(self, request, slug, pk):
quick_link = WorkspaceUserLink.objects.filter(pk=pk, workspace__slug=slug, owner=request.user).first() quick_link = WorkspaceUserLink.objects.filter(
pk=pk, workspace__slug=slug, owner=request.user
).first()
if quick_link: if quick_link:
serializer = WorkspaceUserLinkSerializer(quick_link, data=request.data, partial=True) serializer = WorkspaceUserLinkSerializer(
quick_link, data=request.data, partial=True
)
if serializer.is_valid(): if serializer.is_valid():
serializer.save() serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK) return Response(serializer.data, status=status.HTTP_200_OK)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
return Response({"detail": "Quick link not found."}, status=status.HTTP_404_NOT_FOUND) return Response(
{"detail": "Quick link not found."}, status=status.HTTP_404_NOT_FOUND
)
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE") @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def retrieve(self, request, slug, pk): def retrieve(self, request, slug, pk):
try: try:
quick_link = WorkspaceUserLink.objects.get( quick_link = WorkspaceUserLink.objects.get(
pk=pk, pk=pk, workspace__slug=slug, owner=request.user
workspace__slug=slug,
owner=request.user
) )
serializer = WorkspaceUserLinkSerializer(quick_link) serializer = WorkspaceUserLinkSerializer(quick_link)
return Response(serializer.data, status=status.HTTP_200_OK) return Response(serializer.data, status=status.HTTP_200_OK)
except WorkspaceUserLink.DoesNotExist: except WorkspaceUserLink.DoesNotExist:
return Response( return Response(
{"error": "Quick link not found."}, {"error": "Quick link not found."}, status=status.HTTP_404_NOT_FOUND
status=status.HTTP_404_NOT_FOUND
) )
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE") @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def destroy(self, request, slug, pk): def destroy(self, request, slug, pk):
quick_link = WorkspaceUserLink.objects.get(pk=pk, workspace__slug=slug, owner=request.user) quick_link = WorkspaceUserLink.objects.get(
pk=pk, workspace__slug=slug, owner=request.user
)
quick_link.delete() quick_link.delete()
return Response(status=status.HTTP_204_NO_CONTENT) return Response(status=status.HTTP_204_NO_CONTENT)
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE") @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def list(self, request, slug): def list(self, request, slug):
quick_links = WorkspaceUserLink.objects.filter(workspace__slug=slug, owner=request.user) quick_links = WorkspaceUserLink.objects.filter(
workspace__slug=slug, owner=request.user
)
serializer = WorkspaceUserLinkSerializer(quick_links, many=True) serializer = WorkspaceUserLinkSerializer(quick_links, many=True)
return Response(serializer.data, status=status.HTTP_200_OK) return Response(serializer.data, status=status.HTTP_200_OK)