binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* fix: avoided uncessary api call while creating issue draft (#6230)

Browse source 
* fix: fixed import order in module header
This commit is contained in:
Vamsi Krishna 2024-12-19 16:26:35 +05:30 • committed by GitHub
parent 44d8de1169
commit 0a320a8540
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

28
web/core/components/issues/issue-modal/base.tsx
View file

@ -187,19 +187,21 @@ export const CreateUpdateIssueModalBase: React.FC<IssuesModalProps> = observer((
if (!response) throw new Error(); if (!response) throw new Error();
// check if we should add issue to cycle/module // check if we should add issue to cycle/module
if ( if (!is_draft_issue) {
payload.cycle_id && if (
payload.cycle_id !== "" && payload.cycle_id &&
(payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE) payload.cycle_id !== "" &&
) { (payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE)
await addIssueToCycle(response, payload.cycle_id); ) {
} await addIssueToCycle(response, payload.cycle_id);
if ( }
payload.module_ids && if (
payload.module_ids.length > 0 && payload.module_ids &&
(!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE) payload.module_ids.length > 0 &&
) { (!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE)
await addIssueToModule(response, payload.module_ids); ) {
await addIssueToModule(response, payload.module_ids);
}
} }
// add other property values // add other property values

2
web/core/components/modules/module-view-header.tsx
View file

@ -4,13 +4,13 @@ import React, { FC, useCallback, useEffect, useRef, useState } from "react";
import { observer } from "mobx-react"; import { observer } from "mobx-react";
import { useParams } from "next/navigation"; import { useParams } from "next/navigation";
import { ListFilter, Search, X } from "lucide-react"; import { ListFilter, Search, X } from "lucide-react";
// plane utils
// plane helpers // plane helpers
import { useOutsideClickDetector } from "@plane/hooks"; import { useOutsideClickDetector } from "@plane/hooks";
// types // types
import { TModuleFilters } from "@plane/types"; import { TModuleFilters } from "@plane/types";
// ui // ui
import { Tooltip } from "@plane/ui"; import { Tooltip } from "@plane/ui";
// plane utils
import { cn } from "@plane/utils"; import { cn } from "@plane/utils";
// components // components
import { FiltersDropdown } from "@/components/issues"; import { FiltersDropdown } from "@/components/issues";