chore: run fixes (#8257)

* chore: run fixes

* fix: type, just use hocuspocusservercontext

* fix: codemod

---------

Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com>
This commit is contained in:
Aaron 2025-12-08 23:56:50 +07:00 committed by GitHub
parent a9e9cb2983
commit 0ab94ed6d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
172 changed files with 1784 additions and 1798 deletions

View file

@ -174,7 +174,7 @@ export class GlobalViewStore implements IGlobalViewStore {
);
this.rootStore.issue.workspaceIssues.fetchIssuesWithExistingPagination(workspaceSlug, viewId, "mutation");
}
return currentView as IWorkspaceView;
return currentView;
} catch {
Object.keys(data).forEach((key) => {
const currentKey = key as keyof IWorkspaceView;

View file

@ -64,7 +64,7 @@ export interface IProjectInboxStore {
workspaceSlug: string,
projectId: string,
loadingType?: TLoader,
tab?: TInboxIssueCurrentTab | undefined
tab?: TInboxIssueCurrentTab
) => Promise<void>;
fetchInboxPaginationIssues: (workspaceSlug: string, projectId: string) => Promise<void>;
fetchInboxIssueById: (workspaceSlug: string, projectId: string, inboxIssueId: string) => Promise<TInboxIssue>;

View file

@ -202,7 +202,7 @@ export class CycleIssuesFilter extends IssueFilterHelperStore implements ICycleI
if (isEmpty(this.filters) || isEmpty(this.filters[cycleId])) return;
const _filters = {
richFilters: this.filters[cycleId].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[cycleId].richFilters,
displayFilters: this.filters[cycleId].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[cycleId].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[cycleId].kanbanFilters as TIssueKanbanFilters,

View file

@ -131,7 +131,7 @@ export class CycleIssues extends BaseIssuesStore implements ICycleIssues {
* @param projectId
* @param id is the cycle Id
*/
fetchParentStats = (workspaceSlug: string, projectId?: string | undefined, id?: string | undefined) => {
fetchParentStats = (workspaceSlug: string, projectId?: string, id?: string) => {
const cycleId = id ?? this.cycleId;
if (projectId && cycleId) {
@ -150,7 +150,7 @@ export class CycleIssues extends BaseIssuesStore implements ICycleIssues {
}
};
updateParentStats = (prevIssueState?: TIssue, nextIssueState?: TIssue, id?: string | undefined) => {
updateParentStats = (prevIssueState?: TIssue, nextIssueState?: TIssue, id?: string) => {
try {
const distributionUpdates = getDistributionPathsPostUpdate(
prevIssueState,
@ -305,12 +305,7 @@ export class CycleIssues extends BaseIssuesStore implements ICycleIssues {
}
) => {
// call API call to transfer issues
const response = await this.cycleService.transferIssues(
workspaceSlug as string,
projectId as string,
cycleId as string,
payload
);
const response = await this.cycleService.transferIssues(workspaceSlug, projectId, cycleId, payload);
// call fetch issues
if (this.paginationOptions) {
await this.fetchIssues(workspaceSlug, projectId, "mutation", this.paginationOptions, cycleId);

View file

@ -249,12 +249,12 @@ export const getFilteredWorkItems = (workItems: TIssue[], filters: IIssueFilterO
activeFilters.every(([filterKey, filterValues]) => {
// Handle date filters separately
if (filterKey === "start_date" || filterKey === "target_date") {
return checkIssueDateFilter(workItem, filterKey as "start_date" | "target_date", filterValues as string[]);
return checkIssueDateFilter(workItem, filterKey, filterValues as string[]);
}
// Handle regular filters
const issueKey = FILTER_TO_ISSUE_MAP[filterKey as keyof IIssueFilterOptions];
if (!issueKey) return true; // Skip if no mapping exists
const issueValue = workItem[issueKey as keyof TIssue];
const issueValue = workItem[issueKey];
// Handle array-based properties vs single value properties
if (Array.isArray(issueValue)) {
return filterValues!.some((filterValue: any) => issueValue.includes(filterValue));
@ -338,7 +338,7 @@ export const getGroupedWorkItemIds = (
// Convert to Record type
const groupedWorkItemsRecord: Record<string, string[]> = {};
Object.entries(groupedWorkItems).forEach(([key, items]) => {
groupedWorkItemsRecord[key] = getOrderedWorkItems(items as TIssue[], orderByKey);
groupedWorkItemsRecord[key] = getOrderedWorkItems(items, orderByKey);
});
return groupedWorkItemsRecord;

View file

@ -307,15 +307,15 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
const allIssues = groupedIssueIds[ALL_ISSUES] ?? [];
if (!this.groupBy && !this.subGroupBy && allIssues && Array.isArray(allIssues)) {
return allIssues as string[];
return allIssues;
}
if (this.groupBy && groupId && groupedIssueIds?.[groupId] && Array.isArray(groupedIssueIds[groupId])) {
return (groupedIssueIds[groupId] ?? []) as string[];
return groupedIssueIds[groupId] ?? [];
}
if (this.groupBy && this.subGroupBy && groupId && subGroupId) {
return ((groupedIssueIds as TSubGroupedIssues)[groupId]?.[subGroupId] ?? []) as string[];
return (groupedIssueIds as TSubGroupedIssues)[groupId]?.[subGroupId] ?? [];
}
return undefined;
@ -1405,7 +1405,7 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
// if groupedIssueIds is an array, update the `groupedIssueIds` store at the issuePath
if (groupedIssueIds && Array.isArray(groupedIssueIds)) {
update(this, ["groupedIssueIds", ...issuePath], (issueIds: string[] = []) =>
this.issuesSortWithOrderBy(uniq(concat(issueIds, groupedIssueIds as string[])), this.orderBy)
this.issuesSortWithOrderBy(uniq(concat(issueIds, groupedIssueIds)), this.orderBy)
);
// return true to indicate the store has been updated
return true;
@ -1617,7 +1617,7 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
getArrayStringArray = (
issueObject: Partial<TIssue> | undefined,
value: string | string[] | undefined | null,
groupByKey?: TIssueGroupByOptions | undefined
groupByKey?: TIssueGroupByOptions
): string[] => {
// if issue object is undefined return empty array
if (!issueObject) return [];

View file

@ -207,7 +207,7 @@ export abstract class IssueDetail implements IIssueDetail {
this.issue = new IssueStore(this, serviceType);
this.reaction = new IssueReactionStore(this, serviceType);
this.attachment = new IssueAttachmentStore(rootStore, serviceType);
this.activity = new IssueActivityStore(rootStore.rootStore as RootStore, serviceType);
this.activity = new IssueActivityStore(rootStore.rootStore, serviceType);
this.comment = new IssueCommentStore(this, serviceType);
this.commentReaction = new IssueCommentReactionStore(this);
this.subIssues = new IssueSubIssuesStore(this, serviceType);

View file

@ -207,7 +207,7 @@ export class ModuleIssuesFilter extends IssueFilterHelperStore implements IModul
if (isEmpty(this.filters) || isEmpty(this.filters[moduleId])) return;
const _filters = {
richFilters: this.filters[moduleId].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[moduleId].richFilters,
displayFilters: this.filters[moduleId].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[moduleId].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[moduleId].kanbanFilters as TIssueKanbanFilters,

View file

@ -85,7 +85,7 @@ export class ModuleIssues extends BaseIssuesStore implements IModuleIssues {
* @param projectId
* @param id is the module Id
*/
fetchParentStats = (workspaceSlug: string, projectId?: string | undefined, id?: string | undefined) => {
fetchParentStats = (workspaceSlug: string, projectId?: string, id?: string) => {
const moduleId = id ?? this.moduleId;
projectId &&
moduleId &&
@ -98,7 +98,7 @@ export class ModuleIssues extends BaseIssuesStore implements IModuleIssues {
* @param nextIssueState
* @param id
*/
updateParentStats = (prevIssueState?: TIssue, nextIssueState?: TIssue, id?: string | undefined) => {
updateParentStats = (prevIssueState?: TIssue, nextIssueState?: TIssue, id?: string) => {
try {
// get distribution updates
const distributionUpdates = getDistributionPathsPostUpdate(

View file

@ -183,7 +183,7 @@ export class ProfileIssuesFilter extends IssueFilterHelperStore implements IProf
if (isEmpty(this.filters) || isEmpty(this.filters[userId])) return;
const _filters = {
richFilters: this.filters[userId].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[userId].richFilters,
displayFilters: this.filters[userId].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[userId].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[userId].kanbanFilters as TIssueKanbanFilters,

View file

@ -216,7 +216,7 @@ export class ProjectViewIssuesFilter extends IssueFilterHelperStore implements I
if (isEmpty(this.filters) || isEmpty(this.filters[viewId])) return;
const _filters = {
richFilters: this.filters[viewId].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[viewId].richFilters,
displayFilters: this.filters[viewId].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[viewId].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[viewId].kanbanFilters as TIssueKanbanFilters,

View file

@ -190,7 +190,7 @@ export class ProjectIssuesFilter extends IssueFilterHelperStore implements IProj
if (isEmpty(this.filters) || isEmpty(this.filters[projectId])) return;
const _filters = {
richFilters: this.filters[projectId].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[projectId].richFilters,
displayFilters: this.filters[projectId].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[projectId].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[projectId].kanbanFilters as TIssueKanbanFilters,

View file

@ -189,7 +189,7 @@ export class WorkspaceDraftIssuesFilter extends IssueFilterHelperStore implement
if (isEmpty(this.filters) || isEmpty(this.filters[workspaceSlug])) return;
const _filters = {
richFilters: this.filters[workspaceSlug].richFilters as TWorkItemFilterExpression,
richFilters: this.filters[workspaceSlug].richFilters,
displayFilters: this.filters[workspaceSlug].displayFilters as IIssueDisplayFilterOptions,
displayProperties: this.filters[workspaceSlug].displayProperties as IIssueDisplayProperties,
kanbanFilters: this.filters[workspaceSlug].kanbanFilters as TIssueKanbanFilters,

View file

@ -24,7 +24,7 @@ import type { IBaseIssueFilterStore, IIssueFilterHelperStore } from "../helpers/
import { IssueFilterHelperStore } from "../helpers/issue-filter-helper.store";
import type { IIssueRootStore } from "../root.store";
type TWorkspaceFilters = TStaticViewTypes | string;
type TWorkspaceFilters = TStaticViewTypes;
export type TBaseFilterStore = IBaseIssueFilterStore & IIssueFilterHelperStore;
@ -132,7 +132,7 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
if (STATIC_VIEW_TYPES.includes(viewId)) {
const currentUserId = this.rootIssueStore.currentUserId;
const paramForStaticView = this.getFilterConditionBasedOnViews(currentUserId, viewId as TStaticViewTypes);
const paramForStaticView = this.getFilterConditionBasedOnViews(currentUserId, viewId);
if (paramForStaticView) {
filterParams = { ...filterParams, ...paramForStaticView };
}
@ -212,7 +212,7 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
if (!issueFilters) return;
const _filters = {
richFilters: issueFilters.richFilters as TWorkItemFilterExpression,
richFilters: issueFilters.richFilters,
displayFilters: issueFilters.displayFilters as IIssueDisplayFilterOptions,
displayProperties: issueFilters.displayProperties as IIssueDisplayProperties,
kanbanFilters: issueFilters.kanbanFilters as TIssueKanbanFilters,

View file

@ -144,7 +144,7 @@ export class WorkspaceNotificationStore implements IWorkspaceNotificationStore {
}
})
// .filter((n) => (this.filters.read ? (n.read_at ? true : false) : n.read_at ? false : true))
.map((n) => n.id) as string[];
.map((n) => n.id);
return workspaceNotificationIds;
});

View file

@ -217,7 +217,7 @@ export class ProjectPageStore implements IProjectPageStore {
const existingPage = this.getPageById(page.id);
if (existingPage) {
// If page already exists, update all fields except name
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { name, ...otherFields } = page;
existingPage.mutateProperties(otherFields, false);
} else {