binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-2338] chore: handle untitled page breadcrumbs (#5445)

Browse source 
* chore: handle untitle page titles

* chore: store page title in a const
This commit is contained in:
Aaryan Khandelwal 2024-08-28 14:35:45 +05:30 • committed by GitHub
parent 3ee14771e7
commit 0cce39ec7c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
View file

@ -13,6 +13,7 @@ import { BreadcrumbLink, Logo } from "@/components/common";
import { PageEditInformationPopover } from "@/components/pages"; import { PageEditInformationPopover } from "@/components/pages";
// helpers // helpers
import { convertHexEmojiToDecimal } from "@/helpers/emoji.helper"; import { convertHexEmojiToDecimal } from "@/helpers/emoji.helper";
import { getPageName } from "@/helpers/page.helper";
// hooks // hooks
import { usePage, useProject } from "@/hooks/store"; import { usePage, useProject } from "@/hooks/store";
import { usePlatformOS } from "@/hooks/use-platform-os"; import { usePlatformOS } from "@/hooks/use-platform-os";
@ -58,6 +59,7 @@ export const PageDetailsHeader = observer(() => {
} }
}; };
const pageTitle = getPageName(name);
const isVersionHistoryOverlayActive = !!searchParams.get("version"); const isVersionHistoryOverlayActive = !!searchParams.get("version");
return ( return (
@ -148,9 +150,9 @@ export const PageDetailsHeader = observer(() => {
} }
/> />
</div> </div>
<Tooltip tooltipContent={name ?? "Page"} position="bottom" isMobile={isMobile}> <Tooltip tooltipContent={pageTitle} position="bottom" isMobile={isMobile}>
<div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate"> <div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
{name ?? "Page"} {pageTitle}
</div> </div>
</Tooltip> </Tooltip>
</div> </div>