binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-3944] fix: Error Toast message content update while uploading images (#6969)

Browse source 
* fix: handled svg uploads

* chore: proper error message with all allowed types

---------

Co-authored-by: sangeethailango <sangeethailango21@gmail.com>
This commit is contained in:
Akshita Goyal 2025-04-25 14:30:12 +05:30 • committed by GitHub
parent f60f57ef11
commit 101994840a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
apiserver/plane/app/views/asset/v2.py
View file

@ -137,7 +137,7 @@ class UserAssetsV2Endpoint(BaseAPIView):
if type not in allowed_types: if type not in allowed_types:
return Response( return Response(
{ {
"error": "Invalid file type. Only JPEG and PNG files are allowed.", "error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False, "status": False,
}, },
status=status.HTTP_400_BAD_REQUEST, status=status.HTTP_400_BAD_REQUEST,
@ -351,7 +351,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):
if type not in allowed_types: if type not in allowed_types:
return Response( return Response(
{ {
"error": "Invalid file type. Only JPEG and PNG files are allowed.", "error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False, "status": False,
}, },
status=status.HTTP_400_BAD_REQUEST, status=status.HTTP_400_BAD_REQUEST,
@ -552,7 +552,7 @@ class ProjectAssetEndpoint(BaseAPIView):
if type not in allowed_types: if type not in allowed_types:
return Response( return Response(
{ {
"error": "Invalid file type. Only JPEG and PNG files are allowed.", "error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False, "status": False,
}, },
status=status.HTTP_400_BAD_REQUEST, status=status.HTTP_400_BAD_REQUEST,

2
apiserver/plane/space/views/asset.py
View file

@ -96,7 +96,7 @@ class EntityAssetEndpoint(BaseAPIView):
if type not in allowed_types: if type not in allowed_types:
return Response( return Response(
{ {
"error": "Invalid file type. Only JPEG and PNG files are allowed.", "error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False, "status": False,
}, },
status=status.HTTP_400_BAD_REQUEST, status=status.HTTP_400_BAD_REQUEST,

24
web/core/components/core/image-picker-popover.tsx
View file

@ -14,7 +14,7 @@ import { useOutsideClickDetector } from "@plane/hooks";
// plane types // plane types
import { EFileAssetType } from "@plane/types/src/enums"; import { EFileAssetType } from "@plane/types/src/enums";
// ui // ui
import { Button, Input, Loader } from "@plane/ui"; import { Button, Input, Loader, TOAST_TYPE, setToast } from "@plane/ui";
// helpers // helpers
import { getFileURL } from "@/helpers/file.helper"; import { getFileURL } from "@/helpers/file.helper";
// hooks // hooks
@ -114,7 +114,16 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
}, },
image image
) )
.then((res) => uploadCallback(res.asset_url)); .then((res) => uploadCallback(res.asset_url))
.catch((error) => {
console.error("Error uploading user cover image:", error);
setIsImageUploading(false);
setToast({
message: error?.error ?? "The image could not be uploaded",
type: TOAST_TYPE.ERROR,
title: "Image not uploaded",
});
});
} else { } else {
if (!workspaceSlug) return; if (!workspaceSlug) return;
await fileService await fileService
@ -126,7 +135,16 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
}, },
image image
) )
.then((res) => uploadCallback(res.asset_url)); .then((res) => uploadCallback(res.asset_url))
.catch((error) => {
console.error("Error uploading project cover image:", error);
setIsImageUploading(false);
setToast({
message: error?.error ?? "The image could not be uploaded",
type: TOAST_TYPE.ERROR,
title: "Image not uploaded",
});
});
} }
}; };