binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: update link view now updates the link (#4989)

Browse source
This commit is contained in:
M. Palanikannan 2024-07-02 19:25:32 +05:30 • committed by GitHub
parent 1201a4245e
commit 12401c54cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

17
packages/editor/src/core/components/links/link-edit-view.tsx
View file

@ -51,21 +51,6 @@ export const LinkEditView = ({
return text; return text;
}; };
const isValidUrl = (urlString: string) => {
const urlPattern = new RegExp(
"^(https?:\\/\\/)?" + // validate protocol
"([\\w-]+\\.)+[\\w-]{2,}" + // validate domain name
"|((\\d{1,3}\\.){3}\\d{1,3})" + // validate IP (v4) address
"(\\:\\d+)?(\\/[-\\w.%]+)*" + // validate port and path
"(\\?[;&\\w.%=-]*)?" + // validate query string
"(\\#[-\\w]*)?$", // validate fragment locator
"i"
);
const regexTest = urlPattern.test(urlString);
const urlTest = isValidHttpUrl(urlString); // Ensure you have defined isValidHttpUrl
return regexTest && urlTest;
};
const handleUpdateLink = (url: string) => { const handleUpdateLink = (url: string) => {
setLocalUrl(url); setLocalUrl(url);
}; };
@ -74,7 +59,7 @@ export const LinkEditView = ({
() => () => { () => () => {
if (linkRemoved.current) return; if (linkRemoved.current) return;
const url = isValidUrl(localUrl) ? localUrl : viewProps.url; const url = isValidHttpUrl(localUrl) ? localUrl : viewProps.url;
if (to >= editor.state.doc.content.size) return; if (to >= editor.state.doc.content.size) return;