fix: breaking cycle issues and replacing router.push with Links (#3330)

* fix cycle creation and active cycle map

* minor fix in cycle store

* create cycle breaking fix

* replace last possible bits of router.push with Link

---------

Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>

web/pages/create-workspace.tsx

@@ -3,6 +3,7 @@ import { useRouter } from "next/router";
 import Image from "next/image";
 import { useTheme } from "next-themes";
 import { observer } from "mobx-react-lite";
+import Link from "next/link";
 // hooks
 import { useUser } from "hooks/store";
 // layouts
@@ -39,9 +40,9 @@ const CreateWorkspacePage: NextPageWithLayout = observer(() => {
     <div className="flex h-full flex-col gap-y-2 overflow-hidden sm:flex-row sm:gap-y-0">
       <div className="relative h-1/6 flex-shrink-0 sm:w-2/12 md:w-3/12 lg:w-1/5">
         <div className="absolute left-0 top-1/2 h-[0.5px] w-full -translate-y-1/2 border-b-[0.5px] border-custom-border-200 sm:left-1/2 sm:top-0 sm:h-screen sm:w-[0.5px] sm:-translate-x-1/2 sm:translate-y-0 sm:border-r-[0.5px] md:left-1/3" />
-        <button
+        <Link
           className="absolute left-5 top-1/2 grid -translate-y-1/2 place-items-center bg-custom-background-100 px-3 sm:left-1/2 sm:top-12 sm:-translate-x-[15px] sm:translate-y-0 sm:px-0 sm:py-5 md:left-1/3"
-          onClick={() => router.push("/")}
+          href="/"
         >
           <div className="h-[30px] w-[133px]">
             {theme === "light" ? (
@@ -50,7 +51,7 @@ const CreateWorkspacePage: NextPageWithLayout = observer(() => {
               <Image src={WhiteHorizontalLogo} alt="Plane white logo" />
             )}
           </div>
-        </button>
+        </Link>
         <div className="absolute right-4 top-1/4 -translate-y-1/2 text-sm text-custom-text-100 sm:fixed sm:right-16 sm:top-12 sm:translate-y-0 sm:py-5">
           {currentUser?.email}
         </div>

web/pages/workspace-invitations/index.tsx

@@ -81,7 +81,7 @@ const WorkspaceInvitationPage: NextPageWithLayout = observer(() => {
                     title={`You are already a member of ${invitationDetail.workspace.name}`}
                     description="Your workspace is where you'll create projects, collaborate on your issues, and organize different streams of work in your Plane account."
                   >
-                    <EmptySpaceItem Icon={Boxes} title="Continue to Dashboard" action={() => router.push("/")} />
+                    <EmptySpaceItem Icon={Boxes} title="Continue to Dashboard" href="/" />
                   </EmptySpace>
                 </>
               ) : (
@@ -103,35 +103,15 @@ const WorkspaceInvitationPage: NextPageWithLayout = observer(() => {
           link={{ text: "Or start from an empty project", href: "/" }}
         >
           {!currentUser ? (
-            <EmptySpaceItem
-              Icon={User2}
-              title="Sign in to continue"
-              action={() => {
-                router.push("/");
-              }}
-            />
+            <EmptySpaceItem Icon={User2} title="Sign in to continue" href="/" />
           ) : (
-            <EmptySpaceItem
-              Icon={Boxes}
-              title="Continue to Dashboard"
-              action={() => {
-                router.push("/");
-              }}
-            />
+            <EmptySpaceItem Icon={Boxes} title="Continue to Dashboard" href="/" />
           )}
-          <EmptySpaceItem
-            Icon={Star}
-            title="Star us on GitHub"
-            action={() => {
-              router.push("https://github.com/makeplane");
-            }}
-          />
+          <EmptySpaceItem Icon={Star} title="Star us on GitHub" href="https://github.com/makeplane" />
           <EmptySpaceItem
             Icon={Share2}
             title="Join our community of active creators"
-            action={() => {
-              router.push("https://discord.com/invite/8SR2N9PAcJ");
-            }}
+            href="https://discord.com/invite/8SR2N9PAcJ"
           />
         </EmptySpace>
       ) : (