From 135024a9409a69fdafed3b790bfb87c3a4d850ab Mon Sep 17 00:00:00 2001
From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Date: Tue, 18 Jun 2024 17:51:52 +0530
Subject: [PATCH] [WEB-1397] chore: update space app types (#4861)

* chore: update types

* chore: dummy page actions components

* chore: rename component

* refactor: rearrange declarations
---
 space/core/types/issue.d.ts                    | 12 +++---------
 space/core/types/project.d.ts                  | 18 ------------------
 .../[projectId]/pages/(detail)/header.tsx      | 15 +++++++++------
 web/ce/components/pages/extra-actions.tsx      |  1 +
 web/ce/components/pages/index.ts               |  1 +
 web/ee/components/pages/extra-actions.tsx      |  1 +
 web/ee/components/pages/index.ts               |  1 +
 7 files changed, 16 insertions(+), 33 deletions(-)
 delete mode 100644 space/core/types/project.d.ts
 create mode 100644 web/ce/components/pages/extra-actions.tsx
 create mode 100644 web/ce/components/pages/index.ts
 create mode 100644 web/ee/components/pages/extra-actions.tsx
 create mode 100644 web/ee/components/pages/index.ts

diff --git a/space/core/types/issue.d.ts b/space/core/types/issue.d.ts
index 5b729d1c0..b9676810e 100644
--- a/space/core/types/issue.d.ts
+++ b/space/core/types/issue.d.ts
@@ -1,4 +1,4 @@
-import { IStateLite, IWorkspaceLite, TIssuePriorities, TStateGroups } from "@plane/types";
+import { IStateLite, IWorkspaceLite, TIssue, TIssuePriorities, TStateGroups } from "@plane/types";
 
 export type TIssueLayout = "list" | "kanban" | "calendar" | "spreadsheet" | "gantt";
 export type TIssueLayoutOptions = {
@@ -39,18 +39,13 @@ export type TIssuesResponse = {
   issues: IIssue[];
 };
 
-export interface IIssue {
-  id: string;
+export interface IIssue
+  extends Pick<TIssue, "description_html" | "id" | "name" | "priority" | "sequence_id" | "start_date" | "target_date"> {
   comments: Comment[];
-  description_html: string;
   label_details: any;
-  name: string;
-  priority: TIssuePriorityKey | null;
   project: string;
   project_detail: any;
   reactions: IIssueReaction[];
-  sequence_id: number;
-  start_date: any;
   state: string;
   state_detail: {
     id: string;
@@ -58,7 +53,6 @@ export interface IIssue {
     group: TIssueGroupKey;
     color: string;
   };
-  target_date: any;
   votes: IVote[];
 }
 
diff --git a/space/core/types/project.d.ts b/space/core/types/project.d.ts
deleted file mode 100644
index c0ae02583..000000000
--- a/space/core/types/project.d.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import { TLogoProps } from "@plane/types";
-
-export type TViewDetails = {
-  list: boolean;
-  gantt: boolean;
-  kanban: boolean;
-  calendar: boolean;
-  spreadsheet: boolean;
-};
-
-export type TProjectDetails = {
-  id: string;
-  identifier: string;
-  name: string;
-  cover_image: string | undefined;
-  logo_props: TLogoProps;
-  description: string;
-};
diff --git a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
index 73a9deda5..be903635c 100644
--- a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
+++ b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
@@ -10,11 +10,13 @@ import { TLogoProps } from "@plane/types";
 import { Breadcrumbs, Button, EmojiIconPicker, EmojiIconPickerTypes, TOAST_TYPE, setToast } from "@plane/ui";
 // components
 import { BreadcrumbLink, Logo } from "@/components/common";
-// helper
+// helpers
 import { convertHexEmojiToDecimal } from "@/helpers/emoji.helper";
 // hooks
 import { usePage, useProject } from "@/hooks/store";
 import { usePlatformOS } from "@/hooks/use-platform-os";
+// plane web components
+import { PageDetailsHeaderExtraActions } from "@/plane-web/components/pages";
 
 export interface IPagesHeaderProps {
   showButton?: boolean;
@@ -28,6 +30,10 @@ export const PageDetailsHeader = observer(() => {
   // store hooks
   const { currentProjectDetails } = useProject();
   const { isContentEditable, isSubmitting, name, logo_props, updatePageLogo } = usePage(pageId?.toString() ?? "");
+  // use platform
+  const { platform } = usePlatformOS();
+  // derived values
+  const isMac = platform === "MacOS";
 
   const handlePageLogoUpdate = async (data: TLogoProps) => {
     if (data) {
@@ -48,10 +54,6 @@ export const PageDetailsHeader = observer(() => {
         });
     }
   };
-  // use platform
-  const { platform } = usePlatformOS();
-  // derived values
-  const isMac = platform === "MacOS";
 
   return (
     <div className="relative z-10 flex h-[3.75rem] w-full flex-shrink-0 flex-row items-center justify-between gap-x-2 gap-y-4 bg-custom-sidebar-background-100 p-4">
@@ -146,6 +148,7 @@ export const PageDetailsHeader = observer(() => {
           </Breadcrumbs>
         </div>
       </div>
+      <PageDetailsHeaderExtraActions />
       {isContentEditable && (
         <Button
           variant="primary"
@@ -159,7 +162,7 @@ export const PageDetailsHeader = observer(() => {
             });
             window.dispatchEvent(event);
           }}
-          className="flex-shrink-0"
+          className="flex-shrink-0 w-24"
           loading={isSubmitting === "submitting"}
         >
           {isSubmitting === "submitting" ? "Saving" : "Save changes"}
diff --git a/web/ce/components/pages/extra-actions.tsx b/web/ce/components/pages/extra-actions.tsx
new file mode 100644
index 000000000..d60d2bc66
--- /dev/null
+++ b/web/ce/components/pages/extra-actions.tsx
@@ -0,0 +1 @@
+export const PageDetailsHeaderExtraActions = () => null;
diff --git a/web/ce/components/pages/index.ts b/web/ce/components/pages/index.ts
new file mode 100644
index 000000000..5ce39384e
--- /dev/null
+++ b/web/ce/components/pages/index.ts
@@ -0,0 +1 @@
+export * from "./extra-actions";
diff --git a/web/ee/components/pages/extra-actions.tsx b/web/ee/components/pages/extra-actions.tsx
new file mode 100644
index 000000000..4e3c17968
--- /dev/null
+++ b/web/ee/components/pages/extra-actions.tsx
@@ -0,0 +1 @@
+export * from "ce/components/pages/extra-actions";
diff --git a/web/ee/components/pages/index.ts b/web/ee/components/pages/index.ts
new file mode 100644
index 000000000..5ce39384e
--- /dev/null
+++ b/web/ee/components/pages/index.ts
@@ -0,0 +1 @@
+export * from "./extra-actions";