binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-5654]fix: custom select selection and dropdown close #8324

Browse source
This commit is contained in:
Vamsi Krishna 2025-12-12 15:43:30 +05:30 • committed by GitHub
parent 119cf39b4d
commit 192ed9ba8d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packages/ui/src/dropdowns/custom-select.tsx
View file

@ -146,9 +146,13 @@ function Option(props: ICustomSelectItemProps) {
const { children, value, className } = props; const { children, value, className } = props;
const closeDropdown = useContext(DropdownContext); const closeDropdown = useContext(DropdownContext);
const handleMouseDown = useCallback(() => { const handleClick = useCallback(() => {
// Close dropdown for both new and already-selected options. // Close dropdown for both new and already-selected options.
requestAnimationFrame(() => closeDropdown()); // Use setTimeout to ensure HeadlessUI's onChange handler fires first for new selections.
// For already-selected options, this ensures the dropdown closes since onChange won't fire.
setTimeout(() => {
closeDropdown();
}, 0);
}, [closeDropdown]); }, [closeDropdown]);
return ( return (
@ -163,9 +167,10 @@ function Option(props: ICustomSelectItemProps) {
className className
) )
} }
onClick={handleClick}
> >
{({ selected }) => ( {({ selected }) => (
<div onMouseDown={handleMouseDown} className="flex items-center justify-between gap-2 w-full"> <div className="flex items-center justify-between gap-2 w-full">
{children} {children}
{selected && <Check className="h-3.5 w-3.5 flex-shrink-0" />} {selected && <Check className="h-3.5 w-3.5 flex-shrink-0" />}
</div> </div>