binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-5001]fix: prop name for sub work permissions #7854

Browse source
This commit is contained in:
Vamsi Krishna 2025-09-25 17:51:13 +05:30 • committed by GitHub
parent 7f28cbebcf
commit 19e00b0d4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx
View file

@ -122,7 +122,7 @@ export const SubIssuesCollapsibleContent: FC<Props> = observer((props) => {
parentIssueId={parentIssueId} parentIssueId={parentIssueId}
rootIssueId={parentIssueId} rootIssueId={parentIssueId}
spacingLeft={6} spacingLeft={6}
disabled={!disabled} canEdit={!disabled}
handleIssueCrudState={handleIssueCrudState} handleIssueCrudState={handleIssueCrudState}
subIssueOperations={subIssueOperations} subIssueOperations={subIssueOperations}
issueServiceType={issueServiceType} issueServiceType={issueServiceType}

6
apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-group.tsx
View file

@ -13,7 +13,7 @@ interface TSubIssuesListGroupProps {
workspaceSlug: string; workspaceSlug: string;
group: IGroupByColumn; group: IGroupByColumn;
serviceType: TIssueServiceType; serviceType: TIssueServiceType;
disabled: boolean; canEdit: boolean;
parentIssueId: string; parentIssueId: string;
rootIssueId: string; rootIssueId: string;
handleIssueCrudState: ( handleIssueCrudState: (
@ -30,7 +30,7 @@ export const SubIssuesListGroup: FC<TSubIssuesListGroupProps> = observer((props)
const { const {
group, group,
serviceType, serviceType,
disabled, canEdit,
parentIssueId, parentIssueId,
rootIssueId, rootIssueId,
projectId, projectId,
@ -81,7 +81,7 @@ export const SubIssuesListGroup: FC<TSubIssuesListGroupProps> = observer((props)
parentIssueId={parentIssueId} parentIssueId={parentIssueId}
rootIssueId={rootIssueId} rootIssueId={rootIssueId}
issueId={workItemId} issueId={workItemId}
disabled={disabled} canEdit={canEdit}
handleIssueCrudState={handleIssueCrudState} handleIssueCrudState={handleIssueCrudState}
subIssueOperations={subIssueOperations} subIssueOperations={subIssueOperations}
issueServiceType={serviceType} issueServiceType={serviceType}

14
apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx
View file

@ -28,7 +28,7 @@ type Props = {
parentIssueId: string; parentIssueId: string;
rootIssueId: string; rootIssueId: string;
spacingLeft: number; spacingLeft: number;
disabled: boolean; canEdit: boolean;
handleIssueCrudState: ( handleIssueCrudState: (
key: "create" | "existing" | "update" | "delete", key: "create" | "existing" | "update" | "delete",
issueId: string, issueId: string,
@ -48,7 +48,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
rootIssueId, rootIssueId,
issueId, issueId,
spacingLeft = 10, spacingLeft = 10,
disabled, canEdit,
handleIssueCrudState, handleIssueCrudState,
subIssueOperations, subIssueOperations,
issueServiceType = EIssueServiceType.ISSUES, issueServiceType = EIssueServiceType.ISSUES,
@ -174,7 +174,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
workspaceSlug={workspaceSlug} workspaceSlug={workspaceSlug}
parentIssueId={parentIssueId} parentIssueId={parentIssueId}
issueId={issueId} issueId={issueId}
disabled={disabled} canEdit={canEdit}
updateSubIssue={subIssueOperations.updateSubIssue} updateSubIssue={subIssueOperations.updateSubIssue}
displayProperties={displayProperties} displayProperties={displayProperties}
issue={issue} issue={issue}
@ -183,7 +183,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
<div className="flex-shrink-0 text-sm"> <div className="flex-shrink-0 text-sm">
<CustomMenu placement="bottom-end" ellipsis> <CustomMenu placement="bottom-end" ellipsis>
{disabled && ( {canEdit && (
<CustomMenu.MenuItem <CustomMenu.MenuItem
onClick={(e) => { onClick={(e) => {
e.preventDefault(); e.preventDefault();
@ -212,7 +212,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
</div> </div>
</CustomMenu.MenuItem> </CustomMenu.MenuItem>
{disabled && ( {canEdit && (
<CustomMenu.MenuItem <CustomMenu.MenuItem
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
@ -230,7 +230,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
</CustomMenu.MenuItem> </CustomMenu.MenuItem>
)} )}
{disabled && ( {canEdit && (
<CustomMenu.MenuItem <CustomMenu.MenuItem
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
@ -263,7 +263,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
parentIssueId={issue.id} parentIssueId={issue.id}
rootIssueId={rootIssueId} rootIssueId={rootIssueId}
spacingLeft={spacingLeft + 22} spacingLeft={spacingLeft + 22}
disabled={disabled} canEdit={canEdit}
handleIssueCrudState={handleIssueCrudState} handleIssueCrudState={handleIssueCrudState}
subIssueOperations={subIssueOperations} subIssueOperations={subIssueOperations}
/> />

16
apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/properties.tsx
View file

@ -19,7 +19,7 @@ type Props = {
workspaceSlug: string; workspaceSlug: string;
parentIssueId: string; parentIssueId: string;
issueId: string; issueId: string;
disabled: boolean; canEdit: boolean;
updateSubIssue: ( updateSubIssue: (
workspaceSlug: string, workspaceSlug: string,
projectId: string, projectId: string,
@ -33,7 +33,7 @@ type Props = {
}; };
export const SubIssuesListItemProperties: React.FC<Props> = observer((props) => { export const SubIssuesListItemProperties: React.FC<Props> = observer((props) => {
const { workspaceSlug, parentIssueId, issueId, disabled, updateSubIssue, displayProperties, issue } = props; const { workspaceSlug, parentIssueId, issueId, canEdit, updateSubIssue, displayProperties, issue } = props;
const { t } = useTranslation(); const { t } = useTranslation();
const { getStateById } = useProjectState(); const { getStateById } = useProjectState();
@ -94,7 +94,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
{ ...issue } { ...issue }
) )
} }
disabled={!disabled} disabled={!canEdit}
buttonVariant="transparent-without-text" buttonVariant="transparent-without-text"
buttonClassName="hover:bg-transparent px-0" buttonClassName="hover:bg-transparent px-0"
iconSize="size-5" iconSize="size-5"
@ -113,7 +113,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
priority: val, priority: val,
}) })
} }
disabled={!disabled} disabled={!canEdit}
buttonVariant="border-without-text" buttonVariant="border-without-text"
buttonClassName="border" buttonClassName="border"
showTooltip showTooltip
@ -144,7 +144,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
mergeDates mergeDates
buttonVariant={issue.start_date || issue.target_date ? "border-with-text" : "border-without-text"} buttonVariant={issue.start_date || issue.target_date ? "border-with-text" : "border-without-text"}
buttonClassName={shouldHighlight ? "text-red-500" : ""} buttonClassName={shouldHighlight ? "text-red-500" : ""}
disabled={!disabled} disabled={!canEdit}
showTooltip showTooltip
customTooltipHeading="Date Range" customTooltipHeading="Date Range"
renderPlaceholder={false} renderPlaceholder={false}
@ -167,7 +167,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
icon={<CalendarClock className="h-3 w-3 flex-shrink-0" />} icon={<CalendarClock className="h-3 w-3 flex-shrink-0" />}
buttonVariant={issue.start_date ? "border-with-text" : "border-without-text"} buttonVariant={issue.start_date ? "border-with-text" : "border-without-text"}
optionsClassName="z-30" optionsClassName="z-30"
disabled={!disabled} disabled={!canEdit}
showTooltip showTooltip
/> />
</div> </div>
@ -190,7 +190,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
buttonClassName={shouldHighlight ? "text-red-500" : ""} buttonClassName={shouldHighlight ? "text-red-500" : ""}
clearIconClassName="text-custom-text-100" clearIconClassName="text-custom-text-100"
optionsClassName="z-30" optionsClassName="z-30"
disabled={!disabled} disabled={!canEdit}
showTooltip showTooltip
/> />
</div> </div>
@ -207,7 +207,7 @@ export const SubIssuesListItemProperties: React.FC<Props> = observer((props) =>
assignee_ids: val, assignee_ids: val,
}) })
} }
disabled={!disabled} disabled={!canEdit}
multiple multiple
buttonVariant={(issue?.assignee_ids || []).length > 0 ? "transparent-without-text" : "border-without-text"} buttonVariant={(issue?.assignee_ids || []).length > 0 ? "transparent-without-text" : "border-without-text"}
buttonClassName={(issue?.assignee_ids || []).length > 0 ? "hover:bg-transparent px-0" : ""} buttonClassName={(issue?.assignee_ids || []).length > 0 ? "hover:bg-transparent px-0" : ""}

6
apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx
View file

@ -24,7 +24,7 @@ type Props = {
parentIssueId: string; parentIssueId: string;
rootIssueId: string; rootIssueId: string;
spacingLeft: number; spacingLeft: number;
disabled: boolean; canEdit: boolean;
handleIssueCrudState: ( handleIssueCrudState: (
key: "create" | "existing" | "update" | "delete", key: "create" | "existing" | "update" | "delete",
issueId: string, issueId: string,
@ -41,7 +41,7 @@ export const SubIssuesListRoot: React.FC<Props> = observer((props) => {
projectId, projectId,
parentIssueId, parentIssueId,
rootIssueId, rootIssueId,
disabled, canEdit,
handleIssueCrudState, handleIssueCrudState,
subIssueOperations, subIssueOperations,
issueServiceType = EIssueServiceType.ISSUES, issueServiceType = EIssueServiceType.ISSUES,
@ -116,7 +116,7 @@ export const SubIssuesListRoot: React.FC<Props> = observer((props) => {
workspaceSlug={workspaceSlug} workspaceSlug={workspaceSlug}
group={group} group={group}
serviceType={issueServiceType} serviceType={issueServiceType}
disabled={disabled} canEdit={canEdit}
parentIssueId={parentIssueId} parentIssueId={parentIssueId}
rootIssueId={rootIssueId} rootIssueId={rootIssueId}
handleIssueCrudState={handleIssueCrudState} handleIssueCrudState={handleIssueCrudState}