improvement: command palette search results (#6761)

packages/constants/src/workspace.ts

@@ -1,4 +1,4 @@
-import { TStaticViewTypes } from "@plane/types";
+import { TStaticViewTypes, IWorkspaceSearchResults } from "@plane/types";
 import { EUserWorkspaceRoles } from "./user";
 
 export const ORGANIZATION_SIZE = [
@@ -324,3 +324,15 @@ export const WORKSPACE_SIDEBAR_STATIC_NAVIGATION_ITEMS_LINKS: IWorkspaceSidebarN
   WORKSPACE_SIDEBAR_STATIC_NAVIGATION_ITEMS["inbox"],
   WORKSPACE_SIDEBAR_STATIC_NAVIGATION_ITEMS["projects"],
 ];
+
+export const WORKSPACE_DEFAULT_SEARCH_RESULT: IWorkspaceSearchResults = {
+  results: {
+    workspace: [],
+    project: [],
+    issue: [],
+    cycle: [],
+    module: [],
+    issue_view: [],
+    page: [],
+  },
+};

web/ce/components/command-palette/helpers.tsx

@@ -16,14 +16,16 @@ import { generateWorkItemLink } from "@/helpers/issue.helper";
 // plane web components
 import { IssueIdentifier } from "@/plane-web/components/issues";
 
-export const commandGroups: {
+export type TCommandGroups = {
   [key: string]: {
     icon: JSX.Element | null;
     itemName: (item: any) => React.ReactNode;
     path: (item: any, projectId: string | undefined) => string;
     title: string;
   };
-} = {
+};
+
+export const commandGroups: TCommandGroups = {
   cycle: {
     icon: <ContrastIcon className="h-3 w-3" />,
     itemName: (cycle: IWorkspaceDefaultSearchResult) => (

web/ce/components/command-palette/index.ts

@@ -0,0 +1,3 @@
+export * from "./actions";
+export * from "./modals";
+export * from "./helpers";

web/core/components/command-palette/actions/search-results.tsx

@@ -2,12 +2,12 @@
 
 import { Command } from "cmdk";
 import { useParams } from "next/navigation";
-// types
+// plane imports
 import { IWorkspaceSearchResults } from "@plane/types";
-// helpers
-import { commandGroups } from "@/components/command-palette";
 // hooks
 import { useAppRouter } from "@/hooks/use-app-router";
+// plane web imports
+import { commandGroups } from "@/plane-web/components/command-palette";
 
 type Props = {
   closePalette: () => void;
@@ -25,9 +25,9 @@ export const CommandPaletteSearchResults: React.FC<Props> = (props) => {
   return (
     <>
       {Object.keys(results.results).map((key) => {
+        // TODO: add type for results
         const section = (results.results as any)[key];
         const currentSection = commandGroups[key];
-
         if (!currentSection) return null;
         if (section.length > 0) {
           return (

web/core/components/command-palette/command-modal.tsx

@@ -8,7 +8,7 @@ import useSWR from "swr";
 import { CommandIcon, FolderPlus, Search, Settings, X } from "lucide-react";
 import { Dialog, Transition } from "@headlessui/react";
 // plane imports
-import { EUserPermissions, EUserPermissionsLevel } from "@plane/constants";
+import { EUserPermissions, EUserPermissionsLevel, WORKSPACE_DEFAULT_SEARCH_RESULT } from "@plane/constants";
 import { useTranslation } from "@plane/i18n";
 import { IWorkspaceSearchResults } from "@plane/types";
 import { LayersIcon, Loader, ToggleSwitch } from "@plane/ui";
@@ -58,9 +58,7 @@ export const CommandModal: React.FC = observer(() => {
   const [isLoading, setIsLoading] = useState(false);
   const [isSearching, setIsSearching] = useState(false);
   const [searchTerm, setSearchTerm] = useState("");
-  const [results, setResults] = useState<IWorkspaceSearchResults>({
+  const [results, setResults] = useState<IWorkspaceSearchResults>(WORKSPACE_DEFAULT_SEARCH_RESULT);
-    results: { workspace: [], project: [], issue: [], cycle: [], module: [], issue_view: [], page: [] },
-  });
   const [isWorkspaceLevel, setIsWorkspaceLevel] = useState(false);
   const [pages, setPages] = useState<string[]>([]);
   const [searchInIssue, setSearchInIssue] = useState(false);
@@ -151,9 +149,7 @@ export const CommandModal: React.FC = observer(() => {
             setIsSearching(false);
           });
       } else {
-        setResults({
+        setResults(WORKSPACE_DEFAULT_SEARCH_RESULT);
-          results: { workspace: [], project: [], issue: [], cycle: [], module: [], issue_view: [], page: [] },
-        });
         setIsLoading(false);
         setIsSearching(false);
       }

web/core/components/command-palette/index.ts

@@ -2,4 +2,3 @@ export * from "./actions";
 export * from "./shortcuts-modal";
 export * from "./command-modal";
 export * from "./command-palette";
-export * from "./helpers";