binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: code refactor and build fix (#6285)

Browse source 
* chore: code refactor and build fix

* chore: code refactor

* chore: code refactor
This commit is contained in:
Anmol Singh Bhatia 2024-12-27 18:18:45 +05:30 • committed by GitHub
parent 3c6bbaef3c
commit 211d5e1cd0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
33 changed files with 292 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

1
web/core/store/issue/helpers/base-issues.store.ts
View file

@ -672,6 +672,7 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
const issueBeforeRemoval = clone(this.rootIssueStore.issues.getIssueById(issueId));
// update parent stats optimistically
this.updateParentStats(issueBeforeRemoval, undefined);
// Male API call
await this.issueService.deleteIssue(workspaceSlug, projectId, issueId);
// Remove from Respective issue Id list

6
web/core/store/issue/issue-details/issue.store.ts
View file

@ -49,6 +49,7 @@ export class IssueStore implements IIssueStore {
// services
serviceType;
issueService;
epicService;
issueArchiveService;
issueDraftService;
@ -62,6 +63,7 @@ export class IssueStore implements IIssueStore {
// services
this.serviceType = serviceType;
this.issueService = new IssueService(serviceType);
this.epicService = new IssueService(EIssueServiceType.EPICS);
this.issueArchiveService = new IssueArchiveService(serviceType);
this.issueDraftService = new IssueDraftService();
}
@ -93,7 +95,9 @@ export class IssueStore implements IIssueStore {
let issue: TIssue | undefined;
// fetch issue from local db
issue = await persistence.getIssue(issueId);
if (this.serviceType === EIssueServiceType.ISSUES) {
issue = await persistence.getIssue(issueId);
}
this.fetchingIssueDetails = issueId;

16
web/core/store/issue/issue-details/sub_issues.store.ts
View file

@ -4,6 +4,7 @@ import set from "lodash/set";
import uniq from "lodash/uniq";
import update from "lodash/update";
import { action, makeObservable, observable, runInAction } from "mobx";
import { EIssueServiceType } from "@plane/constants";
// types
import {
TIssue,
@ -64,6 +65,7 @@ export class IssueSubIssuesStore implements IIssueSubIssuesStore {
// root store
rootIssueDetailStore: IIssueDetail;
// services
serviceType;
issueService;
constructor(rootStore: IIssueDetail, serviceType: TIssueServiceType) {
@ -84,6 +86,7 @@ export class IssueSubIssuesStore implements IIssueSubIssuesStore {
// root store
this.rootIssueDetailStore = rootStore;
// services
this.serviceType = serviceType;
this.issueService = new IssueService(serviceType);
}
@ -182,7 +185,10 @@ export class IssueSubIssuesStore implements IIssueSubIssuesStore {
[parentIssueId, "sub_issues_count"],
this.subIssues[parentIssueId].length
);
updatePersistentLayer([parentIssueId, ...issueIds]);
if (this.serviceType === EIssueServiceType.ISSUES) {
updatePersistentLayer([parentIssueId, ...issueIds]);
}
return;
};
@ -280,7 +286,9 @@ export class IssueSubIssuesStore implements IIssueSubIssuesStore {
);
});
updatePersistentLayer([parentIssueId]);
if (this.serviceType === EIssueServiceType.ISSUES) {
updatePersistentLayer([parentIssueId]);
}
return;
};
@ -315,7 +323,9 @@ export class IssueSubIssuesStore implements IIssueSubIssuesStore {
);
});
updatePersistentLayer([parentIssueId]);
if (this.serviceType === EIssueServiceType.ISSUES) {
updatePersistentLayer([parentIssueId]);
}
return;
};