From 2746bad86ba95c9a5055269787bec9b4ca9bfd6b Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Thu, 24 Jul 2025 14:46:55 +0530 Subject: [PATCH] [WEB-4561] fix: SVG attributes in react components (#7470) * chore: svg attribute fix (#7446) * fix: replace invalid --env-file with dotenv-cli for tsup onSuccess * fix: replace invalid --env-file usage in start script and move dotenv-cli to dependencies * chor: update SVG attributes to camelCase for JSX compatibility * chor: update SVG attributes to camelCase * fix: removed dontenv-cli * fix: svg attibute fixes * chore: minor attribute customizations --------- Co-authored-by: Donal Noye <68372408+Donal-Noye@users.noreply.github.com> --- packages/ui/src/form-fields/checkbox.tsx | 2 +- .../ui/src/form-fields/input-color-picker.tsx | 14 +++++++------- packages/ui/src/icons/activity-icon.tsx | 18 +++++++++++++----- packages/ui/src/icons/ai-icon.tsx | 2 +- packages/ui/src/icons/at-risk-icon.tsx | 6 +++--- packages/ui/src/icons/center-panel-icon.tsx | 12 ++++++------ .../src/icons/cycle/circle-dot-full-icon.tsx | 4 ++-- packages/ui/src/icons/discord-icon.tsx | 2 +- packages/ui/src/icons/done-icon.tsx | 6 +++--- packages/ui/src/icons/favorite-folder-icon.tsx | 14 ++++++-------- packages/ui/src/icons/in-progress-icon.tsx | 4 ++-- packages/ui/src/icons/info-icon.tsx | 6 +++--- packages/ui/src/icons/lead-icon.tsx | 6 +++--- packages/ui/src/icons/multiple-sticky.tsx | 8 ++++---- packages/ui/src/icons/off-track-icon.tsx | 6 +++--- packages/ui/src/icons/on-track-icon.tsx | 18 +++++++++--------- packages/ui/src/icons/pending-icon.tsx | 8 ++++---- packages/ui/src/icons/plane-icon.tsx | 2 +- packages/ui/src/icons/planned-icon.tsx | 14 +++++++------- packages/ui/src/icons/sticky-note-icon.tsx | 4 ++-- packages/ui/src/icons/updates-icon.tsx | 4 ++-- packages/ui/src/icons/wiki-icon.tsx | 2 +- 22 files changed, 84 insertions(+), 78 deletions(-) diff --git a/packages/ui/src/form-fields/checkbox.tsx b/packages/ui/src/form-fields/checkbox.tsx index 3c45cf4f5..b2e01908d 100644 --- a/packages/ui/src/form-fields/checkbox.tsx +++ b/packages/ui/src/form-fields/checkbox.tsx @@ -78,7 +78,7 @@ const Checkbox = React.forwardRef((props, ref) strokeLinecap="round" strokeLinejoin="round" > - + ); diff --git a/packages/ui/src/form-fields/input-color-picker.tsx b/packages/ui/src/form-fields/input-color-picker.tsx index d71a15005..eb7b83977 100644 --- a/packages/ui/src/form-fields/input-color-picker.tsx +++ b/packages/ui/src/form-fields/input-color-picker.tsx @@ -1,12 +1,12 @@ -import * as React from "react"; import { Popover, Transition } from "@headlessui/react"; +import * as React from "react"; import { ColorResult, SketchPicker } from "react-color"; -// components -import { Input } from "./input"; import { usePopper } from "react-popper"; -import { Button } from "../button"; // helpers import { cn } from "../../helpers"; +// components +import { Button } from "../button"; +import { Input } from "./input"; export interface InputColorPickerProps { hasError: boolean; @@ -71,9 +71,9 @@ export const InputColorPicker: React.FC = (props) => { viewBox="0 0 24 24" fill="none" stroke="currentColor" - stroke-width="2" - stroke-linecap="round" - stroke-linejoin="round" + strokeWidth="2" + strokeLinecap="round" + strokeLinejoin="round" className="lucide lucide-palette" > diff --git a/packages/ui/src/icons/activity-icon.tsx b/packages/ui/src/icons/activity-icon.tsx index 2ac482836..14f3b1d42 100644 --- a/packages/ui/src/icons/activity-icon.tsx +++ b/packages/ui/src/icons/activity-icon.tsx @@ -3,14 +3,22 @@ import * as React from "react"; import { ISvgIcons } from "./type"; export const ActivityIcon: React.FC = ({ className = "text-current", ...rest }) => ( - - + + diff --git a/packages/ui/src/icons/ai-icon.tsx b/packages/ui/src/icons/ai-icon.tsx index 55518401a..149d9db39 100644 --- a/packages/ui/src/icons/ai-icon.tsx +++ b/packages/ui/src/icons/ai-icon.tsx @@ -11,7 +11,7 @@ export const AiIcon: React.FC = ({ width = "16", height = "16", class xmlns="http://www.w3.org/2000/svg" className={className} > - + = ({ width = "16", height = "16" }) => ( - + diff --git a/packages/ui/src/icons/center-panel-icon.tsx b/packages/ui/src/icons/center-panel-icon.tsx index de01e2e2d..4704dbf0a 100644 --- a/packages/ui/src/icons/center-panel-icon.tsx +++ b/packages/ui/src/icons/center-panel-icon.tsx @@ -14,17 +14,17 @@ export const CenterPanelIcon: React.FC = ({ className = "text-current ); diff --git a/packages/ui/src/icons/cycle/circle-dot-full-icon.tsx b/packages/ui/src/icons/cycle/circle-dot-full-icon.tsx index f8b528a61..d6cf059ef 100644 --- a/packages/ui/src/icons/cycle/circle-dot-full-icon.tsx +++ b/packages/ui/src/icons/cycle/circle-dot-full-icon.tsx @@ -4,7 +4,7 @@ import { ISvgIcons } from "../type"; export const CircleDotFullIcon: React.FC = ({ className = "text-current", ...rest }) => ( - - + + ); diff --git a/packages/ui/src/icons/discord-icon.tsx b/packages/ui/src/icons/discord-icon.tsx index 6a2e0083a..89f441045 100644 --- a/packages/ui/src/icons/discord-icon.tsx +++ b/packages/ui/src/icons/discord-icon.tsx @@ -11,7 +11,7 @@ export const DiscordIcon: React.FC = ({ width = "24", height = "24", fill="currentColor" xmlns="http://www.w3.org/2000/svg" > - + diff --git a/packages/ui/src/icons/done-icon.tsx b/packages/ui/src/icons/done-icon.tsx index f8f65aa5f..82783ea1d 100644 --- a/packages/ui/src/icons/done-icon.tsx +++ b/packages/ui/src/icons/done-icon.tsx @@ -11,10 +11,10 @@ export const DoneState: React.FC = ({ width = "10", height = "11", cl xmlns="http://www.w3.org/2000/svg" className={className} > - + diff --git a/packages/ui/src/icons/favorite-folder-icon.tsx b/packages/ui/src/icons/favorite-folder-icon.tsx index 03ebba71b..2f464e815 100644 --- a/packages/ui/src/icons/favorite-folder-icon.tsx +++ b/packages/ui/src/icons/favorite-folder-icon.tsx @@ -15,17 +15,15 @@ export const FavoriteFolderIcon: React.FC = ({ className = "text-curr > diff --git a/packages/ui/src/icons/in-progress-icon.tsx b/packages/ui/src/icons/in-progress-icon.tsx index 085f9d74d..f85b7b26e 100644 --- a/packages/ui/src/icons/in-progress-icon.tsx +++ b/packages/ui/src/icons/in-progress-icon.tsx @@ -11,7 +11,7 @@ export const InProgressState: React.FC = ({ width = "10", height = "1 xmlns="http://www.w3.org/2000/svg" className={className} > - - + + ); diff --git a/packages/ui/src/icons/info-icon.tsx b/packages/ui/src/icons/info-icon.tsx index 5dbc7f756..b71337539 100644 --- a/packages/ui/src/icons/info-icon.tsx +++ b/packages/ui/src/icons/info-icon.tsx @@ -8,9 +8,9 @@ export const InfoIcon: React.FC = ({ className = "text-current", ...r className={`${className} stroke-2`} stroke="currentColor" fill="none" - stroke-width="2" - stroke-linecap="round" - stroke-linejoin="round" + strokeWidth="2" + strokeLinecap="round" + strokeLinejoin="round" xmlns="http://www.w3.org/2000/svg" {...rest} > diff --git a/packages/ui/src/icons/lead-icon.tsx b/packages/ui/src/icons/lead-icon.tsx index 75575d35e..5bb9d4b81 100644 --- a/packages/ui/src/icons/lead-icon.tsx +++ b/packages/ui/src/icons/lead-icon.tsx @@ -8,11 +8,11 @@ export const LeadIcon: React.FC = ({ className = "text-current", ...r d="M0.571533 9C0.571533 4.02944 4.60097 0 9.57153 0C14.5421 0 18.5715 4.02944 18.5715 9C18.5715 13.9706 14.5421 18 9.57153 18C4.60097 18 0.571533 13.9706 0.571533 9Z" fill="#3372FF" /> - + diff --git a/packages/ui/src/icons/multiple-sticky.tsx b/packages/ui/src/icons/multiple-sticky.tsx index 9c33205e9..60f2eaf9b 100644 --- a/packages/ui/src/icons/multiple-sticky.tsx +++ b/packages/ui/src/icons/multiple-sticky.tsx @@ -13,14 +13,14 @@ export const RecentStickyIcon: React.FC = ({ className = "text-curren {...rest} > diff --git a/packages/ui/src/icons/off-track-icon.tsx b/packages/ui/src/icons/off-track-icon.tsx index cbb8ba1f8..1069d36f9 100644 --- a/packages/ui/src/icons/off-track-icon.tsx +++ b/packages/ui/src/icons/off-track-icon.tsx @@ -4,10 +4,10 @@ import { ISvgIcons } from "./type"; export const OffTrackIcon: React.FC = ({ width = "16", height = "16" }) => ( - + diff --git a/packages/ui/src/icons/on-track-icon.tsx b/packages/ui/src/icons/on-track-icon.tsx index 5dcabcec9..55abe8b34 100644 --- a/packages/ui/src/icons/on-track-icon.tsx +++ b/packages/ui/src/icons/on-track-icon.tsx @@ -4,28 +4,28 @@ import { ISvgIcons } from "./type"; export const OnTrackIcon: React.FC = ({ width = "16", height = "16" }) => ( - + diff --git a/packages/ui/src/icons/pending-icon.tsx b/packages/ui/src/icons/pending-icon.tsx index 5269a22e2..217edaf83 100644 --- a/packages/ui/src/icons/pending-icon.tsx +++ b/packages/ui/src/icons/pending-icon.tsx @@ -12,14 +12,14 @@ export const PendingState: React.FC = ({ width = "10", height = "11", className={className} > diff --git a/packages/ui/src/icons/plane-icon.tsx b/packages/ui/src/icons/plane-icon.tsx index f56e8e03e..113d2dfd0 100644 --- a/packages/ui/src/icons/plane-icon.tsx +++ b/packages/ui/src/icons/plane-icon.tsx @@ -16,7 +16,7 @@ export const PlaneNewIcon: React.FC = ({ xmlns="http://www.w3.org/2000/svg" className={className} > - + = ({ width = "10", height = "11", xmlns="http://www.w3.org/2000/svg" className={className} > - + diff --git a/packages/ui/src/icons/sticky-note-icon.tsx b/packages/ui/src/icons/sticky-note-icon.tsx index 871950289..fd1652dad 100644 --- a/packages/ui/src/icons/sticky-note-icon.tsx +++ b/packages/ui/src/icons/sticky-note-icon.tsx @@ -23,8 +23,8 @@ export const StickyNoteIcon: React.FC = ({ width = "17", height = "17 fill="currentColor" /> diff --git a/packages/ui/src/icons/updates-icon.tsx b/packages/ui/src/icons/updates-icon.tsx index 978eb5f05..1b480f618 100644 --- a/packages/ui/src/icons/updates-icon.tsx +++ b/packages/ui/src/icons/updates-icon.tsx @@ -5,8 +5,8 @@ import { ISvgIcons } from "./type"; export const UpdatesIcon: React.FC = ({ className = "text-current", ...rest }) => ( diff --git a/packages/ui/src/icons/wiki-icon.tsx b/packages/ui/src/icons/wiki-icon.tsx index 7ef090714..5a3b992c7 100644 --- a/packages/ui/src/icons/wiki-icon.tsx +++ b/packages/ui/src/icons/wiki-icon.tsx @@ -11,7 +11,7 @@ export const WikiIcon: React.FC = ({ width = "16", height = "16", cla xmlns="http://www.w3.org/2000/svg" className={className} > - +