binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-3436] fix: work item delete permission and header translation (#6654)

Browse source 
* fix: work item header translation

* fix: work item delete permission
This commit is contained in:
Anmol Singh Bhatia 2025-02-20 18:32:22 +05:30 • committed by GitHub
parent f1acd46e15
commit 2d6c26a5d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
web/app/[workspaceSlug]/(projects)/browse/[workItem]/header.tsx
View file

@ -17,9 +17,8 @@ export const ProjectIssueDetailsHeader = observer(() => {
// router
const router = useAppRouter();
const { workspaceSlug, workItem } = useParams();
// plane hooks
const { t } = useTranslation();
// store hooks
const { t } = useTranslation();
const { getProjectById, loader } = useProject();
const {
issue: { getIssueById, getIssueIdByIdentifier },

18
web/core/components/issues/delete-issue-modal.tsx
View file

@ -1,6 +1,8 @@
"use client";
import { useEffect, useState } from "react";
import { observer } from "mobx-react";
import { useParams } from "next/navigation";
// types
import { PROJECT_ERROR_MESSAGES, EUserPermissions, EUserPermissionsLevel } from "@plane/constants";
import { useTranslation } from "@plane/i18n";
@ -22,11 +24,12 @@ type Props = {
isEpic?: boolean;
};
export const DeleteIssueModal: React.FC<Props> = (props) => {
export const DeleteIssueModal: React.FC<Props> = observer((props) => {
const { dataId, data, isOpen, handleClose, isSubIssue = false, onSubmit, isEpic = false } = props;
// states
const [isDeleting, setIsDeleting] = useState(false);
// store hooks
const { workspaceSlug } = useParams();
const { issueMap } = useIssues();
const { getProjectById } = useProject();
const { allowPermissions } = useUserPermissions();
@ -34,9 +37,6 @@ export const DeleteIssueModal: React.FC<Props> = (props) => {
const { data: currentUser } = useUser();
// derived values
const canPerformProjectAdminActions = allowPermissions([EUserPermissions.ADMIN], EUserPermissionsLevel.PROJECT);
useEffect(() => {
setIsDeleting(false);
}, [isOpen]);
@ -47,6 +47,14 @@ export const DeleteIssueModal: React.FC<Props> = (props) => {
const issue = data ? data : issueMap[dataId!];
const projectDetails = getProjectById(issue?.project_id);
const isIssueCreator = issue?.created_by === currentUser?.id;
const canPerformProjectAdminActions = allowPermissions(
[EUserPermissions.ADMIN],
EUserPermissionsLevel.PROJECT,
workspaceSlug?.toString(),
projectDetails?.id
);
const authorized = isIssueCreator || canPerformProjectAdminActions;
const onClose = () => {
@ -114,4 +122,4 @@ export const DeleteIssueModal: React.FC<Props> = (props) => {
}
/>
);
};
});