binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: add missing headings to the rich text editor (#5135)

Browse source
This commit is contained in:
Aaryan Khandelwal 2024-07-22 15:17:24 +05:30 • committed by GitHub
parent 8771c80c9b
commit 2ee6cd20d8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 227 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web/core/components/editor/lite-text-editor/toolbar.tsx
View file

@ -3,7 +3,7 @@
import React, { useEffect, useState, useCallback } from "react";
import { Globe2, Lock, LucideIcon } from "lucide-react";
// editor
import { EditorMenuItemNames, EditorRefApi } from "@plane/editor";
import { EditorRefApi, TEditorCommands } from "@plane/editor";
// ui
import { Button, Tooltip } from "@plane/ui";
// constants
@ -14,7 +14,7 @@ import { cn } from "@/helpers/common.helper";
type Props = {
accessSpecifier?: EIssueCommentAccessSpecifier;
executeCommand: (commandName: EditorMenuItemNames) => void;
executeCommand: (commandKey: TEditorCommands) => void;
handleAccessChange?: (accessKey: EIssueCommentAccessSpecifier) => void;
handleSubmit: (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => void;
isCommentEmpty: boolean;

4
web/core/components/pages/editor/header/toolbar.tsx
View file

@ -3,7 +3,7 @@
import React, { useEffect, useState, useCallback } from "react";
import { Check, ChevronDown } from "lucide-react";
// editor
import { EditorMenuItemNames, EditorRefApi } from "@plane/editor";
import { EditorRefApi, TEditorCommands } from "@plane/editor";
// ui
import { CustomMenu, Tooltip } from "@plane/ui";
// constants
@ -18,7 +18,7 @@ type Props = {
type ToolbarButtonProps = {
item: ToolbarMenuItem;
isActive: boolean;
executeCommand: (commandName: EditorMenuItemNames) => void;
executeCommand: (commandKey: TEditorCommands) => void;
};
const ToolbarButton: React.FC<ToolbarButtonProps> = React.memo((props) => {

4
web/core/constants/editor.ts
View file

@ -20,12 +20,12 @@ import {
Underline,
} from "lucide-react";
// editor
import { EditorMenuItemNames } from "@plane/editor";
import { TEditorCommands } from "@plane/editor";
type TEditorTypes = "lite" | "document";
export type ToolbarMenuItem = {
key: EditorMenuItemNames;
key: TEditorCommands;
name: string;
icon: LucideIcon;
shortcut?: string[];