From 3279bb6ac95267af34a686151c5f55238c957aa2 Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Date: Tue, 6 Aug 2024 18:21:53 +0530
Subject: [PATCH] [WEB-2182] fix: favorite item alignment and redirection
 (#5316)

* fix: favorite item alignment

* fix: favorite item redirection

* chore: code refactor
---
 .../sidebar/favorites/favorite-item.tsx       | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/web/core/components/workspace/sidebar/favorites/favorite-item.tsx b/web/core/components/workspace/sidebar/favorites/favorite-item.tsx
index 4ef38c8c2..79cd8dc56 100644
--- a/web/core/components/workspace/sidebar/favorites/favorite-item.tsx
+++ b/web/core/components/workspace/sidebar/favorites/favorite-item.tsx
@@ -135,7 +135,11 @@ export const FavoriteItem = observer(
           key={favorite.id}
           className={`${sidebarCollapsed ? "p-0 size-8 aspect-square justify-center mx-auto" : ""}`}
         >
-          <div className="flex flex-between items-center gap-1.5 py-[1px] w-full">
+          <div
+            className={cn("flex justify-between items-center gap-1.5 py-[1px]", {
+              "w-full": !sidebarCollapsed,
+            })}
+          >
             <Tooltip
               isMobile={isMobile}
               tooltipContent={favorite.sort_order === null ? "Join the project to rearrange" : "Drag to rearrange"}
@@ -158,13 +162,14 @@ export const FavoriteItem = observer(
               </button>
             </Tooltip>
 
-            {getIcon()}
-
-            {!sidebarCollapsed && (
-              <Link href={getLink()} className="text-sm leading-5 font-medium flex-1 truncate">
-                {favorite.entity_data ? favorite.entity_data.name : favorite.name}
-              </Link>
-            )}
+            <Link href={getLink()} className="flex items-center gap-1.5 truncate">
+              {getIcon()}
+              {!sidebarCollapsed && (
+                <span className="text-sm leading-5 font-medium flex-1 truncate">
+                  {favorite.entity_data ? favorite.entity_data.name : favorite.name}
+                </span>
+              )}
+            </Link>
 
             {!sidebarCollapsed && (
               <CustomMenu