binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[GIT-66] improvement: prevent disabling last enabled authentication method (#8570)

Browse source
This commit is contained in:
Prateek Shourya 2026-01-27 00:47:37 +05:30 • committed by GitHub
parent f7d5200ed8
commit 32a2584578
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 167 additions and 127 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/types/src/instance/auth.ts
View file

@ -1,5 +1,3 @@
import type { TExtendedInstanceAuthenticationModeKeys } from "./auth-ee";
export type TCoreInstanceAuthenticationModeKeys =
| "unique-codes"
| "passwords-login"
@ -8,9 +6,7 @@ export type TCoreInstanceAuthenticationModeKeys =
| "gitlab"
| "gitea";
export type TInstanceAuthenticationModeKeys =
| TCoreInstanceAuthenticationModeKeys
| TExtendedInstanceAuthenticationModeKeys;
export type TInstanceAuthenticationModeKeys = TCoreInstanceAuthenticationModeKeys;
export type TInstanceAuthenticationModes = {
key: TInstanceAuthenticationModeKeys;
@ -18,6 +14,7 @@ export type TInstanceAuthenticationModes = {
description: string;
icon: React.ReactNode;
config: React.ReactNode;
enabledConfigKey: TInstanceAuthenticationMethodKeys;
unavailable?: boolean;
};

16
packages/ui/src/oauth/oauth-options.tsx
View file

@ -13,13 +13,13 @@ export type TOAuthOption = {
type OAuthOptionsProps = {
options: TOAuthOption[];
compact?: boolean;
showDivider?: boolean;
className?: string;
containerClassName?: string;
};
export function OAuthOptions(props: OAuthOptionsProps) {
const { options, compact = false, className = "", containerClassName = "" } = props;
const { options, compact = false, showDivider = true, className = "", containerClassName = "" } = props;
// Filter enabled options
const enabledOptions = options.filter((option) => option.enabled !== false);
@ -47,11 +47,13 @@ export function OAuthOptions(props: OAuthOptionsProps) {
))}
</div>
<div className="mt-4 flex items-center transition-all duration-300">
<hr className="w-full border-strong transition-colors duration-300" />
<p className="mx-3 flex-shrink-0 text-center text-13 text-placeholder transition-colors duration-300">or</p>
<hr className="w-full border-strong transition-colors duration-300" />
</div>
{showDivider && (
<div className="mt-4 flex items-center transition-all duration-300">
<hr className="w-full border-strong transition-colors duration-300" />
<p className="mx-3 flex-shrink-0 text-center text-13 text-placeholder transition-colors duration-300">or</p>
<hr className="w-full border-strong transition-colors duration-300" />
</div>
)}
</div>
);
}