[WEB-2178] fix: empty folder title (#5344)

* fix: empty folder title

* fix: collapsible overflow issue
This commit is contained in:
Anmol Singh Bhatia 2024-08-09 19:03:25 +05:30 committed by GitHub
parent f457048644
commit 421bf2abc7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 9 deletions

View file

@ -38,7 +38,6 @@ export const Collapsible: FC<TCollapsibleProps> = (props) => {
</Disclosure.Button>
<Transition
show={localIsOpen}
className="overflow-hidden"
enter="transition-max-height duration-400 ease-in-out"
enterFrom="max-h-0"
enterTo="max-h-screen"

View file

@ -45,10 +45,18 @@ export const NewFavoriteFolder = observer((props: TProps) => {
formData = {
entity_type: "folder",
is_folder: true,
name: formData.name,
name: formData.name.trim(),
parent: null,
project_id: null,
};
if (formData.name === "")
return setToast({
type: TOAST_TYPE.ERROR,
title: "Error!",
message: "Folder name cannot be empty",
});
addFavorite(workspaceSlug.toString(), formData)
.then(() => {
setToast({
@ -77,15 +85,31 @@ export const NewFavoriteFolder = observer((props: TProps) => {
message: "Folder already exists",
});
const payload = {
name: formData.name,
name: formData.name.trim(),
};
updateFavorite(workspaceSlug.toString(), favoriteId, payload).then(() => {
setToast({
type: TOAST_TYPE.SUCCESS,
title: "Success!",
message: "Favorite updated successfully.",
if (formData.name.trim() === "")
return setToast({
type: TOAST_TYPE.ERROR,
title: "Error!",
message: "Folder name cannot be empty",
});
updateFavorite(workspaceSlug.toString(), favoriteId, payload)
.then(() => {
setToast({
type: TOAST_TYPE.SUCCESS,
title: "Success!",
message: "Favorite updated successfully.",
});
})
.catch(() => {
setToast({
type: TOAST_TYPE.ERROR,
title: "Error!",
message: "Something went wrong!",
});
});
});
setCreateNewFolder(false);
setValue("name", "");
};