binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

enable peekoverview for spreadsheet and minor refactor for faster opening of the peekoverview component (#3361)

Browse source 
Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>
This commit is contained in:
rahulramesha 2024-01-12 13:52:04 +05:30 • committed by sriram veeraghanta
parent 9789068880
commit 4b0d48b290
4 changed files with 105 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

14
web/components/issues/issue-layouts/spreadsheet/base-spreadsheet-root.tsx
View file

@ -45,12 +45,16 @@ export const BaseSpreadsheetRoot = observer((props: IBaseSpreadsheetRoot) => {
// user role validation
const isEditingAllowed = !!currentProjectRole && currentProjectRole >= EUserProjectRoles.MEMBER;
const canEditProperties = (projectId: string | undefined) => {
const isEditingAllowedBasedOnProject =
canEditPropertiesBasedOnProject && projectId ? canEditPropertiesBasedOnProject(projectId) : isEditingAllowed;
const canEditProperties = useCallback(
(projectId: string | undefined) => {
const isEditingAllowedBasedOnProject =
canEditPropertiesBasedOnProject && projectId ? canEditPropertiesBasedOnProject(projectId) : isEditingAllowed;
return enableInlineEditing && isEditingAllowedBasedOnProject;
},
[canEditPropertiesBasedOnProject, enableInlineEditing, isEditingAllowed]
);
return enableInlineEditing && isEditingAllowedBasedOnProject;
};
const issueIds = (issueStore.groupedIssueIds ?? []) as TUnGroupedIssues;