chore: lint related changes and packaging fixes (#6163)

* fix: lint related changes and packaging fixes * adding color validations
2024-12-06 14:56:49 +05:30 · 2024-12-06 14:56:49 +05:30 · 4b5a2bc4e5
commit 4b5a2bc4e5
parent b1c340b199
71 changed files with 1025 additions and 896 deletions
--- a/web/core/components/workspace/sidebar/favorites/favorite-folder.tsx
+++ b/web/core/components/workspace/sidebar/favorites/favorite-folder.tsx
@ -2,7 +2,11 @@

 import { useEffect, useRef, useState } from "react";
 import { combine } from "@atlaskit/pragmatic-drag-and-drop/combine";
-import { DragLocationHistory, ElementDragPayload, DropTargetRecord } from "@atlaskit/pragmatic-drag-and-drop/dist/types/internal-types";
+import {
+  DragLocationHistory,
+  ElementDragPayload,
+  DropTargetRecord,
+} from "@atlaskit/pragmatic-drag-and-drop/dist/types/internal-types";
 import { draggable, dropTargetForElements } from "@atlaskit/pragmatic-drag-and-drop/element/adapter";
 import { pointerOutsideOfPreview } from "@atlaskit/pragmatic-drag-and-drop/element/pointer-outside-of-preview";
 import { setCustomNativeDragPreview } from "@atlaskit/pragmatic-drag-and-drop/element/set-custom-native-drag-preview";
@ -15,7 +19,7 @@ import { PenSquare, Star, MoreHorizontal, ChevronRight, GripVertical } from "luc
 import { Disclosure, Transition } from "@headlessui/react";

 // plane helpers
-import { useOutsideClickDetector } from "@plane/helpers";
+import { useOutsideClickDetector } from "@plane/hooks";
 // ui
 import { IFavorite, InstructionType } from "@plane/types";
 import { CustomMenu, Tooltip, DropIndicator, FavoriteFolderIcon, DragHandle } from "@plane/ui";
@ -34,7 +38,7 @@ type Props = {
  favorite: IFavorite;
  handleRemoveFromFavorites: (favorite: IFavorite) => void;
  handleRemoveFromFavoritesFolder: (favoriteId: string) => void;
-  handleDrop: (self: DropTargetRecord,source: ElementDragPayload, location: DragLocationHistory) => void;
+  handleDrop: (self: DropTargetRecord, source: ElementDragPayload, location: DragLocationHistory) => void;
 };

 export const FavoriteFolder: React.FC<Props> = (props) => {
@ -65,7 +69,7 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
        element,
        getInitialData: () => initialData,
        onDragStart: () => setIsDragging(true),
-        onGenerateDragPreview: ({ nativeSetDragImage }) =>{
+        onGenerateDragPreview: ({ nativeSetDragImage }) => {
          setCustomNativeDragPreview({
            getOffset: pointerOutsideOfPreview({ x: "0px", y: "0px" }),
            render: ({ container }) => {
@ -84,44 +88,42 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
          });
        },
        onDrop: () => {
-          setIsDragging(false)
+          setIsDragging(false);
        }, // canDrag: () => isDraggable,
      }),
      dropTargetForElements({
        element,
        canDrop: ({ source }) => getCanDrop(source, favorite, false),
-        getData: ({ input, element }) =>{
-
+        getData: ({ input, element }) => {
          const blockedStates: InstructionType[] = [];
-          if(!isLastChild){
-            blockedStates.push('reorder-below');
+          if (!isLastChild) {
+            blockedStates.push("reorder-below");
          }

-          return attachInstruction(initialData,{
+          return attachInstruction(initialData, {
            input,
            element,
            currentLevel: 0,
            indentPerLevel: 0,
-            mode: isLastChild ? 'last-in-group' : 'standard',
-            block: blockedStates
-          })
+            mode: isLastChild ? "last-in-group" : "standard",
+            block: blockedStates,
+          });
        },
-        onDrag: ({source, self, location}) => {
-          const instruction = getInstructionFromPayload(self,source, location);
+        onDrag: ({ source, self, location }) => {
+          const instruction = getInstructionFromPayload(self, source, location);
          setInstruction(instruction);
        },
        onDragLeave: () => {
          setInstruction(undefined);
        },
-        onDrop: ({ self, source, location})=>{
+        onDrop: ({ self, source, location }) => {
          setInstruction(undefined);
-          handleDrop(self, source,location);
-        }
+          handleDrop(self, source, location);
+        },
      })
    );
    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [isDragging, favorite.id ]);
-
+  }, [isDragging, favorite.id]);

  useOutsideClickDetector(actionSectionRef, () => setIsMenuActive(false));

@ -140,11 +142,11 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
            // id={`sidebar-${projectId}-${projectListType}`}
            className={cn("relative", {
              "bg-custom-sidebar-background-80 opacity-60": isDragging,
-              "border-[2px] border-custom-primary-100" : instruction === 'make-child'
+              "border-[2px] border-custom-primary-100": instruction === "make-child",
            })}
          >
            {/* draggable drop top indicator */}
-            <DropIndicator isVisible={instruction === "reorder-above"}/>
+            <DropIndicator isVisible={instruction === "reorder-above"} />
            <div
              className={cn(
                "group/project-item relative w-full px-2 py-1.5 flex items-center rounded-md text-custom-sidebar-text-100 hover:bg-custom-sidebar-background-90",
@ -283,7 +285,7 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
                    "px-2": !isSidebarCollapsed,
                  })}
                >
-                  {orderBy(favorite.children,'sequence','desc').map((child,index) => (
+                  {orderBy(favorite.children, "sequence", "desc").map((child, index) => (
                    <FavoriteRoot
                      key={child.id}
                      workspaceSlug={workspaceSlug.toString()}
@ -298,7 +300,7 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
              </Transition>
            )}
            {/* draggable drop bottom indicator */}
-            { isLastChild && <DropIndicator isVisible={instruction === "reorder-below"} />}
+            {isLastChild && <DropIndicator isVisible={instruction === "reorder-below"} />}
          </div>
        )}
      </Disclosure>
--- a/web/core/components/workspace/sidebar/favorites/favorite-items/root.tsx
+++ b/web/core/components/workspace/sidebar/favorites/favorite-items/root.tsx
@ -3,7 +3,11 @@
 import React, { FC, useEffect, useRef, useState } from "react";
 import { combine } from "@atlaskit/pragmatic-drag-and-drop/combine";
 import { DropTargetRecord, DragLocationHistory } from "@atlaskit/pragmatic-drag-and-drop/dist/types/internal-types";
-import { draggable, dropTargetForElements, ElementDragPayload } from "@atlaskit/pragmatic-drag-and-drop/element/adapter";
+import {
+  draggable,
+  dropTargetForElements,
+  ElementDragPayload,
+} from "@atlaskit/pragmatic-drag-and-drop/element/adapter";
 import { pointerOutsideOfPreview } from "@atlaskit/pragmatic-drag-and-drop/element/pointer-outside-of-preview";
 import { setCustomNativeDragPreview } from "@atlaskit/pragmatic-drag-and-drop/element/set-custom-native-drag-preview";
 import { attachInstruction } from "@atlaskit/pragmatic-drag-and-drop-hitbox/tree-item";
@ -11,7 +15,7 @@ import { attachInstruction } from "@atlaskit/pragmatic-drag-and-drop-hitbox/tree
 import { observer } from "mobx-react";
 // plane helpers
 import { createRoot } from "react-dom/client";
-import { useOutsideClickDetector } from "@plane/helpers";
+import { useOutsideClickDetector } from "@plane/hooks";
 // ui
 import { IFavorite, InstructionType } from "@plane/types";
 // components
@ -26,8 +30,7 @@ import {
 import { useAppTheme } from "@/hooks/store";
 import { useFavoriteItemDetails } from "@/hooks/use-favorite-item-details";
 //helpers
-import { getCanDrop, getInstructionFromPayload} from "../favorites.helpers";
-
+import { getCanDrop, getInstructionFromPayload } from "../favorites.helpers";

 type Props = {
  isLastChild: boolean;
@ -35,19 +38,12 @@ type Props = {
  workspaceSlug: string;
  favorite: IFavorite;
  handleRemoveFromFavorites: (favorite: IFavorite) => void;
-  handleDrop: (self: DropTargetRecord,source: ElementDragPayload, location: DragLocationHistory) => void;
+  handleDrop: (self: DropTargetRecord, source: ElementDragPayload, location: DragLocationHistory) => void;
 };

 export const FavoriteRoot: FC<Props> = observer((props) => {
  // props
-  const {
-    isLastChild,
-    parentId,
-    workspaceSlug,
-    favorite,
-    handleRemoveFromFavorites,
-    handleDrop,
-  } = props;
+  const { isLastChild, parentId, workspaceSlug, favorite, handleRemoveFromFavorites, handleDrop } = props;
  // store hooks
  const { sidebarCollapsed } = useAppTheme();
  const { itemLink, itemIcon, itemTitle } = useFavoriteItemDetails(workspaceSlug, favorite);
@ -62,7 +58,6 @@ export const FavoriteRoot: FC<Props> = observer((props) => {

  const handleQuickAction = (value: boolean) => setIsMenuActive(value);

-
  // drag and drop
  useEffect(() => {
    const element = elementRef.current;
@ -107,21 +102,20 @@ export const FavoriteRoot: FC<Props> = observer((props) => {
        onDragStart: () => {
          setIsDragging(true);
        },
-        getData: ({ input, element }) =>{
-
-          const blockedStates: InstructionType[] = ['make-child'];
-          if(!isLastChild){
-            blockedStates.push('reorder-below');
+        getData: ({ input, element }) => {
+          const blockedStates: InstructionType[] = ["make-child"];
+          if (!isLastChild) {
+            blockedStates.push("reorder-below");
          }

-          return attachInstruction(initialData,{
+          return attachInstruction(initialData, {
            input,
            element,
            currentLevel: 1,
            indentPerLevel: 0,
-            mode: isLastChild ? 'last-in-group' : 'standard',
-            block: blockedStates
-          })
+            mode: isLastChild ? "last-in-group" : "standard",
+            block: blockedStates,
+          });
        },
        onDrag: ({ self, source, location }) => {
          const instruction = getInstructionFromPayload(self, source, location);
@ -130,9 +124,9 @@ export const FavoriteRoot: FC<Props> = observer((props) => {
        onDragLeave: () => {
          setInstruction(undefined);
        },
-        onDrop: ({  self, source, location }) => {
+        onDrop: ({ self, source, location }) => {
          setInstruction(undefined);
-          handleDrop(self,source,location)
+          handleDrop(self, source, location);
        },
      })
    );
@ -143,7 +137,7 @@ export const FavoriteRoot: FC<Props> = observer((props) => {

  return (
    <>
-      <DropIndicator isVisible={instruction === "reorder-above"}/>
+      <DropIndicator isVisible={instruction === "reorder-above"} />
      <FavoriteItemWrapper elementRef={elementRef} isMenuActive={isMenuActive} sidebarCollapsed={sidebarCollapsed}>
        {!sidebarCollapsed && <FavoriteItemDragHandle isDragging={isDragging} sort_order={favorite.sort_order} />}
        <FavoriteItemTitle href={itemLink} icon={itemIcon} title={itemTitle} isSidebarCollapsed={!!sidebarCollapsed} />
@ -157,7 +151,7 @@ export const FavoriteRoot: FC<Props> = observer((props) => {
          />
        )}
      </FavoriteItemWrapper>
-      { isLastChild && <DropIndicator isVisible={instruction === "reorder-below"} />}
+      {isLastChild && <DropIndicator isVisible={instruction === "reorder-below"} />}
    </>
  );
 });
--- a/web/core/components/workspace/sidebar/favorites/new-fav-folder.tsx
+++ b/web/core/components/workspace/sidebar/favorites/new-fav-folder.tsx
@ -3,7 +3,7 @@ import { observer } from "mobx-react";
 import { useParams } from "next/navigation";
 import { Controller, SubmitHandler, useForm } from "react-hook-form";
 // plane helpers
-import { useOutsideClickDetector } from "@plane/helpers";
+import { useOutsideClickDetector } from "@plane/hooks";
 // plane ui
 import { FavoriteFolderIcon, Input, setToast, TOAST_TYPE } from "@plane/ui";
 // hooks
--- a/web/core/components/workspace/sidebar/projects-list-item.tsx
+++ b/web/core/components/workspace/sidebar/projects-list-item.tsx
@ -24,7 +24,7 @@ import {
 } from "lucide-react";
 import { Disclosure, Transition } from "@headlessui/react";
 // plane helpers
-import { useOutsideClickDetector } from "@plane/helpers";
+import { useOutsideClickDetector } from "@plane/hooks";
 // ui
 import {
  CustomMenu,
@ -298,7 +298,7 @@ export const SidebarProjectsListItem: React.FC<Props> = observer((props) => {
    <>
      <PublishProjectModal isOpen={publishModalOpen} project={project} onClose={() => setPublishModal(false)} />
      <LeaveProjectModal project={project} isOpen={leaveProjectModalOpen} onClose={() => setLeaveProjectModal(false)} />
-      <Disclosure key={`${project.id}_${URLProjectId}`}  defaultOpen={isProjectListOpen} as="div">
+      <Disclosure key={`${project.id}_${URLProjectId}`} defaultOpen={isProjectListOpen} as="div">
        <div
          id={`sidebar-${projectId}-${projectListType}`}
          className={cn("relative", {
--- a/web/core/components/workspace/sidebar/workspace-menu.tsx
+++ b/web/core/components/workspace/sidebar/workspace-menu.tsx
@ -7,7 +7,7 @@ import { useParams, usePathname } from "next/navigation";
 import { ArchiveIcon, ChevronRight, MoreHorizontal, Settings } from "lucide-react";
 import { Disclosure, Transition } from "@headlessui/react";
 // plane helpers
-import { useOutsideClickDetector } from "@plane/helpers";
+import { useOutsideClickDetector } from "@plane/hooks";
 // ui
 import { CustomMenu, Tooltip } from "@plane/ui";
 // components