binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-2597] fix: handle favorite entity data causing application error (#6853)

Browse source
This commit is contained in:
Anmol Singh Bhatia 2025-04-01 20:47:01 +05:30 • committed by GitHub
parent 2d1b3fb39e
commit 4be94adaca
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 30 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

56
web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
View file

@ -252,33 +252,37 @@ export const SidebarFavoritesMenu = observer(() => {
orderBy(Object.values(groupedFavorites), "sequence", "desc")
.filter((fav) => !fav.parent)
.map((fav, index, { length }) => (
<Tooltip
key={fav.id}
tooltipContent={fav?.entity_data ? fav.entity_data?.name : fav?.name}
position="right"
className="ml-2"
disabled={!sidebarCollapsed}
isMobile={isMobile}
>
{fav.is_folder ? (
<FavoriteFolder
favorite={fav}
isLastChild={index === length - 1}
handleRemoveFromFavorites={handleRemoveFromFavorites}
handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
handleDrop={handleDrop}
/>
) : (
<FavoriteRoot
workspaceSlug={workspaceSlug.toString()}
favorite={fav}
isLastChild={index === length - 1}
parentId={undefined}
handleRemoveFromFavorites={handleRemoveFromFavorites}
handleDrop={handleDrop}
/>
<>
{fav?.id && (
<Tooltip
key={fav?.id}
tooltipContent={fav?.entity_data ? fav?.entity_data?.name : fav?.name}
position="right"
className="ml-2"
disabled={!sidebarCollapsed}
isMobile={isMobile}
>
{fav?.is_folder ? (
<FavoriteFolder
favorite={fav}
isLastChild={index === length - 1}
handleRemoveFromFavorites={handleRemoveFromFavorites}
handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
handleDrop={handleDrop}
/>
) : (
<FavoriteRoot
workspaceSlug={workspaceSlug.toString()}
favorite={fav}
isLastChild={index === length - 1}
parentId={undefined}
handleRemoveFromFavorites={handleRemoveFromFavorites}
handleDrop={handleDrop}
/>
)}
</Tooltip>
)}
</Tooltip>
</>
))
)}
</Disclosure.Panel>