fix: bug fixes (#2581)

* fix: module sidebar fix for kanban layout

* chore: cycle & module sidebar improvement

* chore: join project content updated

* chore: project empty state header fix

* chore: create project modal dropdown consistency

* chore: list view group header overlapping issue fix

* chore: popover code refactor

* chore: module sidebar fix for cycle kanban view

* chore: add existing issue option added in module empty state

* chore: add existing issue option added in cycle empty state
This commit is contained in:
Anmol Singh Bhatia 2023-11-01 17:11:07 +05:30 committed by GitHub
parent 13ead7c314
commit 548e95c7e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 229 additions and 157 deletions

View file

@ -3,8 +3,12 @@ import { useRouter } from "next/router";
import useSWR from "swr";
// mobx store
import { useMobxStore } from "lib/mobx/store-provider";
// services
import { IssueService } from "services/issue";
// hooks
import useLocalStorage from "hooks/use-local-storage";
import useUser from "hooks/use-user";
import useToast from "hooks/use-toast";
// layouts
import { AppLayout } from "layouts/app-layout";
// components
@ -16,6 +20,10 @@ import { CycleLayoutRoot } from "components/issues/issue-layouts";
import { EmptyState } from "components/common";
// assets
import emptyCycle from "public/empty-state/cycle.svg";
// types
import { ISearchIssueResponse } from "types";
const issueService = new IssueService();
const SingleCycle: React.FC = () => {
const [cycleIssuesListModal, setCycleIssuesListModal] = useState(false);
@ -25,6 +33,10 @@ const SingleCycle: React.FC = () => {
const { cycle: cycleStore } = useMobxStore();
const { user } = useUser();
const { setToastAlert } = useToast();
const { setValue, storedValue } = useLocalStorage("cycle_sidebar_collapsed", "false");
const isSidebarCollapsed = storedValue ? (storedValue === "true" ? true : false) : false;
@ -40,23 +52,27 @@ const SingleCycle: React.FC = () => {
};
// TODO: add this function to bulk add issues to cycle
// const handleAddIssuesToCycle = async (data: ISearchIssueResponse[]) => {
// if (!workspaceSlug || !projectId) return;
const handleAddIssuesToCycle = async (data: ISearchIssueResponse[]) => {
if (!workspaceSlug || !projectId) return;
// const payload = {
// issues: data.map((i) => i.id),
// };
const payload = {
issues: data.map((i) => i.id),
};
// await issueService
// .addIssueToCycle(workspaceSlug as string, projectId as string, cycleId as string, payload, user)
// .catch(() => {
// setToastAlert({
// type: "error",
// title: "Error!",
// message: "Selected issues could not be added to the cycle. Please try again.",
// });
// });
// };
await issueService
.addIssueToCycle(workspaceSlug as string, projectId as string, cycleId as string, payload, user)
.catch(() => {
setToastAlert({
type: "error",
title: "Error!",
message: "Selected issues could not be added to the cycle. Please try again.",
});
});
};
const openIssuesListModal = () => {
setCycleIssuesListModal(true);
};
return (
<AppLayout header={<CycleIssuesHeader />} withProjectWrapper>
@ -65,7 +81,7 @@ const SingleCycle: React.FC = () => {
isOpen={cycleIssuesListModal}
handleClose={() => setCycleIssuesListModal(false)}
searchParams={{ cycle: true }}
handleOnSubmit={async () => {}}
handleOnSubmit={handleAddIssuesToCycle}
/>
{error ? (
<EmptyState
@ -80,8 +96,8 @@ const SingleCycle: React.FC = () => {
) : (
<>
<div className="flex h-full w-full">
<div className="h-full w-full">
<CycleLayoutRoot />
<div className="h-full w-full overflow-hidden">
<CycleLayoutRoot openIssuesListModal={openIssuesListModal} />
</div>
{cycleId && !isSidebarCollapsed && (
<div

View file

@ -3,8 +3,13 @@ import { useRouter } from "next/router";
import useSWR from "swr";
// mobx store
import { useMobxStore } from "lib/mobx/store-provider";
// services
import { ModuleService } from "services/module.service";
// hooks
import useLocalStorage from "hooks/use-local-storage";
import useToast from "hooks/use-toast";
import useUser from "hooks/use-user";
// layouts
import { AppLayout } from "layouts/app-layout";
// components
@ -18,6 +23,9 @@ import { EmptyState } from "components/common";
import emptyModule from "public/empty-state/module.svg";
// types
import { NextPage } from "next";
import { ISearchIssueResponse } from "types";
const moduleService = new ModuleService();
const ModuleIssuesPage: NextPage = () => {
const [moduleIssuesListModal, setModuleIssuesListModal] = useState(false);
@ -27,6 +35,10 @@ const ModuleIssuesPage: NextPage = () => {
const { module: moduleStore } = useMobxStore();
const { user } = useUser();
const { setToastAlert } = useToast();
const { setValue, storedValue } = useLocalStorage("module_sidebar_collapsed", "false");
const isSidebarCollapsed = storedValue ? (storedValue === "true" ? true : false) : false;
@ -38,27 +50,27 @@ const ModuleIssuesPage: NextPage = () => {
);
// TODO: add this function to bulk add issues to cycle
// const handleAddIssuesToModule = async (data: ISearchIssueResponse[]) => {
// if (!workspaceSlug || !projectId) return;
const handleAddIssuesToModule = async (data: ISearchIssueResponse[]) => {
if (!workspaceSlug || !projectId) return;
// const payload = {
// issues: data.map((i) => i.id),
// };
const payload = {
issues: data.map((i) => i.id),
};
// await moduleService
// .addIssuesToModule(workspaceSlug as string, projectId as string, moduleId as string, payload, user)
// .catch(() =>
// setToastAlert({
// type: "error",
// title: "Error!",
// message: "Selected issues could not be added to the module. Please try again.",
// })
// );
// };
await moduleService
.addIssuesToModule(workspaceSlug as string, projectId as string, moduleId as string, payload, user)
.catch(() =>
setToastAlert({
type: "error",
title: "Error!",
message: "Selected issues could not be added to the module. Please try again.",
})
);
};
// const openIssuesListModal = () => {
// setModuleIssuesListModal(true);
// };
const openIssuesListModal = () => {
setModuleIssuesListModal(true);
};
const toggleSidebar = () => {
setValue(`${!isSidebarCollapsed}`);
@ -72,7 +84,7 @@ const ModuleIssuesPage: NextPage = () => {
isOpen={moduleIssuesListModal}
handleClose={() => setModuleIssuesListModal(false)}
searchParams={{ module: true }}
handleOnSubmit={async () => {}}
handleOnSubmit={handleAddIssuesToModule}
/>
{error ? (
<EmptyState
@ -86,8 +98,8 @@ const ModuleIssuesPage: NextPage = () => {
/>
) : (
<div className="flex h-full w-full">
<div className="h-full w-full">
<ModuleLayoutRoot />
<div className="h-full w-full overflow-hidden">
<ModuleLayoutRoot openIssuesListModal={openIssuesListModal} />
</div>
{moduleId && !isSidebarCollapsed && (
<div