binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-4025] fix: external user comment and reaction (#7692)

Browse source 
* chore: reactions types updated

* fix: external user comments

* fix: external user reactions

* chore: added display name for actor

* chore: merge conflicts

* chore: updated the created_by and updated_by

---------

Co-authored-by: NarayanBavisetti <narayan3119@gmail.com>
This commit is contained in:
Anmol Singh Bhatia 2025-09-09 23:50:11 +05:30 • committed by GitHub
parent 260d9a053d
commit 56cd0fc445
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 42 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/web/core/components/issues/issue-detail/reactions/issue-comment.tsx
View file

@ -85,7 +85,9 @@ export const IssueCommentReaction: FC<TIssueCommentReaction> = observer((props)
const reactionUsers = (reactionIds?.[reaction] || [])
.map((reactionId) => {
const reactionDetails = getCommentReactionById(reactionId);
return reactionDetails ? getUserDetails(reactionDetails.actor)?.display_name : null;
return reactionDetails
? getUserDetails(reactionDetails?.actor)?.display_name || reactionDetails?.display_name
: null;
})
.filter((displayName): displayName is string => !!displayName);
const formattedUsers = formatTextList(reactionUsers);

4
apps/web/core/components/issues/issue-detail/reactions/issue.tsx
View file

@ -85,7 +85,9 @@ export const IssueReaction: FC<TIssueReaction> = observer((props) => {
const reactionUsers = (reactionIds?.[reaction] || [])
.map((reactionId) => {
const reactionDetails = getReactionById(reactionId);
return reactionDetails ? getUserDetails(reactionDetails.actor)?.display_name : null;
return reactionDetails
? getUserDetails(reactionDetails?.actor)?.display_name || reactionDetails?.display_name
: null;
})
.filter((displayName): displayName is string => !!displayName);