fix: lint (#7433)

* chore: fix lint

* fix: constants check:lint command

* chore(lint): permit unused vars which begin w/ _

* chore: rm dead code

* fix(lint): more lint fixes to constants pkg

* fix(lint): lint the live server

- fix lint issues

* chore: improve clean script

* fix(lint): more lint

* chore: set live server process title

* chore(deps): update to turbo@2.5.5

* chore(live): target node22

* fix(dev): add missing ui pkg dependency

* fix(dev): lint decorators

* fix(dev): lint space app

* fix(dev): address lint issues in types pkg

* fix(dev): lint editor pkg

* chore(dev): moar lint

* fix(dev): live server exit code

* chore: address PR feedback

* fix(lint): better TPageExtended type

* chore: refactor

* chore: revert most live server changes

* fix: few more lint issues

* chore: enable ci checks

Ensure we can build + confirm that lint is not getting worse.

* chore: address PR feedback

* fix: web lint warning added to package.json

* fix: ci:lint command

---------

Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>

apps/live/package.json

@@ -10,7 +10,7 @@
     "dev": "tsup --watch --onSuccess 'node --env-file=.env dist/server.js'",
     "build": "tsc --noEmit && tsup",
     "start": "node --env-file=.env dist/server.js",
-    "check:lint": "eslint . --max-warnings 0",
+    "check:lint": "eslint . --max-warnings 10",
     "check:types": "tsc --noEmit",
     "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"",
     "fix:lint": "eslint . --fix",
@@ -51,14 +51,15 @@
     "@types/compression": "1.8.1",
     "@types/cors": "^2.8.17",
     "@types/dotenv": "^8.2.0",
-    "@types/express": "^4.17.21",
-    "@types/express-ws": "^3.0.4",
+    "@types/express": "^4.17.23",
+    "@types/express-ws": "^3.0.5",
     "@types/node": "^20.14.9",
     "@types/pino-http": "^5.8.4",
     "concurrently": "^9.0.1",
     "nodemon": "^3.1.7",
     "ts-node": "^10.9.2",
     "tsup": "8.4.0",
-    "typescript": "5.8.3"
+    "typescript": "5.8.3",
+    "ws": "^8.18.3"
   }
 }

apps/live/src/ce/types/common.d.ts

@@ -1 +1 @@
-export type TAdditionalDocumentTypes = {};
+export type TAdditionalDocumentTypes = never;

apps/live/src/core/helpers/logger.ts

@@ -9,6 +9,7 @@ const transport = {
 };
 
 const hooks = {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   logMethod(inputArgs: any, method: any): any {
     if (inputArgs.length >= 2) {
       const arg1 = inputArgs.shift();

apps/live/src/core/hocuspocus-server.ts

@@ -52,7 +52,7 @@ export const getHocusPocusServer = async () => {
           cookie,
           userId,
         });
-      } catch (error) {
+      } catch (_error) {
         throw Error("Authentication unsuccessful!");
       }
     },

apps/live/src/core/services/api.service.ts

@@ -36,7 +36,7 @@ export abstract class APIService {
     return this.axiosInstance.patch(url, data, config);
   }
 
-  delete(url: string, data?: any, config = {}) {
+  delete(url: string, data?: Record<string, unknown> | null | string, config = {}) {
     return this.axiosInstance.delete(url, { data, ...config });
   }