From 60aea627392c46371c0ffde7181399a4755a3fcd Mon Sep 17 00:00:00 2001 From: guru_sainath Date: Fri, 22 Mar 2024 18:28:44 +0530 Subject: [PATCH] fix: handled inital empty state close in the issue create/edit odal (#4033) --- .../issues/issue-modal/draft-issue-layout.tsx | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/web/components/issues/issue-modal/draft-issue-layout.tsx b/web/components/issues/issue-modal/draft-issue-layout.tsx index 78a97675e..240968faa 100644 --- a/web/components/issues/issue-modal/draft-issue-layout.tsx +++ b/web/components/issues/issue-modal/draft-issue-layout.tsx @@ -53,7 +53,7 @@ export const DraftIssueLayout: React.FC = observer((props) => { Object.entries(changesMade).forEach(([key, value]) => { const issueKey = key as keyof TIssue; if (value === null || value === undefined || value === "") delete changesMade[issueKey]; - if (typeof value === "object" && !value) delete changesMade[issueKey]; + if (typeof value === "object" && isEmpty(value)) delete changesMade[issueKey]; if (Array.isArray(value) && value.length === 0) delete changesMade[issueKey]; if (issueKey === "project_id") delete changesMade.project_id; if (issueKey === "priority" && value && value === "none") delete changesMade.priority; @@ -64,8 +64,13 @@ export const DraftIssueLayout: React.FC = observer((props) => { ) delete changesMade.description_html; }); - if (isEmpty(changesMade)) onClose(false); - else setIssueDiscardModal(true); + if (isEmpty(changesMade)) { + onClose(false); + setIssueDiscardModal(false); + } else setIssueDiscardModal(true); + } else { + onClose(false); + setIssueDiscardModal(false); } };