diff --git a/web/core/components/issues/attachment/attachment-detail.tsx b/web/core/components/issues/attachment/attachment-detail.tsx index d2c24d355..255b955bb 100644 --- a/web/core/components/issues/attachment/attachment-detail.tsx +++ b/web/core/components/issues/attachment/attachment-detail.tsx @@ -52,7 +52,7 @@ export const IssueAttachmentsDetail: FC = observer((pro isOpen={isDeleteIssueAttachmentModalOpen} onClose={() => setIsDeleteIssueAttachmentModalOpen(false)} handleAttachmentOperations={handleAttachmentOperations} - data={attachment} + attachmentId={attachmentId} /> )}
diff --git a/web/core/components/issues/attachment/attachment-item-list.tsx b/web/core/components/issues/attachment/attachment-item-list.tsx index f88505ce4..75881e271 100644 --- a/web/core/components/issues/attachment/attachment-item-list.tsx +++ b/web/core/components/issues/attachment/attachment-item-list.tsx @@ -9,6 +9,7 @@ import { useInstance, useIssueDetail } from "@/hooks/store"; // components import { IssueAttachmentsListItem } from "./attachment-list-item"; // types +import { IssueAttachmentDeleteModal } from "./delete-attachment-modal"; import { TAttachmentOperations } from "./root"; type TAttachmentOperationsRemoveModal = Exclude; @@ -28,6 +29,8 @@ export const IssueAttachmentItemList: FC = observer((p const { config } = useInstance(); const { attachment: { getAttachmentsByIssueId }, + attachmentDeleteModalId, + toggleDeleteAttachmentModal, } = useIssueDetail(); // derived values const issueAttachments = getAttachmentsByIssueId(issueId); @@ -65,29 +68,34 @@ export const IssueAttachmentItemList: FC = observer((p if (!issueAttachments) return <>; return ( -
- - {isDragActive && ( -
-
-
- - Drag and drop anywhere to upload + <> + {attachmentDeleteModalId && ( + toggleDeleteAttachmentModal(null)} + handleAttachmentOperations={handleAttachmentOperations} + attachmentId={attachmentDeleteModalId} + /> + )} +
+ + {isDragActive && ( +
+
+
+ + Drag and drop anywhere to upload +
-
- )} - {issueAttachments?.map((attachmentId) => ( - - ))} -
+ )} + {issueAttachments?.map((attachmentId) => ( + + ))} +
+ ); }); diff --git a/web/core/components/issues/attachment/attachment-list-item.tsx b/web/core/components/issues/attachment/attachment-list-item.tsx index dadea0d06..28cff6995 100644 --- a/web/core/components/issues/attachment/attachment-list-item.tsx +++ b/web/core/components/issues/attachment/attachment-list-item.tsx @@ -8,32 +8,25 @@ import { CustomMenu, Tooltip } from "@plane/ui"; // components import { ButtonAvatars } from "@/components/dropdowns/member/avatar"; import { getFileIcon } from "@/components/icons"; -import { IssueAttachmentDeleteModal } from "@/components/issues"; // helpers import { convertBytesToSize, getFileExtension, getFileName } from "@/helpers/attachment.helper"; import { renderFormattedDate } from "@/helpers/date-time.helper"; // hooks import { useIssueDetail, useMember } from "@/hooks/store"; import { usePlatformOS } from "@/hooks/use-platform-os"; -// types -import { TAttachmentOperations } from "./root"; - -type TAttachmentOperationsRemoveModal = Exclude; type TIssueAttachmentsListItem = { attachmentId: string; - handleAttachmentOperations: TAttachmentOperationsRemoveModal; disabled?: boolean; }; export const IssueAttachmentsListItem: FC = observer((props) => { // props - const { attachmentId, handleAttachmentOperations, disabled } = props; + const { attachmentId, disabled } = props; // store hooks const { getUserDetails } = useMember(); const { attachment: { getAttachmentById }, - isDeleteAttachmentModalOpen, toggleDeleteAttachmentModal, } = useIssueDetail(); @@ -46,14 +39,6 @@ export const IssueAttachmentsListItem: FC = observer( return ( <> - {isDeleteAttachmentModalOpen && ( - toggleDeleteAttachmentModal(false)} - handleAttachmentOperations={handleAttachmentOperations} - data={attachment} - /> - )}