From 6e574515e0e70f5888e9bc52789eafaa3112f988 Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Date: Wed, 24 Apr 2024 15:16:47 +0530
Subject: [PATCH] fix: module delete modal outside click event propagation
 (#4265)

---
 web/components/modules/module-list-item.tsx | 178 ++++++++++----------
 1 file changed, 88 insertions(+), 90 deletions(-)

diff --git a/web/components/modules/module-list-item.tsx b/web/components/modules/module-list-item.tsx
index c6d59471b..7503811fb 100644
--- a/web/components/modules/module-list-item.tsx
+++ b/web/components/modules/module-list-item.tsx
@@ -135,103 +135,101 @@ export const ModuleListItem: React.FC<Props> = observer((props) => {
   const completedModuleCheck = moduleDetails.status === "completed";
 
   return (
-    <Link
-      href={`/${workspaceSlug}/projects/${moduleDetails.project_id}/modules/${moduleDetails.id}`}
-      onClick={(e) => {
-        if (isArchived) {
-          openModuleOverview(e);
-        }
-      }}
-    >
-      <div className="group flex w-full flex-col items-center justify-between gap-5 border-b border-custom-border-100 bg-custom-background-100 px-5 py-6 text-sm hover:bg-custom-background-90 sm:flex-row">
-        <div className="relative flex w-full items-center justify-between gap-3 overflow-hidden">
-          <div className="relative flex w-full items-center gap-3 overflow-hidden">
-            <div className="flex items-center gap-4 truncate">
-              <span className="flex-shrink-0">
-                <CircularProgressIndicator size={38} percentage={progress}>
-                  {completedModuleCheck ? (
-                    progress === 100 ? (
-                      <Check className="h-3 w-3 stroke-[2] text-custom-primary-100" />
-                    ) : (
-                      <span className="text-sm text-custom-primary-100">{`!`}</span>
-                    )
-                  ) : progress === 100 ? (
+    <div className="group flex w-full flex-col items-center justify-between gap-5 border-b border-custom-border-100 bg-custom-background-100 px-5 py-6 text-sm hover:bg-custom-background-90 sm:flex-row">
+      <Link
+        href={`/${workspaceSlug}/projects/${moduleDetails.project_id}/modules/${moduleDetails.id}`}
+        onClick={(e) => {
+          if (isArchived) {
+            openModuleOverview(e);
+          }
+        }}
+        className="relative flex w-full items-center justify-between gap-3 overflow-hidden"
+      >
+        <div className="relative flex w-full items-center gap-3 overflow-hidden">
+          <div className="flex items-center gap-4 truncate">
+            <span className="flex-shrink-0">
+              <CircularProgressIndicator size={38} percentage={progress}>
+                {completedModuleCheck ? (
+                  progress === 100 ? (
                     <Check className="h-3 w-3 stroke-[2] text-custom-primary-100" />
                   ) : (
-                    <span className="text-xs text-custom-text-300">{`${progress}%`}</span>
-                  )}
-                </CircularProgressIndicator>
-              </span>
-              <Tooltip tooltipContent={moduleDetails.name} position="top" isMobile={isMobile}>
-                <span className="truncate text-base font-medium">{moduleDetails.name}</span>
-              </Tooltip>
-            </div>
-            <button onClick={openModuleOverview} className="z-[5] hidden flex-shrink-0 group-hover:flex">
-              <Info className="h-4 w-4 text-custom-text-400" />
-            </button>
-          </div>
-          <div className="flex flex-shrink-0 items-center justify-center">
-            {moduleStatus && (
-              <span
-                className="flex h-6 w-20 flex-shrink-0 items-center justify-center rounded-sm text-center text-xs"
-                style={{
-                  color: moduleStatus.color,
-                  backgroundColor: `${moduleStatus.color}20`,
-                }}
-              >
-                {moduleStatus.label}
-              </span>
-            )}
+                    <span className="text-sm text-custom-primary-100">{`!`}</span>
+                  )
+                ) : progress === 100 ? (
+                  <Check className="h-3 w-3 stroke-[2] text-custom-primary-100" />
+                ) : (
+                  <span className="text-xs text-custom-text-300">{`${progress}%`}</span>
+                )}
+              </CircularProgressIndicator>
+            </span>
+            <Tooltip tooltipContent={moduleDetails.name} position="top" isMobile={isMobile}>
+              <span className="truncate text-base font-medium">{moduleDetails.name}</span>
+            </Tooltip>
           </div>
+          <button onClick={openModuleOverview} className="z-[5] hidden flex-shrink-0 group-hover:flex">
+            <Info className="h-4 w-4 text-custom-text-400" />
+          </button>
+        </div>
+        <div className="flex flex-shrink-0 items-center justify-center">
+          {moduleStatus && (
+            <span
+              className="flex h-6 w-20 flex-shrink-0 items-center justify-center rounded-sm text-center text-xs"
+              style={{
+                color: moduleStatus.color,
+                backgroundColor: `${moduleStatus.color}20`,
+              }}
+            >
+              {moduleStatus.label}
+            </span>
+          )}
+        </div>
+      </Link>
+      <div className="relative flex w-full items-center justify-between gap-2.5 sm:w-auto sm:flex-shrink-0 sm:justify-end ">
+        <div className="text-xs text-custom-text-300">
+          {renderDate && (
+            <span className=" text-xs text-custom-text-300">
+              {renderFormattedDate(startDate) ?? "_ _"} - {renderFormattedDate(endDate) ?? "_ _"}
+            </span>
+          )}
         </div>
 
-        <div className="relative flex w-full items-center justify-between gap-2.5 sm:w-auto sm:flex-shrink-0 sm:justify-end ">
-          <div className="text-xs text-custom-text-300">
-            {renderDate && (
-              <span className=" text-xs text-custom-text-300">
-                {renderFormattedDate(startDate) ?? "_ _"} - {renderFormattedDate(endDate) ?? "_ _"}
-              </span>
-            )}
-          </div>
+        <div className="relative flex flex-shrink-0 items-center gap-3">
+          <Tooltip tooltipContent={`${moduleDetails?.member_ids?.length || 0} Members`} isMobile={isMobile}>
+            <div className="flex w-10 cursor-default items-center justify-center gap-1">
+              {moduleDetails.member_ids.length > 0 ? (
+                <AvatarGroup showTooltip={false}>
+                  {moduleDetails.member_ids.map((member_id) => {
+                    const member = getUserDetails(member_id);
+                    return <Avatar key={member?.id} name={member?.display_name} src={member?.avatar} />;
+                  })}
+                </AvatarGroup>
+              ) : (
+                <span className="flex h-5 w-5 items-end justify-center rounded-full border border-dashed border-custom-text-400 bg-custom-background-80">
+                  <User2 className="h-4 w-4 text-custom-text-400" />
+                </span>
+              )}
+            </div>
+          </Tooltip>
 
-          <div className="relative flex flex-shrink-0 items-center gap-3">
-            <Tooltip tooltipContent={`${moduleDetails?.member_ids?.length || 0} Members`} isMobile={isMobile}>
-              <div className="flex w-10 cursor-default items-center justify-center gap-1">
-                {moduleDetails.member_ids.length > 0 ? (
-                  <AvatarGroup showTooltip={false}>
-                    {moduleDetails.member_ids.map((member_id) => {
-                      const member = getUserDetails(member_id);
-                      return <Avatar key={member?.id} name={member?.display_name} src={member?.avatar} />;
-                    })}
-                  </AvatarGroup>
-                ) : (
-                  <span className="flex h-5 w-5 items-end justify-center rounded-full border border-dashed border-custom-text-400 bg-custom-background-80">
-                    <User2 className="h-4 w-4 text-custom-text-400" />
-                  </span>
-                )}
-              </div>
-            </Tooltip>
-
-            {isEditingAllowed && !isArchived && (
-              <FavoriteStar
-                onClick={(e) => {
-                  if (moduleDetails.is_favorite) handleRemoveFromFavorites(e);
-                  else handleAddToFavorites(e);
-                }}
-                selected={moduleDetails.is_favorite}
-              />
-            )}
-            {workspaceSlug && projectId && (
-              <ModuleQuickActions
-                moduleId={moduleId}
-                projectId={projectId.toString()}
-                workspaceSlug={workspaceSlug.toString()}
-                isArchived={isArchived}
-              />
-            )}
-          </div>
+          {isEditingAllowed && !isArchived && (
+            <FavoriteStar
+              onClick={(e) => {
+                if (moduleDetails.is_favorite) handleRemoveFromFavorites(e);
+                else handleAddToFavorites(e);
+              }}
+              selected={moduleDetails.is_favorite}
+            />
+          )}
+          {workspaceSlug && projectId && (
+            <ModuleQuickActions
+              moduleId={moduleId}
+              projectId={projectId.toString()}
+              workspaceSlug={workspaceSlug.toString()}
+              isArchived={isArchived}
+            />
+          )}
         </div>
       </div>
-    </Link>
+    </div>
   );
 });