binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-1681] fix: onboarding password validation on weak password (#4899)

Browse source 
* fix: onboarding password validation on weak passwrod

* fix: updated button disabled logic
This commit is contained in:
guru_sainath 2024-06-21 13:26:50 +05:30 • committed by GitHub
parent d164aa5117
commit 7bb1f7c210
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

13
web/core/components/onboarding/profile-setup.tsx
View file

@ -250,9 +250,10 @@ export const ProfileSetup: React.FC<Props> = observer((props) => {
// derived values
const isPasswordAlreadySetup = !user?.is_password_autoset;
const currentPassword = watch("password") || undefined;
const currentConfirmPassword = watch("confirm_password") || undefined;
const isValidPassword = useMemo(() => {
const currentPassword = watch("password") || undefined;
const currentConfirmPassword = watch("confirm_password") || undefined;
if (currentPassword) {
if (
currentPassword === currentConfirmPassword &&
@ -265,14 +266,12 @@ export const ProfileSetup: React.FC<Props> = observer((props) => {
} else {
return true;
}
}, [watch]);
}, [currentPassword, currentConfirmPassword]);
// Check for all available fields validation and if password field is available, then checks for password validation (strength + confirmation).
// Also handles the condition for optional password i.e if password field is optional it only checks for above validation if it's not empty.
const isButtonDisabled = useMemo(
() => (!isSubmitting && isValid && (isPasswordAlreadySetup ? true : isValidPassword) ? false : true),
[isSubmitting, isValid, isPasswordAlreadySetup, isValidPassword]
);
const isButtonDisabled =
!isSubmitting && isValid ? (isPasswordAlreadySetup ? false : isValidPassword ? false : true) : true;
const isCurrentStepUserPersonalization = profileSetupStep === EProfileSetupSteps.USER_PERSONALIZATION;