binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: V3 release blocker bugs (#2968)

Browse source 
* fix add subgroup issue FED-1101

* fix subgroup by None assignee FED-1100

* fix grouping by asignee or labels FED-1096

* fix create view popup FED-1093

* fix subgroup exception in swimlanes
This commit is contained in:
rahulramesha 2023-12-01 18:51:52 +05:30 • committed by sriram veeraghanta
parent d7457ed5f4
commit 7bc05b0bdc
6 changed files with 49 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
web/store/command-palette.store.ts
View file

@ -115,7 +115,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
}
toggleCommandPaletteModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCommandPaletteOpen = value;
} else {
this.isCommandPaletteOpen = !this.isCommandPaletteOpen;
@ -123,7 +123,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleShortcutModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isShortcutModalOpen = value;
} else {
this.isShortcutModalOpen = !this.isShortcutModalOpen;
@ -131,7 +131,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreateProjectModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCreateProjectModalOpen = value;
} else {
this.isCreateProjectModalOpen = !this.isCreateProjectModalOpen;
@ -139,7 +139,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreateCycleModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCreateCycleModalOpen = value;
} else {
this.isCreateCycleModalOpen = !this.isCreateCycleModalOpen;
@ -147,7 +147,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreateViewModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCreateViewModalOpen = value;
} else {
this.isCreateViewModalOpen = !this.isCreateViewModalOpen;
@ -155,7 +155,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreatePageModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCreatePageModalOpen = value;
} else {
this.isCreatePageModalOpen = !this.isCreatePageModalOpen;
@ -163,7 +163,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreateIssueModal = (value?: boolean, storeType?: EProjectStore) => {
if (value) {
if (value !== undefined) {
this.isCreateIssueModalOpen = value;
this.createIssueStoreType = storeType || EProjectStore.PROJECT;
} else {
@ -173,7 +173,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleDeleteIssueModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isDeleteIssueModalOpen = value;
} else {
this.isDeleteIssueModalOpen = !this.isDeleteIssueModalOpen;
@ -181,7 +181,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleCreateModuleModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isCreateModuleModalOpen = value;
} else {
this.isCreateModuleModalOpen = !this.isCreateModuleModalOpen;
@ -189,7 +189,7 @@ class CommandPaletteStore implements ICommandPaletteStore {
};
toggleBulkDeleteIssueModal = (value?: boolean) => {
if (value) {
if (value !== undefined) {
this.isBulkDeleteIssueModalOpen = value;
} else {
this.isBulkDeleteIssueModalOpen = !this.isBulkDeleteIssueModalOpen;

11
web/store/issues/project-issues/base-issue.store.ts
View file

@ -91,8 +91,9 @@ export class IssueBaseStore implements IIssueBaseStore {
for (const subGroup of subGroupArray) {
for (const group of groupArray) {
if (subGroup && group && _issues[subGroup][group]) _issues[subGroup][group].push(_issue.id);
else if (subGroup && group) _issues[subGroup][group] = [_issue.id];
if (subGroup && group && _issues?.[subGroup]?.[group]) _issues[subGroup][group].push(_issue.id);
else if (subGroup && group && _issues[subGroup]) _issues[subGroup][group] = [_issue.id];
else if (subGroup && group) _issues[subGroup] = { [group]: [_issue.id] };
}
}
}
@ -197,8 +198,10 @@ export class IssueBaseStore implements IIssueBaseStore {
};
getGroupArray(value: string[] | string | null, isDate: boolean = false) {
if (Array.isArray(value)) return value;
else if (isDate) return [renderDateFormat(value) || "None"];
if (Array.isArray(value)) {
if (value.length) return value;
else return ["None"];
} else if (isDate) return [renderDateFormat(value) || "None"];
else return [value || "None"];
}
}