binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: linting issues and rule changes (#5681)

Browse source 
* fix: lint config package updates

* fix: tsconfig changes

* fix: lint config setup

* fix: lint errors and adding new rules

* fix: lint errors

* fix: ui and editor lints

* fix: build error

* fix: editor tsconfig

* fix: lint errors

* fix: types fixes

---------

Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so>
Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>
This commit is contained in:
sriram veeraghanta 2024-09-23 17:10:38 +05:30 • committed by GitHub
parent e143e0a051
commit 83bfca6f2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
75 changed files with 1583 additions and 2631 deletions
Download patch file Download diff file Expand all files Collapse all files

11
web/core/components/analytics/custom-analytics/select-bar.tsx
View file

@ -1,13 +1,14 @@
import { observer } from "mobx-react";
import { Control, Controller, UseFormSetValue } from "react-hook-form";
// types
import { IAnalyticsParams } from "@plane/types";
// hooks
import { SelectProject, SelectSegment, SelectXAxis, SelectYAxis } from "@/components/analytics";
import { ANALYTICS_X_AXIS_VALUES } from "@/constants/analytics";
import { useProject } from "@/hooks/store";
// ui
import { Row } from "@plane/ui";
// components
// types
import { SelectProject, SelectSegment, SelectXAxis, SelectYAxis } from "@/components/analytics";
import { ANALYTICS_X_AXIS_VALUES } from "@/constants/analytics";
// hooks
import { useProject } from "@/hooks/store";
type Props = {
control: Control<IAnalyticsParams, any>;

2
web/core/components/editor/lite-text-editor/lite-text-read-only-editor.tsx
View file

@ -6,7 +6,7 @@ import { cn } from "@/helpers/common.helper";
// hooks
import { useMention, useUser } from "@/hooks/store";
interface LiteTextReadOnlyEditorWrapperProps extends Omit<ILiteTextReadOnlyEditor, "mentionHandler"> {}
type LiteTextReadOnlyEditorWrapperProps = Omit<ILiteTextReadOnlyEditor, "mentionHandler">;
export const LiteTextReadOnlyEditor = React.forwardRef<EditorReadOnlyRefApi, LiteTextReadOnlyEditorWrapperProps>(
({ ...props }, ref) => {

2
web/core/components/editor/rich-text-editor/rich-text-read-only-editor.tsx
View file

@ -6,7 +6,7 @@ import { cn } from "@/helpers/common.helper";
// hooks
import { useMention } from "@/hooks/store";
interface RichTextReadOnlyEditorWrapperProps extends Omit<IRichTextReadOnlyEditor, "mentionHandler"> {}
type RichTextReadOnlyEditorWrapperProps = Omit<IRichTextReadOnlyEditor, "mentionHandler">;
export const RichTextReadOnlyEditor = React.forwardRef<EditorReadOnlyRefApi, RichTextReadOnlyEditorWrapperProps>(
({ ...props }, ref) => {

2
web/core/components/issues/issue-detail/label/root.tsx
View file

@ -10,6 +10,8 @@ import { useIssueDetail, useLabel, useProjectInbox, useUserPermissions } from "@
// ui
// types
import { LabelList, LabelCreate, IssueLabelSelectRoot } from "./";
// TODO: Fix this import statement, as core should not import from ee
// eslint-disable-next-line import/order
import { EUserPermissions, EUserPermissionsLevel } from "ee/constants/user-permissions";
export type TIssueLabel = {

2
web/core/components/issues/issue-layouts/kanban/roots/cycle-root.tsx
View file

@ -11,8 +11,6 @@ import { EUserPermissions, EUserPermissionsLevel } from "@/plane-web/constants/u
// components
import { BaseKanBanRoot } from "../base-kanban-root";
export interface ICycleKanBanLayout {}
export const CycleKanBanLayout: React.FC = observer(() => {
const { workspaceSlug, projectId, cycleId } = useParams();

2
web/core/components/issues/issue-layouts/kanban/roots/draft-issue-root.tsx
View file

@ -3,6 +3,4 @@ import { observer } from "mobx-react";
import { DraftIssueQuickActions } from "@/components/issues";
import { BaseKanBanRoot } from "../base-kanban-root";
export interface IKanBanLayout {}
export const DraftKanBanLayout: React.FC = observer(() => <BaseKanBanRoot QuickActions={DraftIssueQuickActions} />);

2
web/core/components/issues/issue-layouts/kanban/roots/module-root.tsx
View file

@ -10,8 +10,6 @@ import { useIssues } from "@/hooks/store";
// constants
import { BaseKanBanRoot } from "../base-kanban-root";
export interface IModuleKanBanLayout {}
export const ModuleKanBanLayout: React.FC = observer(() => {
const { workspaceSlug, projectId, moduleId } = useParams();

4
web/core/components/issues/issue-layouts/list/block-root.tsx
View file

@ -131,9 +131,7 @@ export const IssueBlockRoot: FC<Props> = observer((props) => {
classNames={`relative ${isLastChild && !isExpanded ? "" : "border-b border-b-custom-border-200"}`}
verticalOffset={100}
defaultValue={shouldRenderByDefault || isIssueNew(issuesMap[issueId])}
placeholderChildren={
<ListLoaderItemRow shouldAnimate={false} renderForPlaceHolder={true} defaultPropertyCount={4} />
}
placeholderChildren={<ListLoaderItemRow shouldAnimate={false} renderForPlaceHolder defaultPropertyCount={4} />}
shouldRecordHeights={isMobile}
>
<IssueBlock

2
web/core/components/issues/issue-layouts/list/roots/cycle-root.tsx
View file

@ -11,8 +11,6 @@ import { EUserPermissions, EUserPermissionsLevel } from "@/plane-web/constants/u
// types
import { BaseListRoot } from "../base-list-root";
export interface ICycleListLayout {}
export const CycleListLayout: React.FC = observer(() => {
const { workspaceSlug, projectId, cycleId } = useParams();
// store

2
web/core/components/issues/issue-layouts/list/roots/module-root.tsx
View file

@ -10,8 +10,6 @@ import { useIssues } from "@/hooks/store";
// constants
import { BaseListRoot } from "../base-list-root";
export interface IModuleListLayout {}
export const ModuleListLayout: React.FC = observer(() => {
const { workspaceSlug, projectId, moduleId } = useParams();

4
web/core/components/project/form-loader.tsx
View file

@ -4,9 +4,7 @@ import { FC } from "react";
// components
import { Loader } from "@plane/ui";
export interface IProjectDetailsFormLoader {}
export const ProjectDetailsFormLoader: FC<IProjectDetailsFormLoader> = () => (
export const ProjectDetailsFormLoader: FC = () => (
<>
<div className="relative mt-6 h-44 w-full">
<Loader>