binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WIKI-391] chore: handle deactivated user display name in version history #7171

Browse source
This commit is contained in:
Aaryan Khandelwal 2025-06-06 15:04:00 +05:30 • committed by GitHub
parent 053c895120
commit 950fcfdb40
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
web/core/components/core/description-versions/dropdown-item.tsx
View file

@ -31,7 +31,7 @@ export const DescriptionVersionsDropdownItem: React.FC<Props> = observer((props)
/>
</span>
<p className="text-xs text-custom-text-200 flex items-center gap-1.5">
<span className="font-medium">{versionCreator?.display_name}</span>
<span className="font-medium">{versionCreator?.display_name ?? t("common.deactivated_user")}</span>
<span>{calculateTimeAgo(version.last_saved_at)}</span>
</p>
</CustomMenu.MenuItem>

3
web/core/components/core/description-versions/dropdown.tsx
View file

@ -40,7 +40,8 @@ export const DescriptionVersionsDropdown: React.FC<Props> = observer((props) =>
</span>
<p className="text-xs">
{t("description_versions.last_edited_by")}{" "}
<span className="font-medium">{lastUpdatedByUserDisplayName}</span> {calculateTimeAgo(lastUpdatedAt)}
<span className="font-medium">{lastUpdatedByUserDisplayName ?? t("common.deactivated_user")}</span>{" "}
{calculateTimeAgo(lastUpdatedAt)}
</p>
</div>
}

8
web/core/components/pages/version/sidebar-list-item.tsx
View file

@ -1,8 +1,8 @@
import { observer } from "mobx-react";
import Link from "next/link";
// plane types
// plane imports
import { useTranslation } from "@plane/i18n";
import { TPageVersion } from "@plane/types";
// plane ui
import { Avatar } from "@plane/ui";
// helpers
import { cn } from "@/helpers/common.helper";
@ -23,6 +23,8 @@ export const PlaneVersionsSidebarListItem: React.FC<Props> = observer((props) =>
const { getUserDetails } = useMember();
// derived values
const ownerDetails = getUserDetails(version.owned_by);
// translation
const { t } = useTranslation();
return (
<Link
@ -42,7 +44,7 @@ export const PlaneVersionsSidebarListItem: React.FC<Props> = observer((props) =>
size="sm"
className="flex-shrink-0"
/>
<span className="text-custom-text-300">{ownerDetails?.display_name}</span>
<span className="text-custom-text-300">{ownerDetails?.display_name ?? t("common.deactivated_user")}</span>
</p>
</Link>
);