From 981a8e93ba106f4f7b38d503bd8b77c1afd230d8 Mon Sep 17 00:00:00 2001
From: Prateek Shourya <prateekshourya29@gmail.com>
Date: Tue, 25 Jun 2024 12:32:51 +0530
Subject: [PATCH] [WEB-1691] fix: update `ControlLink` default target to
 `_blank` to avoid unwanted N-progress trigger. (#4927)

---
 packages/ui/src/control-link/control-link.tsx                  | 2 +-
 web/core/components/core/list/list-item.tsx                    | 2 +-
 web/core/components/inbox/content/inbox-issue-header.tsx       | 1 +
 web/core/components/inbox/content/issue-properties.tsx         | 1 +
 .../components/issues/issue-layouts/calendar/issue-block.tsx   | 1 -
 web/core/components/issues/issue-layouts/gantt/blocks.tsx      | 1 -
 web/core/components/issues/issue-layouts/kanban/block.tsx      | 1 -
 web/core/components/issues/issue-layouts/list/block.tsx        | 3 +--
 .../components/issues/issue-layouts/spreadsheet/issue-row.tsx  | 1 -
 web/core/components/issues/sub-issues/issue-list-item.tsx      | 1 -
 10 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/packages/ui/src/control-link/control-link.tsx b/packages/ui/src/control-link/control-link.tsx
index 83f3157cc..83c719ca1 100644
--- a/packages/ui/src/control-link/control-link.tsx
+++ b/packages/ui/src/control-link/control-link.tsx
@@ -11,7 +11,7 @@ export type TControlLink = React.AnchorHTMLAttributes<HTMLAnchorElement> & {
 };
 
 export const ControlLink = React.forwardRef<HTMLAnchorElement, TControlLink>((props, ref) => {
-  const { href, onClick, children, target = "_self", disabled = false, className, draggable = false, ...rest } = props;
+  const { href, onClick, children, target = "_blank", disabled = false, className, draggable = false, ...rest } = props;
   const LEFT_CLICK_EVENT_CODE = 0;
 
   const handleOnClick = (event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) => {
diff --git a/web/core/components/core/list/list-item.tsx b/web/core/components/core/list/list-item.tsx
index 1e5a1327a..894f488e2 100644
--- a/web/core/components/core/list/list-item.tsx
+++ b/web/core/components/core/list/list-item.tsx
@@ -45,7 +45,7 @@ export const ListItem: FC<IListItemProps> = (props) => {
 
   return (
     <div ref={parentRef} className="relative">
-      <ControlLink href={itemLink} onClick={handleControlLinkClick} disabled={disableLink}>
+      <ControlLink href={itemLink} target="_self" onClick={handleControlLinkClick} disabled={disableLink}>
         <div
           className={cn(
             "group h-24 sm:h-[52px] flex w-full flex-col items-center justify-between gap-3 sm:gap-5 px-6 py-4 sm:py-0 text-sm border-b border-custom-border-200 bg-custom-background-100 hover:bg-custom-background-90 sm:flex-row",
diff --git a/web/core/components/inbox/content/inbox-issue-header.tsx b/web/core/components/inbox/content/inbox-issue-header.tsx
index bff3fe796..f0c763543 100644
--- a/web/core/components/inbox/content/inbox-issue-header.tsx
+++ b/web/core/components/inbox/content/inbox-issue-header.tsx
@@ -301,6 +301,7 @@ export const InboxIssueActionsHeader: FC<TInboxIssueActionsHeader> = observer((p
                   onClick={() =>
                     router.push(`/${workspaceSlug}/projects/${issue?.project_id}/issues/${currentInboxIssueId}`)
                   }
+                  target="_self"
                 >
                   <Button variant="neutral-primary" prependIcon={<ExternalLink className="h-2.5 w-2.5" />} size="sm">
                     Open issue
diff --git a/web/core/components/inbox/content/issue-properties.tsx b/web/core/components/inbox/content/issue-properties.tsx
index 2d8dc8a0e..bc3ca759e 100644
--- a/web/core/components/inbox/content/issue-properties.tsx
+++ b/web/core/components/inbox/content/issue-properties.tsx
@@ -173,6 +173,7 @@ export const InboxIssueContentProperties: React.FC<Props> = observer((props) =>
                   onClick={() => {
                     router.push(`/${workspaceSlug}/projects/${projectId}/issues/${duplicateIssueDetails?.id}`);
                   }}
+                  target="_self"
                 >
                   <Tooltip tooltipContent={`${duplicateIssueDetails?.name}`}>
                     <span className="flex items-center gap-1 cursor-pointer text-xs rounded px-1.5 py-1 pb-0.5 bg-custom-background-80 text-custom-text-200">
diff --git a/web/core/components/issues/issue-layouts/calendar/issue-block.tsx b/web/core/components/issues/issue-layouts/calendar/issue-block.tsx
index d6f967499..747425d41 100644
--- a/web/core/components/issues/issue-layouts/calendar/issue-block.tsx
+++ b/web/core/components/issues/issue-layouts/calendar/issue-block.tsx
@@ -71,7 +71,6 @@ export const CalendarIssueBlock = observer(
       <ControlLink
         id={`issue-${issue.id}`}
         href={`/${workspaceSlug?.toString()}/projects/${projectId?.toString()}/issues/${issue.id}`}
-        target="_blank"
         onClick={() => handleIssuePeekOverview(issue)}
         className="block w-full text-sm text-custom-text-100 rounded border-b md:border-[1px] border-custom-border-200 hover:border-custom-border-400"
         disabled={!!issue?.tempId || isMobile}
diff --git a/web/core/components/issues/issue-layouts/gantt/blocks.tsx b/web/core/components/issues/issue-layouts/gantt/blocks.tsx
index a0907ad08..69be0d2a2 100644
--- a/web/core/components/issues/issue-layouts/gantt/blocks.tsx
+++ b/web/core/components/issues/issue-layouts/gantt/blocks.tsx
@@ -99,7 +99,6 @@ export const IssueGanttSidebarBlock: React.FC<Props> = observer((props) => {
   return (
     <ControlLink
       href={`/${workspaceSlug}/projects/${issueDetails?.project_id}/issues/${issueDetails?.id}`}
-      target="_blank"
       onClick={handleIssuePeekOverview}
       className="line-clamp-1 w-full cursor-pointer text-sm text-custom-text-100"
       disabled={!!issueDetails?.tempId}
diff --git a/web/core/components/issues/issue-layouts/kanban/block.tsx b/web/core/components/issues/issue-layouts/kanban/block.tsx
index d4105ceb5..114742e78 100644
--- a/web/core/components/issues/issue-layouts/kanban/block.tsx
+++ b/web/core/components/issues/issue-layouts/kanban/block.tsx
@@ -217,7 +217,6 @@ export const KanbanIssueBlock: React.FC<IssueBlockProps> = observer((props) => {
             { "border border-custom-primary-70 hover:border-custom-primary-70": getIsIssuePeeked(issue.id) },
             { "bg-custom-background-80 z-[100]": isCurrentBlockDragging }
           )}
-          target="_blank"
           onClick={() => handleIssuePeekOverview(issue)}
           disabled={!!issue?.tempId || isMobile}
         >
diff --git a/web/core/components/issues/issue-layouts/list/block.tsx b/web/core/components/issues/issue-layouts/list/block.tsx
index 4a0aa493f..6ba4c14f6 100644
--- a/web/core/components/issues/issue-layouts/list/block.tsx
+++ b/web/core/components/issues/issue-layouts/list/block.tsx
@@ -229,8 +229,7 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
               id={`issue-${issue.id}`}
               href={`/${workspaceSlug}/projects/${issue.project_id}/${issue.archived_at ? "archives/" : ""}issues/${
                 issue.id
-              }`}
-              target="_blank"
+                }`}
               onClick={() => handleIssuePeekOverview(issue)}
               className="w-full truncate cursor-pointer text-sm text-custom-text-100"
               disabled={!!issue?.tempId}
diff --git a/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx b/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
index 9efd48048..2cdadf7c5 100644
--- a/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
+++ b/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
@@ -242,7 +242,6 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
       >
         <ControlLink
           href={`/${workspaceSlug}/projects/${issueDetail.project_id}/issues/${issueId}`}
-          target="_blank"
           onClick={() => handleIssuePeekOverview(issueDetail)}
           className={cn(
             "group clickable cursor-pointer h-11 w-[28rem] flex items-center text-sm after:absolute border-r-[0.5px] z-10 border-custom-border-200 bg-transparent group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10",
diff --git a/web/core/components/issues/sub-issues/issue-list-item.tsx b/web/core/components/issues/sub-issues/issue-list-item.tsx
index 5700a68d8..0923572f2 100644
--- a/web/core/components/issues/sub-issues/issue-list-item.tsx
+++ b/web/core/components/issues/sub-issues/issue-list-item.tsx
@@ -131,7 +131,6 @@ export const IssueListItem: React.FC<ISubIssues> = observer((props) => {
             <ControlLink
               id={`issue-${issue.id}`}
               href={`/${workspaceSlug}/projects/${issue.project_id}/issues/${issue.id}`}
-              target="_blank"
               onClick={() => handleIssuePeekOverview(issue)}
               className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
             >