binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: prevent prematurely triggered Japanese label creation (#7084)

Browse source
This commit is contained in:
Sangmin Ahn 2025-06-09 19:37:42 +09:00 • committed by GitHub
parent d15d7549f7
commit 9965f48ba7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/ui/src/hooks/use-dropdown-key-down.tsx
View file

@ -12,7 +12,7 @@ type TUseDropdownKeyDown = {
export const useDropdownKeyDown: TUseDropdownKeyDown = (onOpen, onClose, isOpen, selectActiveItem?) => {
const handleKeyDown = useCallback(
(event: React.KeyboardEvent<HTMLElement>) => {
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
if (!isOpen) {
event.stopPropagation();
onOpen();

2
web/core/components/issues/issue-detail/label/select/label-select.tsx
View file

@ -99,7 +99,7 @@ export const IssueLabelSelect: React.FC<IIssueLabelSelect> = observer((props) =>
setQuery("");
}
if (query !== "" && e.key === "Enter" && canCreateLabel) {
if (query !== "" && e.key === "Enter" && !e.nativeEvent.isComposing && canCreateLabel) {
e.stopPropagation();
e.preventDefault();
await handleAddLabel(query);

2
web/core/components/issues/issue-layouts/properties/label-dropdown.tsx
View file

@ -158,7 +158,7 @@ export const LabelDropdown = (props: ILabelDropdownProps) => {
setQuery("");
}
if (query !== "" && e.key === "Enter" && canCreateLabel) {
if (query !== "" && e.key === "Enter" && !e.nativeEvent.isComposing && canCreateLabel) {
e.preventDefault();
await handleAddLabel(query);
}

2
web/core/hooks/use-dropdown-key-down.tsx
View file

@ -21,7 +21,7 @@ export const useDropdownKeyDown: TUseDropdownKeyDown = (onEnterKeyDown, onEscKey
const handleKeyDown = useCallback(
(event: React.KeyboardEvent<HTMLElement>) => {
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
stopEventPropagation(event);
onEnterKeyDown();
} else if (event.key === "Escape") {