binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-1436] chore: pages improvement. (#4657)

Browse source 
* add empty state if no pages are available.
* set access to private in create page modal when the modal is open form private tab.
This commit is contained in:
Prateek Shourya 2024-05-31 18:30:38 +05:30 • committed by GitHub
parent 608e193c36
commit a2cdbd52dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 95 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

15
web/components/pages/modals/create-page-modal.tsx
View file

@ -1,4 +1,4 @@
import { FC, useState } from "react";
import { FC, useEffect, useState } from "react";
import { useRouter } from "next/router";
// types
import { TPage } from "@plane/types";
@ -15,29 +15,34 @@ type Props = {
workspaceSlug: string;
projectId: string;
isModalOpen: boolean;
pageAccess?: EPageAccess;
handleModalClose: () => void;
redirectionEnabled?: boolean;
};
export const CreatePageModal: FC<Props> = (props) => {
const { workspaceSlug, projectId, isModalOpen, handleModalClose, redirectionEnabled = false } = props;
const { workspaceSlug, projectId, isModalOpen, pageAccess, handleModalClose, redirectionEnabled = false } = props;
// states
const [pageFormData, setPageFormData] = useState<Partial<TPage>>({
id: undefined,
name: "",
access: EPageAccess.PUBLIC,
logo_props: undefined,
});
// router
const router = useRouter();
// store hooks
const { createPage } = useProjectPages(projectId);
const { createPage } = useProjectPages();
const { capturePageEvent } = useEventTracker();
const handlePageFormData = <T extends keyof TPage>(key: T, value: TPage[T]) =>
setPageFormData((prev) => ({ ...prev, [key]: value }));
// update page access in form data when page access from the store changes
useEffect(() => {
setPageFormData((prev) => ({ ...prev, access: pageAccess }));
}, [pageAccess]);
const handleStateClear = () => {
setPageFormData({ id: undefined, name: "", access: EPageAccess.PUBLIC });
setPageFormData({ id: undefined, name: "", access: pageAccess });
handleModalClose();
};

5
web/components/pages/modals/delete-page-modal.tsx
View file

@ -13,15 +13,14 @@ type TConfirmPageDeletionProps = {
isOpen: boolean;
onClose: () => void;
pageId: string;
projectId: string;
};
export const DeletePageModal: React.FC<TConfirmPageDeletionProps> = observer((props) => {
const { pageId, projectId, isOpen, onClose } = props;
const { pageId, isOpen, onClose } = props;
// states
const [isDeleting, setIsDeleting] = useState(false);
// store hooks
const { removePage } = useProjectPages(projectId);
const { removePage } = useProjectPages();
const { capturePageEvent } = useEventTracker();
const page = usePage(pageId);