binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-1436] chore: pages improvement. (#4657)

Browse source 
* add empty state if no pages are available.
* set access to private in create page modal when the modal is open form private tab.
This commit is contained in:
Prateek Shourya 2024-05-31 18:30:38 +05:30 • committed by GitHub
parent 608e193c36
commit a2cdbd52dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 95 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

30
web/store/command-palette.store.ts
View file

@ -1,6 +1,8 @@
import { observable, action, makeObservable, computed } from "mobx";
// services
import { EIssuesStoreType, TCreateModalStoreTypes } from "@/constants/issue";
// types / constants
import { DEFAULT_CREATE_PAGE_MODAL_DATA, EPageAccess, TCreatePageModal } from "@/constants/page";
export interface ModalData {
store: EIssuesStoreType;
@ -16,7 +18,7 @@ export interface ICommandPaletteStore {
isCreateCycleModalOpen: boolean;
isCreateModuleModalOpen: boolean;
isCreateViewModalOpen: boolean;
isCreatePageModalOpen: boolean;
createPageModal: TCreatePageModal;
isCreateIssueModalOpen: boolean;
isDeleteIssueModalOpen: boolean;
isBulkDeleteIssueModalOpen: boolean;
@ -28,7 +30,7 @@ export interface ICommandPaletteStore {
toggleCreateProjectModal: (value?: boolean) => void;
toggleCreateCycleModal: (value?: boolean) => void;
toggleCreateViewModal: (value?: boolean) => void;
toggleCreatePageModal: (value?: boolean) => void;
toggleCreatePageModal: (value?: TCreatePageModal) => void;
toggleCreateIssueModal: (value?: boolean, storeType?: TCreateModalStoreTypes) => void;
toggleCreateModuleModal: (value?: boolean) => void;
toggleDeleteIssueModal: (value?: boolean) => void;
@ -45,10 +47,10 @@ export class CommandPaletteStore implements ICommandPaletteStore {
isCreateCycleModalOpen: boolean = false;
isCreateModuleModalOpen: boolean = false;
isCreateViewModalOpen: boolean = false;
isCreatePageModalOpen: boolean = false;
isCreateIssueModalOpen: boolean = false;
isDeleteIssueModalOpen: boolean = false;
isBulkDeleteIssueModalOpen: boolean = false;
createPageModal: TCreatePageModal = DEFAULT_CREATE_PAGE_MODAL_DATA;
createIssueStoreType: TCreateModalStoreTypes = EIssuesStoreType.PROJECT;
@ -61,10 +63,10 @@ export class CommandPaletteStore implements ICommandPaletteStore {
isCreateCycleModalOpen: observable.ref,
isCreateModuleModalOpen: observable.ref,
isCreateViewModalOpen: observable.ref,
isCreatePageModalOpen: observable.ref,
isCreateIssueModalOpen: observable.ref,
isDeleteIssueModalOpen: observable.ref,
isBulkDeleteIssueModalOpen: observable.ref,
createPageModal: observable,
// computed
isAnyModalOpen: computed,
// projectPages: computed,
@ -90,13 +92,13 @@ export class CommandPaletteStore implements ICommandPaletteStore {
return Boolean(
this.isCreateIssueModalOpen ||
this.isCreateCycleModalOpen ||
this.isCreatePageModalOpen ||
this.isCreateProjectModalOpen ||
this.isCreateModuleModalOpen ||
this.isCreateViewModalOpen ||
this.isShortcutModalOpen ||
this.isBulkDeleteIssueModalOpen ||
this.isDeleteIssueModalOpen
this.isDeleteIssueModalOpen ||
this.createPageModal.isOpen
);
}
@ -166,15 +168,21 @@ export class CommandPaletteStore implements ICommandPaletteStore {
};
/**
* Toggles the create page modal
* Toggles the create page modal along with the page access
* @param value
* @returns
*/
toggleCreatePageModal = (value?: boolean) => {
if (value !== undefined) {
this.isCreatePageModalOpen = value;
toggleCreatePageModal = (value?: TCreatePageModal) => {
if (value) {
this.createPageModal = {
isOpen: value.isOpen,
pageAccess: value.pageAccess || EPageAccess.PUBLIC,
};
} else {
this.isCreatePageModalOpen = !this.isCreatePageModalOpen;
this.createPageModal = {
isOpen: !this.createPageModal.isOpen,
pageAccess: EPageAccess.PUBLIC,
};
}
};

10
web/store/pages/project-page.store.ts
View file

@ -22,6 +22,8 @@ export interface IProjectPageStore {
data: Record<string, IPageStore>; // pageId => PageStore
error: TError | undefined;
filters: TPageFilters;
// computed
isAnyPageAvailable: boolean;
// helper actions
getCurrentProjectPageIds: (pageType: TPageNavigationTabs) => string[] | undefined;
getCurrentProjectFilteredPageIds: (pageType: TPageNavigationTabs) => string[] | undefined;
@ -76,6 +78,14 @@ export class ProjectPageStore implements IProjectPageStore {
);
}
/**
* @description check if any page is available
*/
get isAnyPageAvailable() {
if (this.loader) return true;
return Object.keys(this.data).length > 0;
}
/**
* @description get the current project page ids based on the pageType
* @param {TPageNavigationTabs} pageType