binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WIKI-852] chore: update page version save logic (#8440)

Browse source 
* chore: updated the logic for page version task

* chore: updated the html variable

* chore: handled the exception

* chore: changed the function name

* chore: added a custom variable
This commit is contained in:
Bavisetti Narayan 2026-03-03 19:10:42 +05:30 • committed by GitHub
parent a9d688f290
commit a58642ed10
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 54 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

18
apps/api/plane/app/views/page/base.py
View file

@ -50,7 +50,7 @@ from plane.utils.error_codes import ERROR_CODES
# Local imports
from ..base import BaseAPIView, BaseViewSet
from plane.bgtasks.page_transaction_task import page_transaction
from plane.bgtasks.page_version_task import page_version
from plane.bgtasks.page_version_task import track_page_version
from plane.bgtasks.recent_visited_task import recent_visited_task
from plane.bgtasks.copy_s3_object import copy_s3_objects_of_description_and_assets
from plane.app.permissions import ProjectPagePermission
@ -545,26 +545,28 @@ class PagesDescriptionViewSet(BaseViewSet):
status=status.HTTP_400_BAD_REQUEST,
)
# Store the old description_html before saving (needed for both tasks)
old_description_html = page.description_html
# Serialize the existing instance
existing_instance = json.dumps({"description_html": page.description_html}, cls=DjangoJSONEncoder)
existing_instance = json.dumps({"description_html": old_description_html}, cls=DjangoJSONEncoder)
# Use serializer for validation and update
serializer = PageBinaryUpdateSerializer(page, data=request.data, partial=True)
if serializer.is_valid():
serializer.save()
# Capture the page transaction
if request.data.get("description_html"):
page_transaction.delay(
new_description_html=request.data.get("description_html", "<p></p>"),
old_description_html=page.description_html,
old_description_html=old_description_html,
page_id=page_id,
)
# Update the page using serializer
updated_page = serializer.save()
# Run background tasks
page_version.delay(
page_id=updated_page.id,
track_page_version.delay(
page_id=page_id,
existing_instance=existing_instance,
user_id=request.user.id,
)