binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-3826] fix: estimate dropdown formatting (#6906)

Browse source 
* * fix: time conversion for estimate dropdown in browse
* chore: updated puncutations for estimates.

* chore: estimate activiy formatting

* chore: estimate activity refactor
This commit is contained in:
Vamsi Krishna 2025-04-11 01:41:43 +05:30 • committed by GitHub
parent 33a1b916cb
commit b4fc715aba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 18 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

18
web/core/components/issues/issue-detail/issue-activity/activity/actions/estimate.tsx
View file

@ -2,10 +2,9 @@ import { FC } from "react";
import { observer } from "mobx-react";
import { Triangle } from "lucide-react";
// hooks
import { EEstimateSystem } from "@plane/types/src/enums";
import { convertMinutesToHoursMinutesString } from "@/helpers/date-time.helper";
import { useIssueDetail, useProjectEstimates } from "@/hooks/store";
import { useIssueDetail } from "@/hooks/store";
// components
import { renderEstimate } from "@/plane-web/components/issues/issue-details";
import { IssueActivityBlockComponent, IssueLink } from "./";
type TIssueEstimateActivity = { activityId: string; showIssue?: boolean; ends: "top" | "bottom" | undefined };
@ -16,18 +15,9 @@ export const IssueEstimateActivity: FC<TIssueEstimateActivity> = observer((props
const {
activity: { getActivityById },
} = useIssueDetail();
const { currentActiveEstimate } = useProjectEstimates();
const activity = getActivityById(activityId);
const renderValue = (value: string) => {
const isTinmeEstimate = currentActiveEstimate?.type === EEstimateSystem.TIME;
if (isTinmeEstimate) {
return convertMinutesToHoursMinutesString(Number(value));
}
return value;
};
if (!activity) return <></>;
return (
@ -38,7 +28,9 @@ export const IssueEstimateActivity: FC<TIssueEstimateActivity> = observer((props
>
<>
{activity.new_value ? `set the estimate to ` : `removed the estimate `}
{activity.new_value ? renderValue(activity.new_value) : renderValue(activity?.old_value || "")}
{activity.new_value
? renderEstimate(activity, activity.new_value)
: renderEstimate(activity, activity?.old_value || "")}
{showIssue && (activity.new_value ? ` to ` : ` from `)}
{showIssue && <IssueLink activityId={activityId} />}.
</>

2
web/core/components/issues/issue-detail/issue-activity/helper.tsx
View file

@ -1,6 +1,6 @@
import { useMemo } from "react";
import { useTranslation } from "@plane/i18n";
import { TCommentsOperations, TIssueComment } from "@plane/types";
import { TCommentsOperations, TIssueActivity, TIssueComment } from "@plane/types";
import { EFileAssetType } from "@plane/types/src/enums";
import { setToast, TOAST_TYPE } from "@plane/ui";
import { formatTextList } from "@/helpers/issue.helper";