binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-2348] fix: allow updating comments with just mentions in them (#5471)

Browse source 
* fix: accept mentions while updating comments

* chore: remove console log

* chore: update empty string helper function
This commit is contained in:
Aaryan Khandelwal 2024-09-02 14:00:41 +05:30 • committed by GitHub
parent 03c28a11e8
commit bac5b53ffb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 46 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

7
space/core/components/editor/lite-text-editor.tsx
View file

@ -5,7 +5,7 @@ import { EditorRefApi, ILiteTextEditor, LiteTextEditorWithRef } from "@plane/edi
import { IssueCommentToolbar } from "@/components/editor";
// helpers
import { cn } from "@/helpers/common.helper";
import { isEmptyHtmlString } from "@/helpers/string.helper";
import { isCommentEmpty } from "@/helpers/string.helper";
// hooks
import { useMention } from "@/hooks/use-mention";
// services
@ -33,10 +33,7 @@ export const LiteTextEditor = React.forwardRef<EditorRefApi, LiteTextEditorWrapp
function isMutableRefObject<T>(ref: React.ForwardedRef<T>): ref is React.MutableRefObject<T | null> {
return !!ref && typeof ref === "object" && "current" in ref;
}
const isEmpty =
props.initialValue?.trim() === "" ||
props.initialValue === "<p></p>" ||
(isEmptyHtmlString(props.initialValue ?? "") && !props.initialValue?.includes("mention-component"));
const isEmpty = isCommentEmpty(props.initialValue);
return (
<div className="border border-custom-border-200 rounded p-3 space-y-3">