From bcb9c736345191ee7407484faf044f9a085279f5 Mon Sep 17 00:00:00 2001 From: Vipin Chaudhary Date: Mon, 24 Feb 2025 14:33:55 +0530 Subject: [PATCH] [WEB-3411] fix: archive permission (#6661) * fix restore typo * fix archive permissions * fix restore typo --- packages/i18n/src/locales/en/translations.json | 3 ++- packages/i18n/src/locales/es/translations.json | 2 +- packages/i18n/src/locales/fr/translations.json | 2 +- packages/i18n/src/locales/ja/translations.json | 2 +- packages/i18n/src/locales/zh-CN/translations.json | 2 +- web/core/components/cycles/quick-actions.tsx | 2 +- .../issue-layouts/quick-action-dropdowns/archived-issue.tsx | 3 ++- 7 files changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/i18n/src/locales/en/translations.json b/packages/i18n/src/locales/en/translations.json index be2b4f2ad..7c74ff2ee 100644 --- a/packages/i18n/src/locales/en/translations.json +++ b/packages/i18n/src/locales/en/translations.json @@ -287,7 +287,7 @@ "Cancel": "Cancel", "edit": "Edit", "archive": "Archive", - "restor": "Restore", + "restore": "Restore", "open_in_new_tab": "Open in new tab", "delete": "Delete", "deleting": "Deleting", @@ -613,6 +613,7 @@ "open_in_new_tab": "Open in new tab", "copy_link": "Copy link", "archive": "Archive", + "restore": "Restore", "delete": "Delete", "remove_relation": "Remove relation", "subscribe": "Subscribe", diff --git a/packages/i18n/src/locales/es/translations.json b/packages/i18n/src/locales/es/translations.json index b4c815332..bc57dba1d 100644 --- a/packages/i18n/src/locales/es/translations.json +++ b/packages/i18n/src/locales/es/translations.json @@ -459,7 +459,7 @@ "Cancel": "Cancelar", "edit": "Editar", "archive": "Archivar", - "restor": "Restaurar", + "restore": "Restaurar", "open_in_new_tab": "Abrir en nueva pestaña", "delete": "Eliminar", "deleting": "Eliminando", diff --git a/packages/i18n/src/locales/fr/translations.json b/packages/i18n/src/locales/fr/translations.json index e43e36970..f258d5381 100644 --- a/packages/i18n/src/locales/fr/translations.json +++ b/packages/i18n/src/locales/fr/translations.json @@ -457,7 +457,7 @@ "Cancel": "Annuler", "edit": "Modifier", "archive": "Archiver", - "restor": "Restaurer", + "restore": "Restaurer", "open_in_new_tab": "Ouvrir dans un nouvel onglet", "delete": "Supprimer", "deleting": "Suppression", diff --git a/packages/i18n/src/locales/ja/translations.json b/packages/i18n/src/locales/ja/translations.json index 5dd9240de..eec78decc 100644 --- a/packages/i18n/src/locales/ja/translations.json +++ b/packages/i18n/src/locales/ja/translations.json @@ -457,7 +457,7 @@ "Cancel": "キャンセル", "edit": "編集", "archive": "アーカイブ", - "restor": "復元", + "restore": "復元", "open_in_new_tab": "新しいタブで開く", "delete": "削除", "deleting": "削除中", diff --git a/packages/i18n/src/locales/zh-CN/translations.json b/packages/i18n/src/locales/zh-CN/translations.json index e63780939..aca47f21a 100644 --- a/packages/i18n/src/locales/zh-CN/translations.json +++ b/packages/i18n/src/locales/zh-CN/translations.json @@ -457,7 +457,7 @@ "Cancel": "取消", "edit": "编辑", "archive": "归档", - "restor": "恢复", + "restore": "恢复", "open_in_new_tab": "在新标签页中打开", "delete": "删除", "deleting": "删除中", diff --git a/web/core/components/cycles/quick-actions.tsx b/web/core/components/cycles/quick-actions.tsx index 436ed0cdd..ff69d447d 100644 --- a/web/core/components/cycles/quick-actions.tsx +++ b/web/core/components/cycles/quick-actions.tsx @@ -134,7 +134,7 @@ export const CycleQuickActions: React.FC = observer((props) => { { key: "restore", action: handleRestoreCycle, - title: t("restor"), + title: t("restore"), icon: ArchiveRestoreIcon, shouldRender: isEditingAllowed && isArchived, }, diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx index 6367fb785..5957712e2 100644 --- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx +++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx @@ -44,7 +44,8 @@ export const ArchivedIssueQuickActions: React.FC = observer(( // auth const isEditingAllowed = allowPermissions([EUserPermissions.ADMIN, EUserPermissions.MEMBER], EUserPermissionsLevel.PROJECT) && !readOnly; - const isRestoringAllowed = handleRestore && isEditingAllowed; + const isRestoringAllowed = + handleRestore && allowPermissions([EUserPermissions.ADMIN, EUserPermissions.MEMBER], EUserPermissionsLevel.PROJECT); const issueLink = `${workspaceSlug}/projects/${issue.project_id}/archives/issues/${issue.id}`;