From 712339a6381d4690fccd03346617aff4b8e3a6d3 Mon Sep 17 00:00:00 2001
From: Prateek Shourya <prateekshourya29@gmail.com>
Date: Fri, 29 Nov 2024 14:53:30 +0530
Subject: [PATCH 1/2] minor improvements for workspace management (#6099)

* minor improvements for workspace management

* typo fix
---
 admin/core/components/workspace/list-item.tsx        | 2 +-
 admin/core/services/workspace.service.ts             | 3 ++-
 admin/core/store/workspace.store.ts                  | 6 +++---
 apiserver/plane/license/api/serializers/workspace.py | 3 +++
 apiserver/plane/license/api/views/workspace.py       | 2 +-
 packages/ui/src/icons/workspace-icon.tsx             | 9 ++++++++-
 6 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/admin/core/components/workspace/list-item.tsx b/admin/core/components/workspace/list-item.tsx
index 9289140f7..691e9dbb6 100644
--- a/admin/core/components/workspace/list-item.tsx
+++ b/admin/core/components/workspace/list-item.tsx
@@ -22,7 +22,7 @@ export const WorkspaceListItem = observer(({ workspaceId }: TWorkspaceListItemPr
   return (
     <Link
       key={workspaceId}
-      href={encodeURI(WEB_BASE_URL + "/" + workspace.slug)}
+      href={`${WEB_BASE_URL}/${encodeURIComponent(workspace.slug)}`}
       target="_blank"
       className="group flex items-center justify-between p-4 gap-2.5 truncate border border-custom-border-200/70 hover:border-custom-border-200 hover:bg-custom-background-90 rounded-md"
     >
diff --git a/admin/core/services/workspace.service.ts b/admin/core/services/workspace.service.ts
index 1de24fd9b..81ba36a6f 100644
--- a/admin/core/services/workspace.service.ts
+++ b/admin/core/services/workspace.service.ts
@@ -30,7 +30,8 @@ export class WorkspaceService extends APIService {
    * @returns Promise<any>
    */
   async workspaceSlugCheck(slug: string): Promise<any> {
-    return this.get(`/api/instances/workspace-slug-check/?slug=${slug}`)
+    const params = new URLSearchParams({ slug });
+    return this.get(`/api/instances/workspace-slug-check/?${params.toString()}`)
       .then((response) => response?.data)
       .catch((error) => {
         throw error?.response?.data;
diff --git a/admin/core/store/workspace.store.ts b/admin/core/store/workspace.store.ts
index dafe96760..f892e14f0 100644
--- a/admin/core/store/workspace.store.ts
+++ b/admin/core/store/workspace.store.ts
@@ -14,7 +14,7 @@ export interface IWorkspaceStore {
   // computed
   workspaceIds: string[];
   // helper actions
-  hydrate: (data: any) => void;
+  hydrate: (data: Record<string, IWorkspace>) => void;
   getWorkspaceById: (workspaceId: string) => IWorkspace | undefined;
   // fetch actions
   fetchWorkspaces: () => Promise<IWorkspace[]>;
@@ -59,9 +59,9 @@ export class WorkspaceStore implements IWorkspaceStore {
   // helper actions
   /**
    * @description Hydrates the workspaces
-   * @param data - any
+   * @param data - Record<string, IWorkspace>
    */
-  hydrate = (data: any) => {
+  hydrate = (data: Record<string, IWorkspace>) => {
     if (data) this.workspaces = data;
   };
 
diff --git a/apiserver/plane/license/api/serializers/workspace.py b/apiserver/plane/license/api/serializers/workspace.py
index 1d3bfa890..75dd938e4 100644
--- a/apiserver/plane/license/api/serializers/workspace.py
+++ b/apiserver/plane/license/api/serializers/workspace.py
@@ -18,6 +18,9 @@ class WorkspaceSerializer(BaseSerializer):
         # Check if the slug is restricted
         if value in RESTRICTED_WORKSPACE_SLUGS:
             raise serializers.ValidationError("Slug is not valid")
+        # Check uniqueness case-insensitively
+        if Workspace.objects.filter(slug__iexact=value).exists():
+            raise serializers.ValidationError("Slug is already in use")
         return value
 
     class Meta:
diff --git a/apiserver/plane/license/api/views/workspace.py b/apiserver/plane/license/api/views/workspace.py
index af9e8773a..14118d85b 100644
--- a/apiserver/plane/license/api/views/workspace.py
+++ b/apiserver/plane/license/api/views/workspace.py
@@ -25,7 +25,7 @@ class InstanceWorkSpaceAvailabilityCheckEndpoint(BaseAPIView):
             )
 
         workspace = (
-            Workspace.objects.filter(slug=slug).exists()
+            Workspace.objects.filter(slug__iexact=slug).exists()
             or slug in RESTRICTED_WORKSPACE_SLUGS
         )
         return Response({"status": not workspace}, status=status.HTTP_200_OK)
diff --git a/packages/ui/src/icons/workspace-icon.tsx b/packages/ui/src/icons/workspace-icon.tsx
index 07872b264..e15d33f30 100644
--- a/packages/ui/src/icons/workspace-icon.tsx
+++ b/packages/ui/src/icons/workspace-icon.tsx
@@ -3,7 +3,14 @@ import * as React from "react";
 import { ISvgIcons } from "./type";
 
 export const WorkspaceIcon: React.FC<ISvgIcons> = ({ className }) => (
-  <svg viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" className={className}>
+  <svg
+    viewBox="0 0 24 24"
+    fill="none"
+    xmlns="http://www.w3.org/2000/svg"
+    className={className}
+    role="img"
+    aria-label="Workspace icon"
+  >
     <path
       fillRule="evenodd"
       clipRule="evenodd"

From 4251b114c3d401e189998ce37aa066dec16d42a1 Mon Sep 17 00:00:00 2001
From: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Date: Fri, 29 Nov 2024 14:55:39 +0530
Subject: [PATCH 2/2] chore: enable no load by default (#5968)

* enable no load by default

* remove help section brackets

* fallback to server with mentions
---
 web/ce/constants/issues.ts                    |  3 --
 .../workspace/sidebar/help-section.tsx        | 38 +++++++++----------
 web/core/store/user/index.ts                  |  3 +-
 3 files changed, 19 insertions(+), 25 deletions(-)

diff --git a/web/ce/constants/issues.ts b/web/ce/constants/issues.ts
index d30ec492e..dc6ffbcb8 100644
--- a/web/ce/constants/issues.ts
+++ b/web/ce/constants/issues.ts
@@ -31,7 +31,4 @@ export const filterActivityOnSelectedFilters = (
 ): TIssueActivityComment[] =>
   activity.filter((activity) => filter.includes(activity.activity_type as TActivityFilters));
 
-// boolean to decide if the local db cache is enabled
-export const ENABLE_LOCAL_DB_CACHE = false;
-
 export const ENABLE_ISSUE_DEPENDENCIES = false;
diff --git a/web/core/components/workspace/sidebar/help-section.tsx b/web/core/components/workspace/sidebar/help-section.tsx
index 5570b5727..54df5909e 100644
--- a/web/core/components/workspace/sidebar/help-section.tsx
+++ b/web/core/components/workspace/sidebar/help-section.tsx
@@ -16,7 +16,6 @@ import { usePlatformOS } from "@/hooks/use-platform-os";
 // plane web components
 import { PlaneVersionNumber } from "@/plane-web/components/global";
 import { WorkspaceEditionBadge } from "@/plane-web/components/workspace";
-import { ENABLE_LOCAL_DB_CACHE } from "@/plane-web/constants/issues";
 
 export interface WorkspaceHelpSectionProps {
   setSidebarActive?: React.Dispatch<React.SetStateAction<boolean>>;
@@ -111,23 +110,21 @@ export const SidebarHelpSection: React.FC<WorkspaceHelpSectionProps> = observer(
               </a>
             </CustomMenu.MenuItem>
             <div className="my-1 border-t border-custom-border-200" />
-            {ENABLE_LOCAL_DB_CACHE && (
-              <CustomMenu.MenuItem>
-                <div
-                  onClick={(e) => {
-                    e.preventDefault();
-                    e.stopPropagation();
-                  }}
-                  className="flex w-full items-center justify-between text-xs hover:bg-custom-background-80"
-                >
-                  <span className="racking-tight">Local Cache</span>
-                  <ToggleSwitch
-                    value={canUseLocalDB}
-                    onChange={() => toggleLocalDB(workspaceSlug?.toString(), projectId?.toString())}
-                  />
-                </div>
-              </CustomMenu.MenuItem>
-            )}
+            <CustomMenu.MenuItem>
+              <div
+                onClick={(e) => {
+                  e.preventDefault();
+                  e.stopPropagation();
+                }}
+                className="flex w-full items-center justify-between text-xs hover:bg-custom-background-80"
+              >
+                <span className="racking-tight">Local Cache</span>
+                <ToggleSwitch
+                  value={canUseLocalDB}
+                  onChange={() => toggleLocalDB(workspaceSlug?.toString(), projectId?.toString())}
+                />
+              </div>
+            </CustomMenu.MenuItem>
             <CustomMenu.MenuItem>
               <button
                 type="button"
@@ -173,8 +170,9 @@ export const SidebarHelpSection: React.FC<WorkspaceHelpSectionProps> = observer(
           <Tooltip tooltipContent={`${isCollapsed ? "Expand" : "Hide"}`} isMobile={isMobile}>
             <button
               type="button"
-              className={`grid place-items-center rounded-md p-1 text-custom-text-200 outline-none hover:bg-custom-background-90 hover:text-custom-text-100 ${isCollapsed ? "w-full" : ""
-                }`}
+              className={`grid place-items-center rounded-md p-1 text-custom-text-200 outline-none hover:bg-custom-background-90 hover:text-custom-text-100 ${
+                isCollapsed ? "w-full" : ""
+              }`}
               onClick={() => toggleSidebar()}
             >
               <MoveLeft className={`h-4 w-4 duration-300 ${isCollapsed ? "rotate-180" : ""}`} />
diff --git a/web/core/store/user/index.ts b/web/core/store/user/index.ts
index 008f25af3..eac764a3d 100644
--- a/web/core/store/user/index.ts
+++ b/web/core/store/user/index.ts
@@ -9,7 +9,6 @@ import { TUserPermissions } from "@plane/types/src/enums";
 import { API_BASE_URL } from "@/helpers/common.helper";
 // local
 import { persistence } from "@/local-db/storage.sqlite";
-import { ENABLE_LOCAL_DB_CACHE } from "@/plane-web/constants/issues";
 import { EUserPermissions } from "@/plane-web/constants/user-permissions";
 // services
 import { AuthService } from "@/services/auth.service";
@@ -278,6 +277,6 @@ export class UserStore implements IUserStore {
   }
 
   get localDBEnabled() {
-    return ENABLE_LOCAL_DB_CACHE && this.userSettings.canUseLocalDB;
+    return this.userSettings.canUseLocalDB;
   }
 }