From c637639a3e8967160b7594eb38284c1effde791e Mon Sep 17 00:00:00 2001 From: rahulramesha <71900764+rahulramesha@users.noreply.github.com> Date: Tue, 2 Jul 2024 19:26:26 +0530 Subject: [PATCH] tweak pagination and virtualization thresholds to have a smoother scroll (#4991) --- web/core/components/gantt-chart/sidebar/issues/sidebar.tsx | 2 +- web/core/components/issues/issue-layouts/kanban/block.tsx | 3 ++- web/core/components/issues/issue-layouts/list/block-root.tsx | 1 + web/core/components/issues/issue-layouts/list/list-group.tsx | 2 +- .../components/issues/issue-layouts/spreadsheet/issue-row.tsx | 1 + .../issues/issue-layouts/spreadsheet/spreadsheet-table.tsx | 2 +- 6 files changed, 7 insertions(+), 4 deletions(-) diff --git a/web/core/components/gantt-chart/sidebar/issues/sidebar.tsx b/web/core/components/gantt-chart/sidebar/issues/sidebar.tsx index 7fe7bbc02..b0be6b835 100644 --- a/web/core/components/gantt-chart/sidebar/issues/sidebar.tsx +++ b/web/core/components/gantt-chart/sidebar/issues/sidebar.tsx @@ -54,7 +54,7 @@ export const IssueGanttSidebar: React.FC = observer((props) => { ganttContainerRef, isPaginating ? null : intersectionElement, loadMoreBlocks, - "50% 0% 50% 0%" + "100% 0% 100% 0%" ); const handleOnDrop = ( diff --git a/web/core/components/issues/issue-layouts/kanban/block.tsx b/web/core/components/issues/issue-layouts/kanban/block.tsx index 114742e78..0d9ea8a13 100644 --- a/web/core/components/issues/issue-layouts/kanban/block.tsx +++ b/web/core/components/issues/issue-layouts/kanban/block.tsx @@ -224,7 +224,8 @@ export const KanbanIssueBlock: React.FC = observer((props) => { classNames="space-y-2 px-3 py-2" root={scrollableContainerRef} defaultHeight="100px" - horizontalOffset={50} + horizontalOffset={100} + verticalOffset={200} > = observer((props) => { defaultHeight="3rem" root={containerRef} classNames={`relative ${isLastChild && !isExpanded ? "" : "border-b border-b-custom-border-200"}`} + verticalOffset={100} > { const nextPageResults = getPaginationData(group.id, undefined)?.nextPageResults; const isPaginating = !!getIssueLoader(group.id); - useIntersectionObserver(containerRef, isPaginating ? null : intersectionElement, loadMoreIssues, `50% 0% 50% 0%`); + useIntersectionObserver(containerRef, isPaginating ? null : intersectionElement, loadMoreIssues, `100% 0% 100% 0%`); const shouldLoadMore = nextPageResults === undefined && groupIssueCount !== undefined && groupIssueIds diff --git a/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx b/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx index 2cdadf7c5..58ed247d1 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx @@ -84,6 +84,7 @@ export const SpreadsheetIssueRow = observer((props: Props) => { "group selected-issue-row": isIssueSelected, "border-[0.5px] border-custom-border-400": isIssueActive, })} + verticalOffset={100} > { const isPaginating = !!getIssueLoader(); - useIntersectionObserver(containerRef, isPaginating ? null : intersectionElement, loadMoreIssues, `50% 0% 50% 0%`); + useIntersectionObserver(containerRef, isPaginating ? null : intersectionElement, loadMoreIssues, `100% 0% 100% 0%`); const handleKeyBoardNavigation = useTableKeyboardNavigation();