diff --git a/web/components/issues/issue-layouts/filters/header/display-filters/display-filters-selection.tsx b/web/components/issues/issue-layouts/filters/header/display-filters/display-filters-selection.tsx index 09173fec8..0133f9015 100644 --- a/web/components/issues/issue-layouts/filters/header/display-filters/display-filters-selection.tsx +++ b/web/components/issues/issue-layouts/filters/header/display-filters/display-filters-selection.tsx @@ -47,8 +47,7 @@ export const DisplayFiltersSelection: React.FC = observer((props) => { {isDisplayFilterEnabled("group_by") && (
handleDisplayFiltersUpdate({ @@ -65,8 +64,7 @@ export const DisplayFiltersSelection: React.FC = observer((props) => { displayFilters.layout === "kanban" && (
handleDisplayFiltersUpdate({ sub_group_by: val, diff --git a/web/components/issues/issue-layouts/filters/header/display-filters/group-by.tsx b/web/components/issues/issue-layouts/filters/header/display-filters/group-by.tsx index b74fe2761..aa057e417 100644 --- a/web/components/issues/issue-layouts/filters/header/display-filters/group-by.tsx +++ b/web/components/issues/issue-layouts/filters/header/display-filters/group-by.tsx @@ -4,23 +4,23 @@ import { observer } from "mobx-react-lite"; // components import { FilterHeader, FilterOption } from "components/issues"; // types -import { TIssueGroupByOptions } from "types"; +import { IIssueDisplayFilterOptions, TIssueGroupByOptions } from "types"; // constants import { ISSUE_GROUP_BY_OPTIONS } from "constants/issue"; type Props = { - selectedGroupBy: TIssueGroupByOptions | undefined; - selectedSubGroupBy: TIssueGroupByOptions | undefined; + displayFilters: IIssueDisplayFilterOptions; groupByOptions: TIssueGroupByOptions[]; handleUpdate: (val: TIssueGroupByOptions) => void; }; export const FilterGroupBy: React.FC = observer((props) => { - const { selectedGroupBy, selectedSubGroupBy, groupByOptions, handleUpdate } = props; + const { displayFilters, groupByOptions, handleUpdate } = props; const [previewEnabled, setPreviewEnabled] = useState(true); - const activeGroupBy = selectedGroupBy ?? null; + const selectedGroupBy = displayFilters.group_by ?? null; + const selectedSubGroupBy = displayFilters.sub_group_by ?? null; return ( <> @@ -32,12 +32,13 @@ export const FilterGroupBy: React.FC = observer((props) => { {previewEnabled && (
{ISSUE_GROUP_BY_OPTIONS.filter((option) => groupByOptions.includes(option.key)).map((groupBy) => { - if (selectedSubGroupBy !== null && groupBy.key === selectedSubGroupBy) return null; + if (displayFilters.layout === "kanban" && selectedSubGroupBy !== null && groupBy.key === selectedSubGroupBy) + return null; return ( handleUpdate(groupBy.key)} title={groupBy.title} multiple={false} diff --git a/web/components/issues/issue-layouts/filters/header/display-filters/sub-group-by.tsx b/web/components/issues/issue-layouts/filters/header/display-filters/sub-group-by.tsx index 83f09092d..f66422427 100644 --- a/web/components/issues/issue-layouts/filters/header/display-filters/sub-group-by.tsx +++ b/web/components/issues/issue-layouts/filters/header/display-filters/sub-group-by.tsx @@ -4,22 +4,24 @@ import { observer } from "mobx-react-lite"; // components import { FilterHeader, FilterOption } from "components/issues"; // types -import { TIssueGroupByOptions } from "types"; +import { IIssueDisplayFilterOptions, TIssueGroupByOptions } from "types"; // constants import { ISSUE_GROUP_BY_OPTIONS } from "constants/issue"; type Props = { - selectedGroupBy: TIssueGroupByOptions | undefined; - selectedSubGroupBy: TIssueGroupByOptions | undefined; + displayFilters: IIssueDisplayFilterOptions; handleUpdate: (val: TIssueGroupByOptions) => void; subGroupByOptions: TIssueGroupByOptions[]; }; export const FilterSubGroupBy: React.FC = observer((props) => { - const { selectedGroupBy, selectedSubGroupBy, handleUpdate, subGroupByOptions } = props; + const { displayFilters, handleUpdate, subGroupByOptions } = props; const [previewEnabled, setPreviewEnabled] = useState(true); + const selectedGroupBy = displayFilters.group_by ?? null; + const selectedSubGroupBy = displayFilters.sub_group_by ?? null; + return ( <>