fix: state group choices (#8198)

apps/api/plane/api/serializers/intake.py

@@ -1,7 +1,7 @@
 # Module imports
 from .base import BaseSerializer
 from .issue import IssueExpandSerializer
-from plane.db.models import IntakeIssue, Issue
+from plane.db.models import IntakeIssue, Issue, State, StateGroup
 from rest_framework import serializers
 
 
@@ -108,7 +108,6 @@ class IntakeIssueUpdateSerializer(BaseSerializer):
         Validate that if status is being changed to accepted (1),
         the project has a default state to transition to.
         """
-        from plane.db.models import State
 
         # Check if status is being updated to accepted
         if attrs.get("status") == 1:
@@ -116,7 +115,7 @@ class IntakeIssueUpdateSerializer(BaseSerializer):
             issue = intake_issue.issue
 
             # Check if issue is in TRIAGE state
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Verify default state exists before allowing the update
                 default_state = State.objects.filter(
                     workspace=intake_issue.workspace, project=intake_issue.project, default=True
@@ -133,7 +132,6 @@ class IntakeIssueUpdateSerializer(BaseSerializer):
         """
         Update intake issue and transition associated issue state if accepted.
         """
-        from plane.db.models import State
 
         # Update the intake issue with validated data
         instance = super().update(instance, validated_data)
@@ -141,7 +139,7 @@ class IntakeIssueUpdateSerializer(BaseSerializer):
         # If status is accepted (1), update the associated issue state from TRIAGE to default
         if validated_data.get("status") == 1:
             issue = instance.issue
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Get the default project state
                 default_state = State.objects.filter(
                     workspace=instance.workspace, project=instance.project, default=True

apps/api/plane/api/serializers/state.py

@@ -1,6 +1,6 @@
 # Module imports
 from .base import BaseSerializer
-from plane.db.models import State
+from plane.db.models import State, StateGroup
 from rest_framework import serializers
 
 
@@ -17,7 +17,7 @@ class StateSerializer(BaseSerializer):
         if data.get("default", False):
             State.objects.filter(project_id=self.context.get("project_id")).update(default=False)
 
-        if data.get("group", None) == State.TRIAGE:
+        if data.get("group", None) == StateGroup.TRIAGE.value:
             raise serializers.ValidationError("Cannot create triage state")
         return data
 

apps/api/plane/api/views/intake.py

@@ -23,7 +23,7 @@ from plane.api.serializers import (
 )
 from plane.app.permissions import ProjectLitePermission
 from plane.bgtasks.issue_activities_task import issue_activity
-from plane.db.models import Intake, IntakeIssue, Issue, Project, ProjectMember, State
+from plane.db.models import Intake, IntakeIssue, Issue, Project, ProjectMember, State, StateGroup
 from plane.utils.host import base_host
 from .base import BaseAPIView
 from plane.db.models.intake import SourceType
@@ -170,8 +170,8 @@ class IntakeIssueListCreateAPIEndpoint(BaseAPIView):
 
         if not triage_state:
             triage_state = State.objects.create(
-                name="Intake Triage",
-                group=State.TRIAGE,
+                name="Triage",
+                group=StateGroup.TRIAGE.value,
                 project_id=project_id,
                 workspace_id=project.workspace_id,
                 color="#4E5355",

apps/api/plane/api/views/project.py

@@ -24,6 +24,7 @@ from plane.db.models import (
     DeployBoard,
     ProjectMember,
     State,
+    DEFAULT_STATES,
     Workspace,
     UserFavorite,
 )
@@ -232,47 +233,6 @@ class ProjectListCreateAPIEndpoint(BaseAPIView):
                         user_id=serializer.instance.project_lead,
                     )
 
-                # Default states
-                states = [
-                    {
-                        "name": "Backlog",
-                        "color": "#60646C",
-                        "sequence": 15000,
-                        "group": "backlog",
-                        "default": True,
-                    },
-                    {
-                        "name": "Todo",
-                        "color": "#60646C",
-                        "sequence": 25000,
-                        "group": "unstarted",
-                    },
-                    {
-                        "name": "In Progress",
-                        "color": "#F59E0B",
-                        "sequence": 35000,
-                        "group": "started",
-                    },
-                    {
-                        "name": "Done",
-                        "color": "#46A758",
-                        "sequence": 45000,
-                        "group": "completed",
-                    },
-                    {
-                        "name": "Cancelled",
-                        "color": "#9AA4BC",
-                        "sequence": 55000,
-                        "group": "cancelled",
-                    },
-                    {
-                        "name": "Intake Triage",
-                        "color": "#4E5355",
-                        "sequence": 65000,
-                        "group": State.TRIAGE,
-                    },
-                ]
-
                 State.objects.bulk_create(
                     [
                         State(
@@ -285,7 +245,7 @@ class ProjectListCreateAPIEndpoint(BaseAPIView):
                             default=state.get("default", False),
                             created_by=request.user,
                         )
-                        for state in states
+                        for state in DEFAULT_STATES
                     ]
                 )