binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix render-if-visible-hoc's style calculation performance issue (#5647)

Browse source
This commit is contained in:
rahulramesha 2024-09-19 10:02:46 +05:30 • committed by GitHub
parent bd0ca0cded
commit c8c9638e5a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 65 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

8
web/core/store/issue/issue.store.ts
View file

@ -77,7 +77,7 @@ export class IssueStore implements IIssueStore {
* @returns {void}
*/
updateIssue = (issueId: string, issue: Partial<TIssue>) => {
if (!issue || !issueId || isEmpty(this.issuesMap) || !this.issuesMap[issueId]) return;
if (!issue || !issueId || !this.issuesMap[issueId]) return;
runInAction(() => {
set(this.issuesMap, [issueId, "updated_at"], getCurrentDateTimeInISO());
Object.keys(issue).forEach((key) => {
@ -92,7 +92,7 @@ export class IssueStore implements IIssueStore {
* @returns {void}
*/
removeIssue = (issueId: string) => {
if (!issueId || isEmpty(this.issuesMap) || !this.issuesMap[issueId]) return;
if (!issueId || !this.issuesMap[issueId]) return;
runInAction(() => {
delete this.issuesMap[issueId];
});
@ -105,7 +105,7 @@ export class IssueStore implements IIssueStore {
* @returns {TIssue | undefined}
*/
getIssueById = computedFn((issueId: string) => {
if (!issueId || isEmpty(this.issuesMap) || !this.issuesMap[issueId]) return undefined;
if (!issueId || !this.issuesMap[issueId]) return undefined;
return this.issuesMap[issueId];
});
@ -116,7 +116,7 @@ export class IssueStore implements IIssueStore {
* @returns {Record<string, TIssue> | undefined}
*/
getIssuesByIds = computedFn((issueIds: string[], type: "archived" | "un-archived") => {
if (!issueIds || issueIds.length <= 0 || isEmpty(this.issuesMap)) return [];
if (!issueIds || issueIds.length <= 0) return [];
const filteredIssues: TIssue[] = [];
Object.values(issueIds).forEach((issueId) => {
// if type is archived then check archived_at is not null