From cdf86391f00759944b9af53db425d5789f06ce59 Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Date: Fri, 22 Mar 2024 18:36:09 +0530
Subject: [PATCH] fix: module filter and order by (#4040)

---
 web/components/modules/modules-list-view.tsx | 2 +-
 web/helpers/module.helper.ts                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/web/components/modules/modules-list-view.tsx b/web/components/modules/modules-list-view.tsx
index ce8ce4e65..b0ff67609 100644
--- a/web/components/modules/modules-list-view.tsx
+++ b/web/components/modules/modules-list-view.tsx
@@ -38,7 +38,7 @@ export const ModulesListView: React.FC = observer(() => {
       </>
     );
 
-  if (totalFilters > 0 || searchQuery.trim() !== "")
+  if (totalFilters > 0 && filteredModuleIds.length === 0)
     return (
       <div className="h-full w-full grid place-items-center">
         <div className="text-center">
diff --git a/web/helpers/module.helper.ts b/web/helpers/module.helper.ts
index 1a01915f2..f5cbfe08a 100644
--- a/web/helpers/module.helper.ts
+++ b/web/helpers/module.helper.ts
@@ -22,7 +22,7 @@ export const orderModules = (modules: IModule[], orderByKey: TModuleOrderByOptio
       (m) => {
         let progress = (m.completed_issues + m.cancelled_issues) / m.total_issues;
         if (isNaN(progress)) progress = 0;
-        return orderByKey === "progress" ? progress : !progress;
+        return orderByKey === "progress" ? progress : -progress;
       },
       "name",
     ]);