From d1bfed950afb2ce7792b3a402cc145713d41f1f3 Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Fri, 14 Jun 2024 16:39:25 +0530 Subject: [PATCH] [WEB-1608] fix: deleted project errors (#4820) * dev: fix project not found error * [WEB-1608] chore: fix no projects found logic. --------- Co-authored-by: pablohashescobar --- apiserver/plane/app/views/project/base.py | 6 ++++++ web/core/layouts/auth-layout/project-wrapper.tsx | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/apiserver/plane/app/views/project/base.py b/apiserver/plane/app/views/project/base.py index 78a9b9547..55471e674 100644 --- a/apiserver/plane/app/views/project/base.py +++ b/apiserver/plane/app/views/project/base.py @@ -240,6 +240,12 @@ class ProjectViewSet(BaseViewSet): ) ).first() + if project is None: + return Response( + {"error": "Project does not exist"}, + status=status.HTTP_404_NOT_FOUND, + ) + serializer = ProjectListSerializer(project) return Response(serializer.data, status=status.HTTP_200_OK) diff --git a/web/core/layouts/auth-layout/project-wrapper.tsx b/web/core/layouts/auth-layout/project-wrapper.tsx index 593be9046..606cc76b5 100644 --- a/web/core/layouts/auth-layout/project-wrapper.tsx +++ b/web/core/layouts/auth-layout/project-wrapper.tsx @@ -116,7 +116,7 @@ export const ProjectAuthWrapper: FC = observer((props) => { if (projectExists && projectId && hasPermissionToProject[projectId.toString()] === false) return ; // check if the project info is not found. - if (!projectExists && projectId && hasPermissionToProject[projectId.toString()] === false) + if (!projectExists && projectId && !!hasPermissionToProject[projectId.toString()] === false) return (