From d366ac158135b6fed7095ddfba85f45c4efae302 Mon Sep 17 00:00:00 2001 From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Date: Wed, 7 May 2025 00:28:43 +0530 Subject: [PATCH] [WEB-2508] fix: page favorite item title mutation (#7020) * fix: remove page favorite item title fallback value * refactor: use nullish coalescing operator --- web/core/hooks/use-favorite-item-details.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/web/core/hooks/use-favorite-item-details.tsx b/web/core/hooks/use-favorite-item-details.tsx index 343e143ed..eadc64f7c 100644 --- a/web/core/hooks/use-favorite-item-details.tsx +++ b/web/core/hooks/use-favorite-item-details.tsx @@ -43,23 +43,23 @@ export const useFavoriteItemDetails = (workspaceSlug: string, favorite: IFavorit switch (favoriteItemEntityType) { case "project": - itemTitle = currentProjectDetails?.name || favoriteItemName; + itemTitle = currentProjectDetails?.name ?? favoriteItemName; itemIcon = getFavoriteItemIcon("project", currentProjectDetails?.logo_props || favoriteItemLogoProps); break; case "page": - itemTitle = getPageName(pageDetail?.name || favoriteItemName); - itemIcon = getFavoriteItemIcon("page", pageDetail?.logo_props || favoriteItemLogoProps); + itemTitle = getPageName(pageDetail?.name ?? favoriteItemName); + itemIcon = getFavoriteItemIcon("page", pageDetail?.logo_props ?? favoriteItemLogoProps); break; case "view": - itemTitle = viewDetails?.name || favoriteItemName; + itemTitle = viewDetails?.name ?? favoriteItemName; itemIcon = getFavoriteItemIcon("view", viewDetails?.logo_props || favoriteItemLogoProps); break; case "cycle": - itemTitle = cycleDetail?.name || favoriteItemName; + itemTitle = cycleDetail?.name ?? favoriteItemName; itemIcon = getFavoriteItemIcon("cycle"); break; case "module": - itemTitle = moduleDetail?.name || favoriteItemName; + itemTitle = moduleDetail?.name ?? favoriteItemName; itemIcon = getFavoriteItemIcon("module"); break; default: {