From d5eb374217bc83dc310469355b8387abf963ee88 Mon Sep 17 00:00:00 2001 From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Date: Fri, 18 Jul 2025 20:06:48 +0530 Subject: [PATCH] [WEB-561] refactor: editor build config (#7442) * refactor: editor build config * fix: type errors --- packages/editor/package.json | 2 +- packages/editor/src/core/helpers/scroll-to-node.ts | 1 + packages/editor/src/core/types/editor.ts | 1 + packages/editor/tsconfig.json | 5 ++++- 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/editor/package.json b/packages/editor/package.json index 4d0767e6a..c1dc2ee7f 100644 --- a/packages/editor/package.json +++ b/packages/editor/package.json @@ -22,7 +22,7 @@ } }, "scripts": { - "build": "tsup --minify", + "build": "tsc && tsup --minify", "dev": "tsup --watch", "check:lint": "eslint . --max-warnings 0", "check:types": "tsc --noEmit", diff --git a/packages/editor/src/core/helpers/scroll-to-node.ts b/packages/editor/src/core/helpers/scroll-to-node.ts index 973f3cf14..7e5aa0979 100644 --- a/packages/editor/src/core/helpers/scroll-to-node.ts +++ b/packages/editor/src/core/helpers/scroll-to-node.ts @@ -32,6 +32,7 @@ function scrollToNode(editor: Editor, pos: number): void { } } +// eslint-disable-next-line no-undef export function scrollToNodeViaDOMCoordinates(editor: Editor, pos: number, behavior?: ScrollBehavior): void { const view = editor.view; diff --git a/packages/editor/src/core/types/editor.ts b/packages/editor/src/core/types/editor.ts index d4d572502..b91d5fdee 100644 --- a/packages/editor/src/core/types/editor.ts +++ b/packages/editor/src/core/types/editor.ts @@ -111,6 +111,7 @@ export interface EditorRefApi extends EditorReadOnlyRefApi { onDocumentInfoChange: (callback: (documentInfo: TDocumentInfo) => void) => () => void; onHeadingChange: (callback: (headings: IMarking[]) => void) => () => void; onStateChange: (callback: () => void) => () => void; + // eslint-disable-next-line no-undef scrollToNodeViaDOMCoordinates: (behavior?: ScrollBehavior, position?: number) => void; setEditorValueAtCursorPosition: (content: string) => void; setFocusAtPosition: (position: number) => void; diff --git a/packages/editor/tsconfig.json b/packages/editor/tsconfig.json index 1bb68d838..3bf34d969 100644 --- a/packages/editor/tsconfig.json +++ b/packages/editor/tsconfig.json @@ -4,8 +4,11 @@ "lib": ["ES2022", "DOM"], "module": "ESNext", "moduleResolution": "bundler", - "target": "ESNext", + "noEmit": true, + "skipLibCheck": true, "sourceMap": true, + "target": "ESNext", + "types": ["node"], "baseUrl": ".", "paths": { "@/*": ["./src/core/*"],