binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: issue delete notification message updated (#5373)

Browse source
This commit is contained in:
Anmol Singh Bhatia 2024-08-16 16:30:54 +05:30 • committed by GitHub
parent a36adae995
commit d60e988ca1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/types/src/workspace-notifications.d.ts vendored
View file

@ -28,7 +28,7 @@ export type TNotificationData = {
actor: string | undefined; actor: string | undefined;
field: string | undefined; field: string | undefined;
issue_comment: string | undefined; issue_comment: string | undefined;
verb: "created" | "updated"; verb: "created" | "updated" | "deleted";
new_value: string | undefined; new_value: string | undefined;
old_value: string | undefined; old_value: string | undefined;
}; };

52
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx
View file

@ -104,29 +104,35 @@ export const NotificationItem: FC<TNotificationItem> = observer((props) => {
: notificationField === "None" : notificationField === "None"
? null ? null
: replaceUnderscoreIfSnakeCase(notificationField)}{" "} : replaceUnderscoreIfSnakeCase(notificationField)}{" "}
{!["comment", "archived_at", "None"].includes(notificationField) ? "to" : ""} {notification?.data?.issue_activity.verb !== "deleted" && (
<span className="font-semibold"> <>
{" "} {!["comment", "archived_at", "None"].includes(notificationField) ? "to" : ""}
{notificationField !== "None" ? ( <span className="font-semibold">
notificationField !== "comment" ? ( {" "}
notificationField === "target_date" ? ( {notificationField !== "None" ? (
renderFormattedDate(notification?.data?.issue_activity.new_value) notificationField !== "comment" ? (
) : notificationField === "attachment" ? ( notificationField === "target_date" ? (
"the issue" renderFormattedDate(notification?.data?.issue_activity.new_value)
) : notificationField === "description" ? ( ) : notificationField === "attachment" ? (
stripAndTruncateHTML(notification?.data?.issue_activity.new_value || "", 55) "the issue"
) : notificationField === "archived_at" ? null : ( ) : notificationField === "description" ? (
notification?.data?.issue_activity.new_value stripAndTruncateHTML(notification?.data?.issue_activity.new_value || "", 55)
) ) : notificationField === "archived_at" ? null : (
) : ( notification?.data?.issue_activity.new_value
<span> )
{sanitizeCommentForNotification(notification?.data?.issue_activity.new_value ?? undefined)} ) : (
</span> <span>
) {sanitizeCommentForNotification(
) : ( notification?.data?.issue_activity.new_value ?? undefined
"the issue and assigned it to you." )}
)} </span>
</span> )
) : (
"the issue and assigned it to you."
)}
</span>
</>
)}
</> </>
) : ( ) : (
<span className="semi-bold">{notification.message}</span> <span className="semi-bold">{notification.message}</span>