binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: issue delete notification message updated (#5373)

Browse source
This commit is contained in:
Anmol Singh Bhatia 2024-08-16 16:30:54 +05:30 • committed by GitHub
parent a36adae995
commit d60e988ca1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/types/src/workspace-notifications.d.ts vendored
View file

@ -28,7 +28,7 @@ export type TNotificationData = {
actor: string | undefined;
field: string | undefined;
issue_comment: string | undefined;
verb: "created" | "updated";
verb: "created" | "updated" | "deleted";
new_value: string | undefined;
old_value: string | undefined;
};

8
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx
View file

@ -104,6 +104,8 @@ export const NotificationItem: FC<TNotificationItem> = observer((props) => {
: notificationField === "None"
? null
: replaceUnderscoreIfSnakeCase(notificationField)}{" "}
{notification?.data?.issue_activity.verb !== "deleted" && (
<>
{!["comment", "archived_at", "None"].includes(notificationField) ? "to" : ""}
<span className="font-semibold">
{" "}
@ -120,7 +122,9 @@ export const NotificationItem: FC<TNotificationItem> = observer((props) => {
)
) : (
<span>
{sanitizeCommentForNotification(notification?.data?.issue_activity.new_value ?? undefined)}
{sanitizeCommentForNotification(
notification?.data?.issue_activity.new_value ?? undefined
)}
</span>
)
) : (
@ -128,6 +132,8 @@ export const NotificationItem: FC<TNotificationItem> = observer((props) => {
)}
</span>
</>
)}
</>
) : (
<span className="semi-bold">{notification.message}</span>
)}